mirror of
https://github.com/discourse/discourse.git
synced 2024-11-24 06:15:28 +08:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
38 lines
1.3 KiB
Ruby
38 lines
1.3 KiB
Ruby
require 'rails_helper'
|
|
require_dependency 'jobs/base'
|
|
require_dependency 'jobs/regular/process_post'
|
|
|
|
describe Jobs::NotifyMovedPosts do
|
|
|
|
it "raises an error without post_ids" do
|
|
expect { Jobs::NotifyMovedPosts.new.execute(moved_by_id: 1234) }.to raise_error(Discourse::InvalidParameters)
|
|
end
|
|
|
|
it "raises an error without moved_by_id" do
|
|
expect { Jobs::NotifyMovedPosts.new.execute(post_ids: [1,2,3]) }.to raise_error(Discourse::InvalidParameters)
|
|
end
|
|
|
|
|
|
context 'with post ids' do
|
|
let!(:p1) { Fabricate(:post) }
|
|
let!(:p2) { Fabricate(:post, user: Fabricate(:evil_trout), topic: p1.topic) }
|
|
let!(:p3) { Fabricate(:post, user: p1.user, topic: p1.topic) }
|
|
let(:admin) { Fabricate(:admin) }
|
|
|
|
let(:moved_post_notifications) { Notification.where(notification_type: Notification.types[:moved_post]) }
|
|
|
|
it "should create two notifications" do
|
|
expect { Jobs::NotifyMovedPosts.new.execute(post_ids: [p1.id, p2.id, p3.id], moved_by_id: admin.id) }.to change(moved_post_notifications, :count).by(2)
|
|
end
|
|
|
|
context 'when moved by one of the posters' do
|
|
it "create one notifications, because the poster is the mover" do
|
|
expect { Jobs::NotifyMovedPosts.new.execute(post_ids: [p1.id, p2.id, p3.id], moved_by_id: p1.user_id) }.to change(moved_post_notifications, :count).by(1)
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
|
|
end
|