mirror of
https://github.com/discourse/discourse.git
synced 2024-12-01 08:43:43 +08:00
60c67afba4
- Improves styleguide support - Adds toggle color scheme to styleguide - Adds properties mutators to styleguide - Attempts to quit a session as soon as done with it in system specs, this should at least free resources faster - Refactors fabricators to simplify them - Adds more fabricators (uploads for example) - Starts implementing components pattern in system specs - Uses Chat::Message creator to create messages in system specs, this should help to have more real specs as the side effects should now happen
204 lines
7.8 KiB
Ruby
204 lines
7.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe "Single thread in side panel", type: :system, js: true do
|
|
fab!(:current_user) { Fabricate(:user) }
|
|
|
|
let(:chat_page) { PageObjects::Pages::Chat.new }
|
|
let(:channel_page) { PageObjects::Pages::ChatChannel.new }
|
|
let(:side_panel) { PageObjects::Pages::ChatSidePanel.new }
|
|
let(:thread_page) { PageObjects::Pages::ChatThread.new }
|
|
let(:chat_drawer_page) { PageObjects::Pages::ChatDrawer.new }
|
|
let(:sidebar_page) { PageObjects::Pages::Sidebar.new }
|
|
|
|
before do
|
|
chat_system_bootstrap(current_user, [channel])
|
|
sign_in(current_user)
|
|
end
|
|
|
|
context "when enable_experimental_chat_threaded_discussions is disabled" do
|
|
fab!(:channel) { Fabricate(:chat_channel) }
|
|
before { SiteSetting.enable_experimental_chat_threaded_discussions = false }
|
|
|
|
it "does not open the side panel for a single thread" do
|
|
thread =
|
|
chat_thread_chain_bootstrap(channel: channel, users: [current_user, Fabricate(:user)])
|
|
chat_page.visit_channel(channel)
|
|
channel_page.hover_message(thread.original_message)
|
|
expect(page).not_to have_css(".chat-message-thread-btn")
|
|
end
|
|
end
|
|
|
|
context "when threading_enabled is false for the channel" do
|
|
fab!(:channel) { Fabricate(:chat_channel) }
|
|
before do
|
|
SiteSetting.enable_experimental_chat_threaded_discussions = true
|
|
channel.update!(threading_enabled: false)
|
|
end
|
|
|
|
it "does not open the side panel for a single thread" do
|
|
thread =
|
|
chat_thread_chain_bootstrap(channel: channel, users: [current_user, Fabricate(:user)])
|
|
chat_page.visit_channel(channel)
|
|
channel_page.hover_message(thread.original_message)
|
|
expect(page).not_to have_css(".chat-message-thread-btn")
|
|
end
|
|
end
|
|
|
|
context "when enable_experimental_chat_threaded_discussions is true and threading is enabled for the channel" do
|
|
fab!(:user_2) { Fabricate(:user) }
|
|
fab!(:channel) { Fabricate(:chat_channel, threading_enabled: true) }
|
|
fab!(:thread) { chat_thread_chain_bootstrap(channel: channel, users: [current_user, user_2]) }
|
|
|
|
before { SiteSetting.enable_experimental_chat_threaded_discussions = true }
|
|
|
|
context "when in full page" do
|
|
context "when switching channel" do
|
|
fab!(:channel_2) { Fabricate(:chat_channel, threading_enabled: true) }
|
|
|
|
before { channel_2.add(current_user) }
|
|
|
|
it "closes the opened thread" do
|
|
chat_page.visit_thread(thread)
|
|
expect(side_panel).to have_open_thread(thread)
|
|
|
|
sidebar_page.open_channel(channel_2)
|
|
|
|
expect(side_panel).to have_no_open_thread
|
|
end
|
|
end
|
|
|
|
context "when closing the thread" do
|
|
it "closes it" do
|
|
chat_page.visit_thread(thread)
|
|
expect(side_panel).to have_open_thread(thread)
|
|
|
|
thread_page.close
|
|
|
|
expect(side_panel).to have_no_open_thread
|
|
end
|
|
end
|
|
end
|
|
|
|
it "opens the single thread in the drawer using the indicator" do
|
|
visit("/latest")
|
|
chat_page.open_from_header
|
|
chat_drawer_page.open_channel(channel)
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
|
expect(chat_drawer_page).to have_open_thread(thread)
|
|
end
|
|
|
|
it "navigates back to the channel when clicking back button from a thread" do
|
|
visit("/latest")
|
|
chat_page.open_from_header
|
|
chat_drawer_page.open_channel(channel)
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
|
expect(chat_drawer_page).to have_open_thread(thread)
|
|
|
|
chat_drawer_page.back
|
|
|
|
expect(chat_drawer_page).to have_open_channel(channel)
|
|
end
|
|
|
|
it "opens the side panel for a single thread from the indicator" do
|
|
chat_page.visit_channel(channel)
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
|
expect(side_panel).to have_open_thread(thread)
|
|
end
|
|
|
|
xit "shows the excerpt of the thread original message" do
|
|
chat_page.visit_channel(channel)
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
|
expect(thread_page).to have_header_content(thread.excerpt)
|
|
end
|
|
|
|
xit "shows the avatar and username of the original message user" do
|
|
chat_page.visit_channel(channel)
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
|
expect(thread_page.omu).to have_css(".chat-user-avatar img.avatar")
|
|
expect(thread_page.omu).to have_content(thread.original_message_user.username)
|
|
end
|
|
|
|
describe "sending a message" do
|
|
it "shows the message in the thread pane and links it to the correct channel" do
|
|
chat_page.visit_channel(channel)
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
|
expect(side_panel).to have_open_thread(thread)
|
|
thread_page.send_message("new thread message")
|
|
expect(thread_page).to have_message(thread_id: thread.id, text: "new thread message")
|
|
thread_message = thread.replies.last
|
|
expect(thread_message.chat_channel_id).to eq(channel.id)
|
|
expect(thread_message.thread.channel_id).to eq(channel.id)
|
|
end
|
|
|
|
it "does not echo the message in the channel pane" do
|
|
chat_page.visit_channel(channel)
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
|
expect(side_panel).to have_open_thread(thread)
|
|
thread_page.send_message("new thread message")
|
|
expect(thread_page).to have_message(thread_id: thread.id, text: "new thread message")
|
|
thread_message = thread.reload.replies.last
|
|
expect(channel_page).not_to have_css(channel_page.message_by_id_selector(thread_message.id))
|
|
end
|
|
|
|
it "handles updates from multiple users sending messages in the thread" do
|
|
using_session(:tab_1) do
|
|
sign_in(current_user)
|
|
chat_page.visit_channel(channel)
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
|
end
|
|
|
|
other_user = Fabricate(:user)
|
|
chat_system_user_bootstrap(user: other_user, channel: channel)
|
|
using_session(:tab_2) do
|
|
sign_in(other_user)
|
|
chat_page.visit_channel(channel)
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
|
end
|
|
|
|
using_session(:tab_2) do
|
|
expect(side_panel).to have_open_thread(thread)
|
|
thread_page.send_message("the other user message")
|
|
expect(thread_page).to have_message(thread_id: thread.id, text: "the other user message")
|
|
end
|
|
|
|
using_session(:tab_1) do |session|
|
|
expect(side_panel).to have_open_thread(thread)
|
|
expect(thread_page).to have_message(thread_id: thread.id, text: "the other user message")
|
|
thread_page.send_message("this is a test message")
|
|
expect(thread_page).to have_message(thread_id: thread.id, text: "this is a test message")
|
|
session.quit
|
|
end
|
|
|
|
using_session(:tab_2) do |session|
|
|
expect(thread_page).to have_message(thread_id: thread.id, text: "this is a test message")
|
|
session.quit
|
|
end
|
|
end
|
|
|
|
it "does not mark the channel unread if another user sends a message in the thread" do
|
|
other_user = Fabricate(:user)
|
|
chat_system_user_bootstrap(user: other_user, channel: channel)
|
|
Chat::MessageCreator.create(
|
|
chat_channel: channel,
|
|
user: other_user,
|
|
content: "Hello world!",
|
|
thread_id: thread.id,
|
|
)
|
|
sign_in(current_user)
|
|
chat_page.visit_channel(channel)
|
|
expect(page).not_to have_css(
|
|
".sidebar-section-link.channel-#{channel.id} .sidebar-section-link-suffix.unread",
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when using mobile" do
|
|
it "opens the side panel for a single thread using the indicator", mobile: true do
|
|
chat_page.visit_channel(channel)
|
|
channel_page.message_thread_indicator(thread.original_message).click
|
|
expect(side_panel).to have_open_thread(thread)
|
|
end
|
|
end
|
|
end
|
|
end
|