mirror of
https://github.com/discourse/discourse.git
synced 2024-11-26 00:33:44 +08:00
e62e93f83a
This will replace `enable_personal_messages` and `min_trust_to_send_messages`, this commit introduces the setting `personal_message_enabled_groups` and uses it in all places that `enable_personal_messages` and `min_trust_to_send_messages` currently apply. A migration is included to set `personal_message_enabled_groups` based on the following rules: * If `enable_personal_messages` was false, then set `personal_message_enabled_groups` to `3`, which is the staff auto group * If `min_trust_to_send_messages` is not default (1) and the above condition is false, then set the `personal_message_enabled_groups` setting to the appropriate auto group based on the trust level * Otherwise just set `personal_message_enabled_groups` to 11 which is the TL1 auto group After follow-up PRs to plugins using these old settings, we will be able to drop the old settings from core, in the meantime I've added DEPRECATED notices to their descriptions and added them to the deprecated site settings list. This commit also introduces a `_map` shortcut method definition for all `group_list` site settings, e.g. `SiteSetting.personal_message_enabled_groups` also has `SiteSetting.personal_message_enabled_groups_map` available, which automatically splits the setting by `|` and converts it into an array of integers.
48 lines
1.3 KiB
Ruby
48 lines
1.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
#mixin for all guardian methods dealing with group permissions
|
|
module GroupGuardian
|
|
|
|
# Creating Method
|
|
def can_create_group?
|
|
is_admin? ||
|
|
(
|
|
SiteSetting.moderators_manage_categories_and_groups &&
|
|
is_moderator?
|
|
)
|
|
end
|
|
|
|
# Edit authority for groups means membership changes only.
|
|
# Automatic groups are not represented in the GROUP_USERS
|
|
# table and thus do not allow membership changes.
|
|
def can_edit_group?(group)
|
|
!group.automatic &&
|
|
(can_admin_group?(group) || group.users.where('group_users.owner').include?(user))
|
|
end
|
|
|
|
def can_admin_group?(group)
|
|
is_admin? ||
|
|
(
|
|
SiteSetting.moderators_manage_categories_and_groups &&
|
|
is_moderator? &&
|
|
can_see?(group) &&
|
|
group.id != Group::AUTO_GROUPS[:admins]
|
|
)
|
|
end
|
|
|
|
def can_see_group_messages?(group)
|
|
return true if is_admin?
|
|
return true if is_moderator? && group.id == Group::AUTO_GROUPS[:moderators]
|
|
return false if user.blank?
|
|
|
|
# TODO (martin) Remove enable_personal_messages here once plugins have been changed.
|
|
(SiteSetting.enable_personal_messages ||
|
|
user.in_any_groups?(SiteSetting.personal_message_enabled_groups_map)) &&
|
|
group.users.include?(user)
|
|
end
|
|
|
|
def can_associate_groups?
|
|
is_admin? && AssociatedGroup.has_provider?
|
|
end
|
|
end
|