mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 23:06:57 +08:00
4ea21fa2d0
This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction
52 lines
1.4 KiB
Ruby
52 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe PermalinksController do
|
|
let(:topic) { Fabricate(:topic) }
|
|
let(:permalink) { Fabricate(:permalink, url: "deadroutee/topic/546") }
|
|
|
|
describe 'show' do
|
|
it "should redirect to a permalink's target_url with status 301" do
|
|
permalink.update!(topic_id: topic.id)
|
|
|
|
get "/#{permalink.url}"
|
|
|
|
expect(response).to redirect_to(topic.relative_url)
|
|
expect(response.status).to eq(301)
|
|
end
|
|
|
|
it "should work for subfolder installs too" do
|
|
permalink.update!(topic_id: topic.id)
|
|
GlobalSetting.stubs(:relative_url_root).returns('/forum')
|
|
Discourse.stubs(:base_uri).returns("/forum")
|
|
|
|
get "/#{permalink.url}"
|
|
|
|
expect(response).to redirect_to(topic.relative_url)
|
|
expect(response.status).to eq(301)
|
|
end
|
|
|
|
it "should apply normalizations" do
|
|
permalink.update!(external_url: '/topic/100')
|
|
SiteSetting.permalink_normalizations = "/(.*)\\?.*/\\1"
|
|
|
|
get "/#{permalink.url}", params: { test: "hello" }
|
|
|
|
expect(response).to redirect_to('/topic/100')
|
|
expect(response.status).to eq(301)
|
|
|
|
SiteSetting.permalink_normalizations = "/(.*)\\?.*/\\1X"
|
|
|
|
get "/#{permalink.url}", params: { test: "hello" }
|
|
|
|
expect(response.status).to eq(404)
|
|
end
|
|
|
|
it 'return 404 if permalink record does not exist' do
|
|
get '/not/a/valid/url'
|
|
expect(response.status).to eq(404)
|
|
end
|
|
end
|
|
end
|