mirror of
https://github.com/discourse/discourse.git
synced 2024-12-15 22:28:34 +08:00
e1e74abd4f
### UI Changes If `SiteSetting.enable_bookmarks_with_reminders` is enabled: * Clicking "Bookmark" on a topic will create a new Bookmark record instead of a post + user action * Clicking "Clear Bookmarks" on a topic will delete all the new Bookmark records on a topic * The topic bookmark buttons control the post bookmark flags correctly and vice-versa Disabled selecting the "reminder type" for bookmarks in the UI because the backend functionality is not done yet (of sending users notifications etc.) ### Other Changes * Added delete bookmark route (but no UI yet) * Added a rake task to sync the old PostAction bookmarks to the new Bookmark table, which can be run as many times as we want for a site (it will not create duplicates).
46 lines
1.4 KiB
Ruby
46 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
RSpec.describe "bookmarks tasks" do
|
|
let(:user1) { Fabricate(:user) }
|
|
let(:user2) { Fabricate(:user) }
|
|
let(:user3) { Fabricate(:user) }
|
|
let(:post1) { Fabricate(:post) }
|
|
let(:post2) { Fabricate(:post) }
|
|
let(:post3) { Fabricate(:post) }
|
|
|
|
before do
|
|
Rake::Task.clear
|
|
Discourse::Application.load_tasks
|
|
|
|
create_post_actions_and_existing_bookmarks
|
|
end
|
|
|
|
it "migrates all PostActions" do
|
|
Rake::Task['bookmarks:sync_to_table'].invoke
|
|
|
|
expect(Bookmark.all.count).to eq(3)
|
|
end
|
|
|
|
it "does not create bookmarks that already exist in the bookmarks table for a user" do
|
|
Fabricate(:bookmark, user: user1, post: post1)
|
|
|
|
Rake::Task['bookmarks:sync_to_table'].invoke
|
|
|
|
expect(Bookmark.all.count).to eq(3)
|
|
expect(Bookmark.where(post: post1, user: user1).count).to eq(1)
|
|
end
|
|
|
|
it "respects the sync_limit if provided and stops creating bookmarks at the limit (so this can be run progrssively" do
|
|
Rake::Task['bookmarks:sync_to_table'].invoke(1)
|
|
expect(Bookmark.all.count).to eq(1)
|
|
end
|
|
|
|
def create_post_actions_and_existing_bookmarks
|
|
Fabricate(:post_action, user: user1, post: post1, post_action_type_id: PostActionType.types[:bookmark])
|
|
Fabricate(:post_action, user: user2, post: post2, post_action_type_id: PostActionType.types[:bookmark])
|
|
Fabricate(:post_action, user: user3, post: post3, post_action_type_id: PostActionType.types[:bookmark])
|
|
end
|
|
end
|