mirror of
https://github.com/discourse/discourse.git
synced 2024-12-16 09:05:47 +08:00
7988a5f14b
This could be catastrophic in production; a missing upload would mean every request to the site would raise an error.
54 lines
1.4 KiB
Ruby
54 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe EmojiSerializer do
|
|
fab!(:custom_emoji) do
|
|
CustomEmoji.create!(name: 'trout', upload: Fabricate(:upload))
|
|
end
|
|
|
|
describe '#url' do
|
|
fab!(:emoji) do
|
|
Emoji.load_custom.first
|
|
end
|
|
subject { described_class.new(emoji, root: false) }
|
|
|
|
it 'returns a valid URL' do
|
|
expect(subject.url).to start_with('/uploads/')
|
|
end
|
|
|
|
it 'works with a CDN' do
|
|
set_cdn_url('https://cdn.com')
|
|
expect(subject.url).to start_with('https://cdn.com')
|
|
end
|
|
end
|
|
|
|
context "missing uploads" do
|
|
before do
|
|
custom_emoji.upload.destroy!
|
|
end
|
|
|
|
it "doesn't raise an error with a missing upload and a CDN" do
|
|
emoji = Emoji.load_custom.first
|
|
set_cdn_url('https://cdn.com')
|
|
result = described_class.new(Emoji.load_custom.first, root: false).as_json
|
|
expect(result[:url]).to be_blank
|
|
end
|
|
|
|
it "doesn't raise an error with a missing upload and an s3 CDN" do
|
|
emoji = Emoji.load_custom.first
|
|
|
|
SiteSetting.enable_s3_uploads = true
|
|
SiteSetting.s3_upload_bucket = "s3bucket"
|
|
SiteSetting.s3_access_key_id = "s3_access_key_id"
|
|
SiteSetting.s3_secret_access_key = "s3_secret_access_key"
|
|
SiteSetting.s3_cdn_url = "https://example.com"
|
|
result = described_class.new(Emoji.load_custom.first, root: false).as_json
|
|
|
|
expect(result[:url]).to be_blank
|
|
end
|
|
|
|
end
|
|
|
|
end
|