mirror of
https://github.com/discourse/discourse.git
synced 2024-11-29 15:55:08 +08:00
e82e255531
### Why?
Before, all flags were static. Therefore, they were stored in class variables and serialized by SiteSerializer. Recently, we added an option for admins to add their own flags or disable existing flags. Therefore, the class variable had to be dropped because it was unsafe for a multisite environment. However, it started causing performance problems.
### Solution
When a new Flag system is used, instead of using PostActionType, we can serialize Flags and use fragment cache for performance reasons.
At the same time, we are still supporting deprecated `replace_flags` API call. When it is used, we fall back to the old solution and the admin cannot add custom flags. In a couple of months, we will be able to drop that API function and clean that code properly. However, because it may still be used, redis cache was introduced to improve performance.
To test backward compatibility you can add this code to any plugin
```ruby
replace_flags do |flag_settings|
flag_settings.add(
4,
:inappropriate,
topic_type: true,
notify_type: true,
auto_action_type: true,
)
flag_settings.add(1001, :trolling, topic_type: true, notify_type: true, auto_action_type: true)
end
```
58 lines
2.0 KiB
Ruby
58 lines
2.0 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe FlagSerializer do
|
|
let(:flag) { Flag.find_by(name: "illegal") }
|
|
|
|
context "when system flag" do
|
|
it "returns translated name" do
|
|
serialized = described_class.new(flag, used_flag_ids: []).as_json
|
|
expect(serialized[:flag][:name]).to eq(I18n.t("post_action_types.illegal.title"))
|
|
end
|
|
|
|
it "returns translated description" do
|
|
serialized = described_class.new(flag, used_flag_ids: []).as_json
|
|
expect(serialized[:flag][:description]).to eq(I18n.t("post_action_types.illegal.description"))
|
|
end
|
|
end
|
|
|
|
context "when custom flag" do
|
|
fab!(:flag) { Fabricate(:flag, name: "custom title", description: "custom description") }
|
|
|
|
it "returns translated name" do
|
|
serialized = described_class.new(flag, used_flag_ids: []).as_json
|
|
expect(serialized[:flag][:name]).to eq("custom title")
|
|
end
|
|
|
|
it "returns translated description" do
|
|
serialized = described_class.new(flag, used_flag_ids: []).as_json
|
|
expect(serialized[:flag][:description]).to eq("custom description")
|
|
end
|
|
end
|
|
|
|
it "returns is_flag true for flags" do
|
|
serialized = described_class.new(flag, used_flag_ids: []).as_json
|
|
expect(serialized[:flag][:is_flag]).to be true
|
|
end
|
|
|
|
it "returns is_flag false for like" do
|
|
flag = Flag.unscoped.find_by(name: "like")
|
|
serialized = described_class.new(flag, used_flag_ids: []).as_json
|
|
expect(serialized[:flag][:is_flag]).to be false
|
|
end
|
|
|
|
it "returns is_used false when not used" do
|
|
serialized = described_class.new(flag, used_flag_ids: []).as_json
|
|
expect(serialized[:flag][:is_used]).to be false
|
|
end
|
|
|
|
it "returns is_used true when used" do
|
|
serialized = described_class.new(flag, used_flag_ids: [flag.id]).as_json
|
|
expect(serialized[:flag][:is_used]).to be true
|
|
end
|
|
|
|
it "returns applies_to" do
|
|
serialized = described_class.new(flag, used_flag_ids: []).as_json
|
|
expect(serialized[:flag][:applies_to]).to eq(%w[Post Topic Chat::Message])
|
|
end
|
|
end
|