mirror of
https://github.com/discourse/discourse.git
synced 2024-11-28 11:25:45 +08:00
30990006a9
This reduces chances of errors where consumers of strings mutate inputs and reduces memory usage of the app. Test suite passes now, but there may be some stuff left, so we will run a few sites on a branch prior to merging
47 lines
1.3 KiB
Ruby
47 lines
1.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
module JsonError
|
|
|
|
def create_errors_json(obj, opts = nil)
|
|
opts ||= {}
|
|
|
|
errors = create_errors_array obj
|
|
errors[:error_type] = opts[:type] if opts[:type]
|
|
errors[:extras] = opts[:extras] if opts[:extras]
|
|
errors
|
|
end
|
|
|
|
private
|
|
|
|
def create_errors_array(obj)
|
|
# If we're passed a string, assume that is the error message
|
|
return { errors: [obj] } if obj.is_a?(String)
|
|
|
|
# If it's an AR exception target the record
|
|
obj = obj.record if obj.is_a?(ActiveRecord::RecordInvalid)
|
|
|
|
# If it looks like an activerecord object, extract its messages
|
|
return { errors: obj.errors.full_messages } if obj.respond_to?(:errors) && obj.errors.present?
|
|
|
|
# If we're passed an array, it's an array of error messages
|
|
return { errors: obj.map(&:to_s) } if obj.is_a?(Array) && obj.present?
|
|
|
|
if obj.is_a?(Exception)
|
|
message = obj.cause.message.presence || obj.cause.class.name if obj.cause
|
|
message = obj.message.presence || obj.class.name if message.blank?
|
|
return { errors: [message] } if message.present?
|
|
end
|
|
|
|
# Log a warning (unless obj is nil)
|
|
Rails.logger.warn("create_errors_json called with unrecognized type: #{obj.inspect}") if obj
|
|
|
|
# default to a generic error
|
|
JsonError.generic_error
|
|
end
|
|
|
|
def self.generic_error
|
|
{ errors: [I18n.t('js.generic_error')] }
|
|
end
|
|
|
|
end
|