mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 21:10:17 +08:00
586454bcf1
* DEV: Add a dedicated Admin::StaffController base controller The current parent(Admin:AdminController) for all admin-related controllers uses a filter that allows only staff(admin, moderator) users. This refactor makes Admin::AdminController filter for only admins as the name suggests and introduces a base controller dedicated for staff-related endpoints. * DEV: Set staff-only controllers parent to Admin::StaffController Refactor staff-only controllers to inherit newly introduced Admin::StaffController abstract controller. This conveys the purpose of the parent controller better unlike the previously used parent controller.
48 lines
1.6 KiB
Ruby
48 lines
1.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe Admin::ScreenedIpAddressesController do
|
|
|
|
it "is a subclass of StaffController" do
|
|
expect(Admin::ScreenedIpAddressesController < Admin::StaffController).to eq(true)
|
|
end
|
|
|
|
fab!(:admin) { Fabricate(:admin) }
|
|
|
|
before do
|
|
sign_in(admin)
|
|
end
|
|
|
|
describe '#index' do
|
|
it 'filters screened ip addresses' do
|
|
Fabricate(:screened_ip_address, ip_address: "1.2.3.4")
|
|
Fabricate(:screened_ip_address, ip_address: "1.2.3.5")
|
|
Fabricate(:screened_ip_address, ip_address: "1.2.3.6")
|
|
Fabricate(:screened_ip_address, ip_address: "4.5.6.7")
|
|
Fabricate(:screened_ip_address, ip_address: "5.0.0.0/8")
|
|
|
|
get "/admin/logs/screened_ip_addresses.json", params: { filter: "1.2.*" }
|
|
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body.map { |record| record["ip_address"] })
|
|
.to contain_exactly("1.2.3.4", "1.2.3.5", "1.2.3.6")
|
|
|
|
get "/admin/logs/screened_ip_addresses.json", params: { filter: "4.5.6.7" }
|
|
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body.map { |record| record["ip_address"] })
|
|
.to contain_exactly("4.5.6.7")
|
|
|
|
get "/admin/logs/screened_ip_addresses.json", params: { filter: "5.0.0.1" }
|
|
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body.map { |record| record["ip_address"] })
|
|
.to contain_exactly("5.0.0.0/8")
|
|
|
|
get "/admin/logs/screened_ip_addresses.json", params: { filter: "6.0.0.1" }
|
|
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body).to be_blank
|
|
end
|
|
end
|
|
end
|