mirror of
https://github.com/discourse/discourse.git
synced 2024-11-24 05:50:14 +08:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
55 lines
1.2 KiB
Ruby
55 lines
1.2 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe DirectoryItemsController do
|
|
|
|
it "requires a `period` param" do
|
|
expect{ xhr :get, :index }.to raise_error
|
|
end
|
|
|
|
it "requires a proper `period` param" do
|
|
xhr :get, :index, period: 'eviltrout'
|
|
expect(response).not_to be_success
|
|
end
|
|
|
|
|
|
context "without data" do
|
|
|
|
context "and a logged in user" do
|
|
let!(:user) { log_in }
|
|
|
|
it "succeeds" do
|
|
xhr :get, :index, period: 'all'
|
|
expect(response).to be_success
|
|
json = ::JSON.parse(response.body)
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
|
|
context "with data" do
|
|
before do
|
|
Fabricate(:user)
|
|
DirectoryItem.refresh!
|
|
end
|
|
|
|
it "succeeds with a valid value" do
|
|
xhr :get, :index, period: 'all'
|
|
expect(response).to be_success
|
|
json = ::JSON.parse(response.body)
|
|
|
|
expect(json).to be_present
|
|
expect(json['directory_items']).to be_present
|
|
expect(json['total_rows_directory_items']).to be_present
|
|
expect(json['load_more_directory_items']).to be_present
|
|
end
|
|
|
|
it "fails when the directory is disabled" do
|
|
SiteSetting.enable_user_directory = false
|
|
|
|
xhr :get, :index, period: 'all'
|
|
expect(response).not_to be_success
|
|
end
|
|
end
|
|
end
|