mirror of
https://github.com/discourse/discourse.git
synced 2024-11-24 05:34:28 +08:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
47 lines
1.7 KiB
Ruby
47 lines
1.7 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe UserAvatarsController do
|
|
|
|
context 'show' do
|
|
it 'handles non local content correctly' do
|
|
SiteSetting.avatar_sizes = "100|49"
|
|
SiteSetting.enable_s3_uploads = true
|
|
SiteSetting.s3_access_key_id = "XXX"
|
|
SiteSetting.s3_secret_access_key = "XXX"
|
|
SiteSetting.s3_upload_bucket = "test"
|
|
SiteSetting.s3_cdn_url = "http://cdn.com"
|
|
|
|
GlobalSetting.expects(:cdn_url).returns("http://awesome.com/boom")
|
|
|
|
|
|
upload = Fabricate(:upload, url: "//test.s3.amazonaws.com/something")
|
|
Fabricate(:optimized_image,
|
|
sha1: SecureRandom.hex << "A"*8,
|
|
upload: upload,
|
|
width: 98,
|
|
height: 98,
|
|
url: "//test.s3.amazonaws.com/something/else")
|
|
|
|
user = Fabricate(:user, uploaded_avatar_id: upload.id)
|
|
|
|
get :show, size: 97, username: user.username, version: upload.id, hostname: 'default'
|
|
|
|
# 98 is closest which is 49 * 2 for retina
|
|
expect(response).to redirect_to("http://awesome.com/boom/user_avatar/default/#{user.username_lower}/98/#{upload.id}_#{OptimizedImage::VERSION}.png")
|
|
|
|
get :show, size: 98, username: user.username, version: upload.id, hostname: 'default'
|
|
expect(response).to redirect_to("http://cdn.com/something/else")
|
|
end
|
|
|
|
it 'serves image even if size missing and its in local mode' do
|
|
SiteSetting.avatar_sizes = "50"
|
|
|
|
upload = Fabricate(:upload)
|
|
user = Fabricate(:user, uploaded_avatar_id: upload.id)
|
|
|
|
get :show, size: 51, username: user.username, version: upload.id, hostname: 'default'
|
|
expect(response).to be_success
|
|
end
|
|
end
|
|
end
|