Jarek Radosz 694b5f108b

DEV: Fix various rubocop lints (#24749) ...

These (21 + 3 from previous PRs) are soon to be enabled in rubocop-discourse:

Capybara/VisibilityMatcher
Lint/DeprecatedOpenSSLConstant
Lint/DisjunctiveAssignmentInConstructor
Lint/EmptyConditionalBody
Lint/EmptyEnsure
Lint/LiteralInInterpolation
Lint/NonLocalExitFromIterator
Lint/ParenthesesAsGroupedExpression
Lint/RedundantCopDisableDirective
Lint/RedundantRequireStatement
Lint/RedundantSafeNavigation
Lint/RedundantStringCoercion
Lint/RedundantWithIndex
Lint/RedundantWithObject
Lint/SafeNavigationChain
Lint/SafeNavigationConsistency
Lint/SelfAssignment
Lint/UnreachableCode
Lint/UselessMethodDefinition
Lint/Void

Previous PRs:
Lint/ShadowedArgument
Lint/DuplicateMethods
Lint/BooleanSymbol
RSpec/SpecFilePathSuffix

2023-12-06 23:25:00 +01:00

..

composer

DEV: Convert approve_unless_trust_level to groups (#24357)

2023-11-21 11:31:42 -07:00

emojis

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

groups

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

helpers

DEV: make sure we don't load all data into memory when exporting chat messages (#22276)

2023-07-12 18:52:18 +04:00

page_objects

DEV: Fix Lint/DuplicateMethods (#24746)

2023-12-06 13:18:34 +01:00

user_page

FIX: Regression when enforced 2FA is enabled (#24415)

2023-11-16 11:52:12 -05:00

admin_customize_form_templates_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

admin_customize_themes_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

admin_dashboard_new_features_spec.rb

DEV: Remove unnecessary fab! block (#24496)

2023-11-21 17:03:17 -06:00

admin_plugins_list_spec.rb

FIX: Use plugin category name for plugin list (#24477)

2023-11-23 08:40:55 +10:00

admin_revamp_sidebar_navigation_spec.rb

DEV: Fix various typos (#24461)

2023-11-20 16:49:49 +01:00

admin_site_setting_search_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

admin_user_badges_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

bookmarks_spec.rb

DEV: Delete redundant bookmark test (#24680)

2023-12-04 12:27:35 +10:00

category_edit_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

category_topics_spec.rb

DEV: Remove unnecessary js: true options from specs (#24463)

2023-11-20 17:22:14 +01:00

change_owner_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

composer_uploads_spec.rb

DEV: Remove unnecessary js: true options from specs (#24463)

2023-11-20 17:22:14 +01:00

create_account_spec.rb

DEV: Add a basic account creation system spec (#24179)

2023-10-31 14:53:24 +01:00

csv_exports_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

custom_sidebar_sections_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

discovery_breadcrumb_navigation_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

discovery_list_spec.rb

FIX: Sorting toggles on topic list (#24465)

2023-11-20 17:45:13 +00:00

dismissing_new_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

editing_sidebar_categories_navigation_spec.rb

DEV: Unskip flaky editing sidebar nav menu categories on mobile test (#24412)

2023-11-17 06:37:20 +08:00

editing_sidebar_community_section_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

editing_sidebar_tags_navigation_spec.rb

DEV: Fix various rubocop lints (#24749)

2023-12-06 23:25:00 +01:00

ember_deprecation_spec.rb

DEV: Fix various spec linting issues (#24672)

2023-12-04 13:45:19 +01:00

fast_edit_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

filtering_topics_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

flagging_post_spec.rb

DEV: Fix flagging post flaky (#24619)

2023-11-29 08:16:52 +10:00

grant_badge_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

group_card_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

hashtag_autocomplete_spec.rb

DEV: Convert approve_unless_trust_level to groups (#24357)

2023-11-21 11:31:42 -07:00

keyboard_shortcuts_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

network_disconnected_spec.rb

DEV: Fix flaky network-based upload spec (#23286)

2023-08-28 12:59:22 +08:00

new_topic_list_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

post_small_action_spec.rb

DEV: Remove flaky spec (#24641)

2023-11-30 11:06:27 +08:00

reviewables_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

s3_secure_uploads_spec.rb

DEV: Re-enable minio specs by pre-installing minio binary before test run (#24050)

2023-10-24 12:43:14 +10:00

s3_uploads_spec.rb

DEV: Fix various rubocop lints (#24749)

2023-12-06 23:25:00 +01:00

scroll_manager_service_spec.rb

DEV: Remove unused pageobject from scroll_manager_service_spec (#23501)

2023-09-11 10:28:25 +01:00

search_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

table_builder_spec.rb

FIX: Flaky table builder spec (#24700)

2023-12-04 12:14:07 -08:00

tag_notification_level_spec.rb

DEV: Remove superfluous js: true metadata (#21960)

2023-06-07 09:26:58 +08:00

tag_synonyms_spec.rb

DEV: Fix random typos (#22078)

2023-06-13 22:02:21 +02:00

tags_intersection_spec.rb

FIX: Transitioning to tag-intersection route (#23931)

2023-10-13 16:23:04 +01:00

theme_qunit_spec.rb

DEV: Stop building test assets in production under Embroider (#23388)

2023-09-11 09:12:37 +01:00

topic_list_focus_spec.rb

DEV: Introduce history-store service (#24486)

2023-11-22 14:25:52 +00:00

topic_page_spec.rb

DEV: Update custom array implementations for Ember 5 compatibility (#24435)

2023-11-20 13:26:46 +00:00

user_activation_spec.rb

FIX: Pass email correctly when resending activation email (#23741)

2023-10-02 13:00:29 +01:00

user_selector_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

viewing_category_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

viewing_group_members_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

viewing_navigation_menu_preferences_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

viewing_sidebar_as_anonymous_user_spec.rb

UX: support links in tag descriptions (#22994)

2023-08-16 11:43:54 -04:00

viewing_sidebar_mobile_spec.rb

DEV: Fix various rubocop lints (#24749)

2023-12-06 23:25:00 +01:00

viewing_sidebar_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

viewing_user_menu_spec.rb

DEV: Allow fab! without block (#24314)

2023-11-09 16:47:59 -06:00

viewing_user_private_messages_spec.rb

DEV: Fix ember/no-private-routing-service (#24009)

2023-11-29 12:26:52 +01:00