discourse/lib/system_message.rb
Bianca Nenciu 10ee92656c
FIX: Send TL2 promotion message to correct user (#21978)
Usually, when a user is promoted to TL2 two messages are sent. The
first one is a system message 'tl2_promotion_message' which triggers a
'system_message_sent' Discourse event.

When the event is fired and if Discourse Narrative Bot is enabled, then
a second message is sent to the recipient of the first message. The
recipients was determined by looking at the list of users that can
access that topic and pick the last one. This method does not work if
'site_contact_group_name' site setting is set because it adds the group
in the list of recipients.

A solution to this problem would have been to select the last user in
the list of 'topic_allowed_users', but an even better solution is to
pass the name of the recipients when the 'system_message_sent'
Discourse event is fired.
2023-06-07 22:51:24 +03:00

108 lines
2.8 KiB
Ruby

# frozen_string_literal: true
# Handle sending a message to a user from the system.
class SystemMessage
def self.create(recipient, type, params = {})
self.new(recipient).create(type, params)
end
def self.create_from_system_user(recipient, type, params = {})
params = params.merge(from_system: true)
self.new(recipient).create(type, params)
end
def initialize(recipient)
@recipient = recipient
end
def create(type, params = {})
method_params = params.dup
from_system = params.delete(:from_system)
target_group_names = params.delete(:target_group_names)
params = defaults.merge(params)
title =
params[:message_title] ||
I18n.with_locale(@recipient.effective_locale) do
I18n.t("system_messages.#{type}.subject_template", params)
end
raw =
params[:message_raw] ||
I18n.with_locale(@recipient.effective_locale) do
I18n.t("system_messages.#{type}.text_body_template", params)
end
if from_system
user = Discourse.system_user
else
user = Discourse.site_contact_user
target_group_names =
(
if Group.exists?(name: SiteSetting.site_contact_group_name)
SiteSetting.site_contact_group_name
else
nil
end
)
end
post_creator_args = [
user,
title: title,
raw: raw,
archetype: Archetype.private_message,
target_usernames: @recipient.username,
target_group_names: target_group_names,
subtype: TopicSubtype.system_message,
skip_validations: true,
post_alert_options: params[:post_alert_options],
]
DiscourseEvent.trigger(
:before_system_message_sent,
message_type: type,
recipient: @recipient,
post_creator_args: post_creator_args,
params: method_params,
)
creator = PostCreator.new(*post_creator_args)
post = I18n.with_locale(@recipient.effective_locale) { creator.create }
DiscourseEvent.trigger(
:system_message_sent,
post: post,
message_type: type,
recipient: @recipient,
)
raise StandardError, creator.errors.full_messages.join(" ") if creator.errors.present?
unless from_system
UserArchivedMessage.create!(user: Discourse.site_contact_user, topic: post.topic)
end
post
end
def defaults
{
site_name: SiteSetting.title,
username: @recipient.username,
name: @recipient.name,
name_or_username: @recipient.name.presence || @recipient.username,
user_preferences_url: "#{@recipient.full_url}/preferences",
new_user_tips:
I18n.with_locale(@recipient.effective_locale) do
I18n.t("system_messages.usage_tips.text_body_template", base_url: Discourse.base_url)
end,
site_password: "",
base_url: Discourse.base_url,
}
end
end