mirror of
https://github.com/discourse/discourse.git
synced 2024-12-16 07:04:20 +08:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
23 lines
752 B
Ruby
23 lines
752 B
Ruby
require 'rails_helper'
|
|
require_dependency 'jobs/regular/automatic_group_membership'
|
|
|
|
describe Jobs::AutomaticGroupMembership do
|
|
|
|
it "raises an error when the group id is missing" do
|
|
expect { Jobs::AutomaticGroupMembership.new.execute({}) }.to raise_error(Discourse::InvalidParameters)
|
|
end
|
|
|
|
it "updates the membership" do
|
|
user1 = Fabricate(:user, email: "foo@wat.com")
|
|
user2 = Fabricate(:user, email: "foo@bar.com")
|
|
group = Fabricate(:group, automatic_membership_email_domains: "wat.com", automatic_membership_retroactive: true)
|
|
|
|
Jobs::AutomaticGroupMembership.new.execute(group_id: group.id)
|
|
|
|
group.reload
|
|
expect(group.users.include?(user1)).to eq(true)
|
|
expect(group.users.include?(user2)).to eq(false)
|
|
end
|
|
|
|
end
|