mirror of
https://github.com/discourse/discourse.git
synced 2024-12-16 06:48:14 +08:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
56 lines
1.9 KiB
Ruby
56 lines
1.9 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe Jobs::PendingUsersReminder do
|
|
|
|
context 'must_approve_users is true' do
|
|
before do
|
|
SiteSetting.must_approve_users = true
|
|
Jobs::PendingUsersReminder.any_instance.stubs(:previous_newest_username).returns(nil)
|
|
end
|
|
|
|
it "doesn't send a message to anyone when there are no pending users" do
|
|
PostCreator.expects(:create).never
|
|
Jobs::PendingUsersReminder.new.execute({})
|
|
end
|
|
|
|
context "there are pending users" do
|
|
before do
|
|
Fabricate(:moderator, approved: true, approved_by_id: -1, approved_at: 1.week.ago)
|
|
Group.refresh_automatic_group!(:moderators)
|
|
end
|
|
|
|
it "sends a message if user was created more than pending_users_reminder_delay hours ago" do
|
|
SiteSetting.pending_users_reminder_delay = 8
|
|
Fabricate(:user, created_at: 9.hours.ago)
|
|
PostCreator.expects(:create).once
|
|
Jobs::PendingUsersReminder.new.execute({})
|
|
end
|
|
|
|
it "doesn't send a message if user was created less than pending_users_reminder_delay hours ago" do
|
|
SiteSetting.pending_users_reminder_delay = 8
|
|
Fabricate(:user, created_at: 2.hours.ago)
|
|
PostCreator.expects(:create).never
|
|
Jobs::PendingUsersReminder.new.execute({})
|
|
end
|
|
|
|
it "doesn't send a message if pending_users_reminder_delay is -1" do
|
|
SiteSetting.pending_users_reminder_delay = -1
|
|
PostCreator.expects(:create).never
|
|
Jobs::PendingUsersReminder.new.execute({})
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'must_approve_users is false' do
|
|
before do
|
|
SiteSetting.stubs(:must_approve_users).returns(false)
|
|
end
|
|
|
|
it "doesn't send a message to anyone when there are pending users" do
|
|
AdminUserIndexQuery.any_instance.stubs(:find_users_query).returns(stub_everything(count: 1))
|
|
PostCreator.expects(:create).never
|
|
Jobs::PendingUsersReminder.new.execute({})
|
|
end
|
|
end
|
|
end
|