mirror of
https://github.com/discourse/discourse.git
synced 2024-12-05 22:04:02 +08:00
72ac675e4e
Just like we have for consolidating likes this adds similar functionality for consolidating links.
116 lines
3.9 KiB
Ruby
116 lines
3.9 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe Notifications::ConsolidationPlanner do
|
|
subject(:planner) { described_class.new }
|
|
|
|
describe "#consolidate_or_save!" do
|
|
let(:threshold) { 1 }
|
|
fab!(:user)
|
|
let(:like_user) { "user1" }
|
|
let(:link_user) { "user2" }
|
|
|
|
before { SiteSetting.notification_consolidation_threshold = threshold }
|
|
|
|
it "does nothing when it hasn't passed the consolidation threshold yet for likes" do
|
|
notification = build_notification(:liked, { display_username: like_user })
|
|
|
|
saved_like = planner.consolidate_or_save!(notification)
|
|
|
|
expect(saved_like.id).to be_present
|
|
expect(saved_like.notification_type).to eq(Notification.types[:liked])
|
|
end
|
|
|
|
it "does nothing when it hasn't passed the consolidation threshold yet for links" do
|
|
notification = build_notification(:linked, { display_username: link_user })
|
|
|
|
saved_link = planner.consolidate_or_save!(notification)
|
|
|
|
expect(saved_link.id).to be_present
|
|
expect(saved_link.notification_type).to eq(Notification.types[:linked])
|
|
end
|
|
|
|
it "consolidates multiple like notifications into a new one" do
|
|
first_notification =
|
|
Fabricate(
|
|
:notification,
|
|
user: user,
|
|
notification_type: Notification.types[:liked],
|
|
data: { display_username: like_user }.to_json,
|
|
)
|
|
notification = build_notification(:liked, { display_username: like_user })
|
|
|
|
consolidated_like = planner.consolidate_or_save!(notification)
|
|
|
|
expect(consolidated_like.id).not_to eq(first_notification.id)
|
|
expect(consolidated_like.notification_type).to eq(Notification.types[:liked_consolidated])
|
|
data = JSON.parse(consolidated_like.data)
|
|
expect(data["count"]).to eq(threshold + 1)
|
|
end
|
|
|
|
it "consolidates multiple link notifications into a new one" do
|
|
first_notification =
|
|
Fabricate(
|
|
:notification,
|
|
user: user,
|
|
notification_type: Notification.types[:linked],
|
|
data: { display_username: link_user }.to_json,
|
|
)
|
|
notification = build_notification(:linked, { display_username: link_user })
|
|
|
|
consolidated_link = planner.consolidate_or_save!(notification)
|
|
|
|
expect(consolidated_link.id).not_to eq(first_notification.id)
|
|
expect(consolidated_link.notification_type).to eq(Notification.types[:linked_consolidated])
|
|
data = JSON.parse(consolidated_link.data)
|
|
expect(data["count"]).to eq(threshold + 1)
|
|
end
|
|
|
|
it "updates the like notification if we already consolidated it" do
|
|
count = 5
|
|
Fabricate(
|
|
:notification,
|
|
user: user,
|
|
notification_type: Notification.types[:liked_consolidated],
|
|
data: { count: count, display_username: like_user }.to_json,
|
|
)
|
|
notification = build_notification(:liked, { display_username: like_user })
|
|
|
|
updated = planner.consolidate_or_save!(notification)
|
|
|
|
expect { notification.reload }.to raise_error(ActiveRecord::RecordNotFound)
|
|
data = JSON.parse(updated.data)
|
|
expect(data["count"]).to eq(count + 1)
|
|
end
|
|
|
|
it "updates the link notification if we already consolidated it" do
|
|
count = 5
|
|
Fabricate(
|
|
:notification,
|
|
user: user,
|
|
notification_type: Notification.types[:linked_consolidated],
|
|
data: { count: count, display_username: link_user }.to_json,
|
|
)
|
|
notification = build_notification(:linked, { display_username: link_user })
|
|
|
|
updated = planner.consolidate_or_save!(notification)
|
|
|
|
expect { notification.reload }.to raise_error(ActiveRecord::RecordNotFound)
|
|
data = JSON.parse(updated.data)
|
|
expect(data["count"]).to eq(count + 1)
|
|
end
|
|
end
|
|
|
|
def build_notification(type_sym, data)
|
|
Fabricate.build(
|
|
:notification,
|
|
user: user,
|
|
notification_type: Notification.types[type_sym],
|
|
data: data.to_json,
|
|
)
|
|
end
|
|
|
|
def plan_for(notification)
|
|
planner.plan_for(notification)
|
|
end
|
|
end
|