mirror of
https://github.com/discourse/discourse.git
synced 2024-12-02 07:48:12 +08:00
6e9fbb5bab
Why this change?
We noticed that running `LOAD_PLUGINS=1 rspec --seed=38855 plugins/chat/spec/system/chat_new_message_spec.rb` locally
results in the system tests randomly failing. When we inspected the
request logs closely, we noticed that a `/presence/get` request from a
previous rspec example was being processed when a new rspec example is
already being run. We know it was from the previous rspec example
because inspecting the auth token showed the request using the auth
token of a user from the previous example. However, when a request using
an auth token from a previous example is used it ends up logging out the
same user on the server side because the user id in the cookie is the same
due to the use of `fab!`.
I did some research and there is apparently no way to wait until all
inflight requests by the browser has completed through capybara or
selenium. Therefore, we will add an identifier by attaching a cookie to all non-xhr requests so that
xhr requests which are triggered subsequently will contain the cookie in the request.
In the `BlockRequestsMiddleware` middleware, we will then reject any
requests when the value of the identifier in the cookie does not match the current rspec's example
location.
To see the problem locally, change `Auth::DefaultCurrentUserProvider.find_v1_auth_cookie` to the following:
```
def self.find_v1_auth_cookie(env)
return env[DECRYPTED_AUTH_COOKIE] if env.key?(DECRYPTED_AUTH_COOKIE)
env[DECRYPTED_AUTH_COOKIE] = begin
request = ActionDispatch::Request.new(env)
cookie = request.cookies[TOKEN_COOKIE]
# don't even initialize a cookie jar if we don't have a cookie at all
if cookie&.valid_encoding? && cookie.present?
puts "#{env["REQUEST_PATH"]} #{request.cookie_jar.encrypted[TOKEN_COOKIE]&.with_indifferent_access}"
request.cookie_jar.encrypted[TOKEN_COOKIE]&.with_indifferent_access
end
end
end
```
After which run the following command: `LOAD_PLUGINS=1 rspec --format documentation --seed=38855 plugins/chat/spec/system/chat_new_message_spec.rb`
It takes a few tries but the last spec should fail and you should see something like this:
```
assets/chunk.c16f6ba8b6824baa47ac.d41d8cd9.js {"token"=>"37d995a4b65395d3b343ec70fff915b4", "user_id"=>3382, "username"=>"bruce0", "trust_level"=>1, "issued_at"=>1708591735}
/assets/chunk.050148142e1d2dc992dd.d41d8cd9.js {"token"=>"37d995a4b65395d3b343ec70fff915b4", "user_id"=>3382, "username"=>"bruce0", "trust_level"=>1, "issued_at"=>1708591735}
/chat/api/channels/527/messages {"token"=>"37d995a4b65395d3b343ec70fff915b4", "user_id"=>3382, "username"=>"bruce0", "trust_level"=>1, "issued_at"=>1708591735}
/uploads/default/test_0/optimized/1X/_129430568242d1b7f853bb13ebea28b3f6af4e7_2_512x512.png {"token"=>"37d995a4b65395d3b343ec70fff915b4", "user_id"=>3382, "username"=>"bruce0", "trust_level"=>1, "issued_at"=>1708591735}
redirects to existing chat channel
redirects to chat channel if recipients param is missing (PENDING: Temporarily skipped with xit)
with multiple users
/favicon.ico {"token"=>"9a75c114c4d3401509a23d240f0a46d4", "user_id"=>3382, "username"=>"bruce0", "trust_level"=>1, "issued_at"=>1708591736}
/chat/new-message {"token"=>"9a75c114c4d3401509a23d240f0a46d4", "user_id"=>3382, "username"=>"bruce0", "trust_level"=>1, "issued_at"=>1708591736}
/presence/get {"token"=>"37d995a4b65395d3b343ec70fff915b4", "user_id"=>3382, "username"=>"bruce0", "trust_level"=>1, "issued_at"=>1708591735}
```
Note how the `/presence/get` request is using a token from the previous example.
Co-authored-by: David Taylor <david@taylorhq.com>
|
||
|---|---|---|
| .. | ||
| admin | ||
| chat/composer | ||
| chat_message | ||
| list_channels | ||
| page_objects | ||
| reply_to_message | ||
| select_message | ||
| shortcuts | ||
| thread_list | ||
| thread_tracking | ||
| user_menu_notifications | ||
| user_status | ||
| admin_sidebar_navigation_spec.rb | ||
| anonymous_spec.rb | ||
| archive_channel_spec.rb | ||
| bookmark_message_spec.rb | ||
| browse_page_spec.rb | ||
| channel_members_page_spec.rb | ||
| channel_message_upload_spec.rb | ||
| channel_settings_page_spec.rb | ||
| channel_thread_message_echoing_spec.rb | ||
| chat_channel_spec.rb | ||
| chat_composer_draft_spec.rb | ||
| chat_composer_spec.rb | ||
| chat_footer_spec.rb | ||
| chat_message_creator_spec.rb | ||
| chat_message_onebox_spec.rb | ||
| chat_new_message_spec.rb | ||
| chat_summarization_spec.rb | ||
| closed_channel_spec.rb | ||
| create_channel_spec.rb | ||
| dates_separators_spec.rb | ||
| deleted_channel_spec.rb | ||
| deleted_message_spec.rb | ||
| document_title_spec.rb | ||
| drawer_spec.rb | ||
| edited_message_spec.rb | ||
| flag_message_spec.rb | ||
| hashtag_autocomplete_spec.rb | ||
| invite_users_to_channel_spec.rb | ||
| kick_user_from_channel_spec.rb | ||
| mention_warnings_spec.rb | ||
| message_errors_spec.rb | ||
| message_notifications_mobile_spec.rb | ||
| message_notifications_with_sidebar_spec.rb | ||
| message_thread_indicator_spec.rb | ||
| message_user_info_spec.rb | ||
| move_message_to_channel_spec.rb | ||
| navigation_spec.rb | ||
| react_to_message_spec.rb | ||
| read_only_spec.rb | ||
| removing_channel_spec.rb | ||
| restore_message_spec.rb | ||
| reviewables_spec.rb | ||
| send_message_spec.rb | ||
| separate_sidebar_mode_spec.rb | ||
| sidebar_navigation_menu_spec.rb | ||
| sidebars_spec.rb | ||
| silenced_user_spec.rb | ||
| single_thread_spec.rb | ||
| thread_preview_spec.rb | ||
| transcript_spec.rb | ||
| unfollow_dm_channel_spec.rb | ||
| update_last_read_spec.rb | ||
| uploads_spec.rb | ||
| user_card_spec.rb | ||
| user_chat_preferences_spec.rb | ||
| user_threads_spec.rb | ||
| visit_channel_spec.rb | ||