mirror of
https://github.com/discourse/discourse.git
synced 2024-12-01 11:33:44 +08:00
4ea21fa2d0
This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction
65 lines
2.4 KiB
Ruby
65 lines
2.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "rails_helper"
|
|
require "spam_handler"
|
|
|
|
describe SpamHandler do
|
|
|
|
describe "#should_prevent_registration_from_ip?" do
|
|
|
|
it "works" do
|
|
# max_new_accounts_per_registration_ip = 0 disables the check
|
|
SiteSetting.max_new_accounts_per_registration_ip = 0
|
|
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[1])
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
|
|
# only prevents registration for TL0
|
|
SiteSetting.max_new_accounts_per_registration_ip = 2
|
|
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[1])
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[1])
|
|
expect { Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0]) }.to raise_error(ActiveRecord::RecordInvalid)
|
|
end
|
|
|
|
it "doesn't limit registrations since there is a TL2+ user with that IP" do
|
|
# setup
|
|
SiteSetting.max_new_accounts_per_registration_ip = 0
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[2])
|
|
|
|
# should not limit registration
|
|
SiteSetting.max_new_accounts_per_registration_ip = 1
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
end
|
|
|
|
it "doesn't limit registrations since there is a staff member with that IP" do
|
|
# setup
|
|
SiteSetting.max_new_accounts_per_registration_ip = 0
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
Fabricate(:moderator, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
|
|
Group.refresh_automatic_groups!(:staff)
|
|
|
|
# should not limit registration
|
|
SiteSetting.max_new_accounts_per_registration_ip = 1
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
end
|
|
|
|
it "doesn't limit registrations when the IP is whitelisted" do
|
|
# setup
|
|
SiteSetting.max_new_accounts_per_registration_ip = 0
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
ScreenedIpAddress.stubs(:is_whitelisted?).with("42.42.42.42").returns(true)
|
|
|
|
# should not limit registration
|
|
SiteSetting.max_new_accounts_per_registration_ip = 1
|
|
Fabricate(:user, ip_address: "42.42.42.42", trust_level: TrustLevel[0])
|
|
end
|
|
|
|
end
|
|
|
|
end
|