mirror of
https://github.com/discourse/discourse.git
synced 2024-12-16 15:53:46 +08:00
bb0c2813ac
FIX: keep the "uploading..." indicator until the server replies via the MessageBus FIX: text was disapearing when uploading an avatar PERF: always use a region for S3 (defaults to 'us-east-1') FEATURE: ApplyCDN middleware when using S3 FIX: use the same pattern to store files on S3 and locally PERF: keep a local cache of uploads when generating thumbnails FEATURE: migrate_to_s3 rake task
133 lines
3.4 KiB
Ruby
133 lines
3.4 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe UploadsController do
|
|
|
|
context '.create' do
|
|
|
|
it 'requires you to be logged in' do
|
|
expect { xhr :post, :create }.to raise_error(Discourse::NotLoggedIn)
|
|
end
|
|
|
|
context 'logged in' do
|
|
|
|
before { @user = log_in :user }
|
|
|
|
let(:logo) do
|
|
ActionDispatch::Http::UploadedFile.new({
|
|
filename: 'logo.png',
|
|
tempfile: file_from_fixtures("logo.png")
|
|
})
|
|
end
|
|
|
|
let(:text_file) do
|
|
ActionDispatch::Http::UploadedFile.new({
|
|
filename: 'LICENSE.TXT',
|
|
tempfile: File.new("#{Rails.root}/LICENSE.txt")
|
|
})
|
|
end
|
|
|
|
it 'is successful with an image' do
|
|
Jobs.expects(:enqueue).with(:create_thumbnails, anything)
|
|
|
|
message = MessageBus.track_publish do
|
|
xhr :post, :create, file: logo, type: "avatar"
|
|
end.first
|
|
|
|
expect(response.status).to eq 200
|
|
|
|
expect(message.channel).to eq("/uploads/avatar")
|
|
expect(message.data).to be
|
|
end
|
|
|
|
it 'is successful with an attachment' do
|
|
SiteSetting.stubs(:authorized_extensions).returns("*")
|
|
|
|
Jobs.expects(:enqueue).never
|
|
|
|
message = MessageBus.track_publish do
|
|
xhr :post, :create, file: text_file, type: "composer"
|
|
end.first
|
|
|
|
expect(response.status).to eq 200
|
|
expect(message.channel).to eq("/uploads/composer")
|
|
expect(message.data).to be
|
|
end
|
|
|
|
it 'correctly sets retain_hours for admins' do
|
|
Jobs.expects(:enqueue).with(:create_thumbnails, anything)
|
|
|
|
log_in :admin
|
|
|
|
message = MessageBus.track_publish do
|
|
xhr :post, :create, file: logo, retain_hours: 100, type: "profile_background"
|
|
end.first
|
|
|
|
id = message.data["id"]
|
|
expect(Upload.find(id).retain_hours).to eq(100)
|
|
end
|
|
|
|
it 'properly returns errors' do
|
|
SiteSetting.stubs(:max_attachment_size_kb).returns(1)
|
|
|
|
Jobs.expects(:enqueue).never
|
|
|
|
message = MessageBus.track_publish do
|
|
xhr :post, :create, file: text_file, type: "avatar"
|
|
end.first
|
|
|
|
expect(response.status).to eq 200
|
|
expect(message.data["errors"]).to be
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
context '.show' do
|
|
|
|
let(:site) { "default" }
|
|
let(:sha) { Digest::SHA1.hexdigest("discourse") }
|
|
|
|
it "returns 404 when using external storage" do
|
|
store = stub(internal?: false)
|
|
Discourse.stubs(:store).returns(store)
|
|
Upload.expects(:find_by).never
|
|
|
|
get :show, site: site, sha: sha, extension: "pdf"
|
|
expect(response.response_code).to eq(404)
|
|
end
|
|
|
|
it "returns 404 when the upload doens't exist" do
|
|
Upload.stubs(:find_by).returns(nil)
|
|
|
|
get :show, site: site, sha: sha, extension: "pdf"
|
|
expect(response.response_code).to eq(404)
|
|
end
|
|
|
|
it 'uses send_file' do
|
|
upload = build(:upload)
|
|
Upload.expects(:find_by).with(sha1: sha).returns(upload)
|
|
|
|
controller.stubs(:render)
|
|
controller.expects(:send_file)
|
|
|
|
get :show, site: site, sha: sha, extension: "zip"
|
|
end
|
|
|
|
context "prevent anons from downloading files" do
|
|
|
|
before { SiteSetting.stubs(:prevent_anons_from_downloading_files).returns(true) }
|
|
|
|
it "returns 404 when an anonymous user tries to download a file" do
|
|
Upload.expects(:find_by).never
|
|
|
|
get :show, site: site, sha: sha, extension: "pdf"
|
|
expect(response.response_code).to eq(404)
|
|
end
|
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|