mirror of
https://github.com/discourse/discourse.git
synced 2024-12-05 08:03:40 +08:00
7ef482a292
* FIX: Use pluralized string
* REFACTOR: Fix misuse of pluralized string
* REFACTOR: Fix misuse of pluralized string
* DEV: Remove linting of `one` key in MessageFormat string, it doesn't work
* REFACTOR: Fix misuse of pluralized string
This also ensures that the URL works on subfolder and shows the site setting link only for admins instead of staff. The string is quite complicated, so the best option was to switch to MessageFormat.
* REFACTOR: Fix misuse of pluralized string
* FIX: Use pluralized string
This also ensures that the URL works on subfolder and shows the site setting link only for admins instead of staff.
* REFACTOR: Correctly pluralize reaction tooltips in chat
This also ensures that maximum 5 usernames are shown and fixes the number of "others" which was off by 1 if the current user reacted on a message.
* REFACTOR: Use translatable string as comma separator
* DEV: Add comment to translation to clarify the meaning of `%{identifier}`
* REFACTOR: Use translatable comma separator and use explicit interpolation keys
* REFACTOR: Don't interpolate lowercase channel status
* REFACTOR: Fix misuse of pluralized string
* REFACTOR: Don't interpolate channel status
* REFACTOR: Use %{count} interpolation key
* REFACTOR: Fix misuse of pluralized string
* REFACTOR: Correctly pluralize DM chat channel titles
71 lines
1.9 KiB
Ruby
71 lines
1.9 KiB
Ruby
# frozen_string_literal: true
|
||
|
||
RSpec.describe "JIT messages", type: :system, js: true do
|
||
fab!(:channel_1) { Fabricate(:chat_channel) }
|
||
fab!(:current_user) { Fabricate(:user) }
|
||
fab!(:other_user) { Fabricate(:user) }
|
||
|
||
let(:chat) { PageObjects::Pages::Chat.new }
|
||
let(:channel) { PageObjects::Pages::ChatChannel.new }
|
||
|
||
before do
|
||
channel_1.add(current_user)
|
||
chat_system_bootstrap
|
||
sign_in(current_user)
|
||
end
|
||
|
||
context "when mentioning a user not on the channel" do
|
||
it "displays a mention warning" do
|
||
Jobs.run_immediately!
|
||
|
||
chat.visit_channel(channel_1)
|
||
channel.send_message("hi @#{other_user.username}")
|
||
|
||
expect(page).to have_content(
|
||
I18n.t("js.chat.mention_warning.without_membership", username: other_user.username),
|
||
wait: 5,
|
||
)
|
||
end
|
||
end
|
||
|
||
context "when mentioning a user who can’t access the channel" do
|
||
fab!(:group_1) { Fabricate(:group) }
|
||
fab!(:private_channel_1) { Fabricate(:private_category_channel, group: group_1) }
|
||
|
||
before do
|
||
group_1.add(current_user)
|
||
private_channel_1.add(current_user)
|
||
end
|
||
|
||
it "displays a mention warning" do
|
||
Jobs.run_immediately!
|
||
|
||
chat.visit_channel(private_channel_1)
|
||
channel.send_message("hi @#{other_user.username}")
|
||
|
||
expect(page).to have_content(
|
||
I18n.t("js.chat.mention_warning.cannot_see", username: other_user.username),
|
||
wait: 5,
|
||
)
|
||
end
|
||
end
|
||
|
||
context "when mention a group" do
|
||
context "when group can't be mentioned" do
|
||
fab!(:group_1) { Fabricate(:group, mentionable_level: Group::ALIAS_LEVELS[:nobody]) }
|
||
|
||
it "displays a mention warning" do
|
||
Jobs.run_immediately!
|
||
|
||
chat.visit_channel(channel_1)
|
||
channel.send_message("hi @#{group_1.name}")
|
||
|
||
expect(page).to have_content(
|
||
I18n.t("js.chat.mention_warning.group_mentions_disabled", group_name: group_1.name),
|
||
wait: 5,
|
||
)
|
||
end
|
||
end
|
||
end
|
||
end
|