mirror of
https://github.com/discourse/discourse.git
synced 2024-12-15 23:56:43 +08:00
4ea21fa2d0
This change both speeds up specs (less strings to allocate) and helps catch cases where methods in Discourse are mutating inputs. Overall we will be migrating everything to use #frozen_string_literal: true it will take a while, but this is the first and safest move in this direction
94 lines
3.0 KiB
Ruby
94 lines
3.0 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe SimilarTopicsController do
|
|
context 'similar_to' do
|
|
let(:title) { 'this title is long enough to search for' }
|
|
let(:raw) { 'this body is long enough to search for' }
|
|
|
|
let(:topic) { Fabricate(:topic, title: title) }
|
|
let(:post) { Fabricate(:post, topic: topic, raw: raw, post_number: 1) }
|
|
|
|
let(:private_post) { Fabricate(:post, raw: raw, topic: private_topic, post_number: 1) }
|
|
let(:private_topic) do
|
|
Fabricate(:topic, title: "#{title} 02", category: Fabricate(:private_category, group: Group[:staff]))
|
|
end
|
|
|
|
def reindex_posts
|
|
SearchIndexer.enable
|
|
Jobs::ReindexSearch.new.rebuild_problem_posts
|
|
end
|
|
|
|
it "requires a title param" do
|
|
get "/topics/similar_to.json", params: { raw: raw }
|
|
expect(response.status).to eq(400)
|
|
end
|
|
|
|
it "returns no results if the title length is below the minimum" do
|
|
SiteSetting.minimum_topics_similar = 0
|
|
SiteSetting.min_title_similar_length = 100
|
|
post
|
|
reindex_posts
|
|
|
|
get "/topics/similar_to.json", params: { title: title, raw: raw }
|
|
expect(response.status).to eq(200)
|
|
json = ::JSON.parse(response.body)
|
|
expect(json["similar_topics"].size).to eq(0)
|
|
end
|
|
|
|
describe "minimum_topics_similar" do
|
|
before do
|
|
SiteSetting.minimum_topics_similar = 30
|
|
end
|
|
|
|
describe "With enough topics" do
|
|
it "deletes to Topic.similar_to if there are more topics than `minimum_topics_similar`" do
|
|
Topic.stubs(:count).returns(50)
|
|
post
|
|
reindex_posts
|
|
|
|
get "/topics/similar_to.json", params: { title: title, raw: raw }
|
|
|
|
expect(response.status).to eq(200)
|
|
similar_topics = ::JSON.parse(response.body)["similar_topics"]
|
|
expect(similar_topics.size).to eq(1)
|
|
expect(similar_topics.first["topic_id"]).to eq(topic.id)
|
|
end
|
|
|
|
describe "with a logged in user" do
|
|
before do
|
|
private_post; post
|
|
reindex_posts
|
|
Topic.stubs(:count).returns(50)
|
|
sign_in(Fabricate(:moderator))
|
|
Group.refresh_automatic_groups!
|
|
end
|
|
|
|
it "passes a user through if logged in" do
|
|
get "/topics/similar_to.json", params: { title: title, raw: raw }
|
|
|
|
expect(response.status).to eq(200)
|
|
similar_topics = ::JSON.parse(response.body)["similar_topics"].map { |topic| topic["topic_id"] }
|
|
expect(similar_topics.size).to eq(2)
|
|
expect(similar_topics).to include(topic.id)
|
|
expect(similar_topics).to include(private_topic.id)
|
|
end
|
|
end
|
|
end
|
|
|
|
it "does not call Topic.similar_to if there are fewer topics than `minimum_topics_similar`" do
|
|
Topic.stubs(:count).returns(10)
|
|
post
|
|
reindex_posts
|
|
|
|
get "/topics/similar_to.json", params: { title: title, raw: raw }
|
|
|
|
expect(response.status).to eq(200)
|
|
json = ::JSON.parse(response.body)
|
|
expect(json["similar_topics"].size).to eq(0)
|
|
end
|
|
end
|
|
end
|
|
end
|