mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 14:08:40 +08:00
62c6ee0de7
This commit fixes an SQL syntax error in `UserBadge.update_featured_ranks!` when the `user_ids` param is an empty array `[]`. This was causing the `Jobs::BackfillBadge` job to raise the following exceptions: ``` Job exception: ERROR: syntax error at or near ")" LINE 6: AND user_id IN () ``` This commit fixes the same error in `UserState.update_distinct_badge_count` as well Follow-up to 3e4eac0fed05daedcdea50d6275e143469d55eda
34 lines
935 B
Ruby
34 lines
935 B
Ruby
# frozen_string_literal: true
|
|
|
|
module Jobs
|
|
class BackfillBadge < ::Jobs::Base
|
|
sidekiq_options queue: "low"
|
|
|
|
def execute(args)
|
|
return unless SiteSetting.enable_badges
|
|
|
|
badge = Badge.enabled.find_by(id: args[:badge_id])
|
|
return unless badge
|
|
|
|
revoked_user_ids = Set.new
|
|
granted_user_ids = Set.new
|
|
|
|
BadgeGranter.backfill(
|
|
badge,
|
|
revoked_callback: ->(user_ids) { revoked_user_ids.merge(user_ids) },
|
|
granted_callback: ->(user_ids) { granted_user_ids.merge(user_ids) },
|
|
)
|
|
|
|
affected_user_ids = (revoked_user_ids | granted_user_ids).to_a
|
|
revoked_user_ids = revoked_user_ids.to_a
|
|
|
|
BadgeGranter.revoke_ungranted_titles!(revoked_user_ids) if revoked_user_ids.present?
|
|
|
|
if affected_user_ids.present?
|
|
UserBadge.ensure_consistency!(affected_user_ids)
|
|
UserStat.update_distinct_badge_count(affected_user_ids)
|
|
end
|
|
end
|
|
end
|
|
end
|