mirror of
https://github.com/discourse/discourse.git
synced 2024-11-24 15:33:43 +08:00
7b907ec50a
Why this change? The `Table Builder when editing a table when cancelling table creation should close the modal if there are no changes made` system test in `spec/system/table_builder_spec.rb` was flaky. It turns out that when the modal is opened, we have to load some JS/CSS files. While that is happening, the modal is actually not functional and clicking stuff in the footer can actually result in an error. In this case, the `interceptCloseModal` calls the private `_hasChanges` function which then calls `this.spreadsheet.getHeaders()`. When stuff is still loading, `this.spreadsheet` has not been set. As a result we get the following error: ``` Cannot read properties of null (reading 'getHeaders') ``` What does this change do? Why stuff is loading, we will now hide the footer in the modal. |
||
---|---|---|
.. | ||
admin | ||
bootstrap-json | ||
confirm-new-email | ||
deprecation-silencer | ||
dialog-holder | ||
discourse | ||
discourse-common | ||
discourse-hbr | ||
discourse-i18n | ||
discourse-markdown-it | ||
discourse-plugins | ||
discourse-widget-hbs | ||
docs | ||
ember-addons | ||
ember-cli-progress-ci | ||
ember-production-deprecations | ||
float-kit | ||
locales | ||
patches | ||
pretty-text | ||
select-kit | ||
theme-transpiler | ||
truth-helpers | ||
.licensee.json | ||
.npmrc | ||
handlebars-shim.js | ||
package-ember3.json | ||
package-ember5.json | ||
package.json | ||
polyfills.js | ||
run-patch-package | ||
service-worker.js.erb | ||
yarn-ember3.lock | ||
yarn-ember5.lock | ||
yarn.lock |