mirror of
https://github.com/discourse/discourse.git
synced 2024-11-24 08:32:26 +08:00
ffcd2e9faf
Themes often cache `nil` values in a DistributedCache. This bug meant that we were re-calculating some values on every request, AND triggering message-bus publishing on every request. This fix should provide a significant performance improvement for busy sites.
32 lines
767 B
Ruby
32 lines
767 B
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe "DistributedCache extensions" do
|
|
let(:cache) { DistributedCache.new('mytest') }
|
|
|
|
it "can defer_get_set" do
|
|
messages = MessageBus.track_publish("/distributed_hash") do
|
|
cache.defer_get_set("key") { "value" }
|
|
end
|
|
expect(messages.size).to eq(1)
|
|
expect(cache["key"]).to eq("value")
|
|
end
|
|
|
|
it "works correctly for nil values" do
|
|
block_called_counter = 0
|
|
messages = MessageBus.track_publish("/distributed_hash") do
|
|
2.times do
|
|
cache.defer_get_set("key") do
|
|
block_called_counter += 1
|
|
nil
|
|
end
|
|
end
|
|
end
|
|
|
|
expect(block_called_counter).to eq(1)
|
|
expect(messages.size).to eq(1)
|
|
expect(cache["key"]).to eq(nil)
|
|
end
|
|
end
|