mirror of
https://github.com/discourse/discourse.git
synced 2024-12-02 03:33:43 +08:00
7d9a823a55
Why is this change required? The flaky system test was due to the fact that we had to poll for the user preferences interface page to reload after saving. However, this turns out to be a bug on the user perferences interface page because the page should only reload if the user has selected a new theme that is different from the site's default but we were reloading the page for users that did not have any user theme selected. Therefore there was an unnecessary reload happening when saving other fields on the user preferences interface page.
32 lines
1.1 KiB
Ruby
32 lines
1.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe "User preferences for Interface", type: :system, js: true do
|
|
fab!(:user) { Fabricate(:user) }
|
|
let(:user_preferences_page) { PageObjects::Pages::UserPreferences.new }
|
|
let(:user_preferences_interface_page) { PageObjects::Pages::UserPreferencesInterface.new }
|
|
|
|
before { sign_in(user) }
|
|
|
|
describe "Bookmarks" do
|
|
it "changes the bookmark after notification preference" do
|
|
user_preferences_page.visit(user).click_interface_tab
|
|
|
|
# preselects the default user_option.bookmark_auto_delete_preference value of 3 (clear_reminder)
|
|
expect(user_preferences_interface_page).to have_bookmark_after_notification_mode(
|
|
Bookmark.auto_delete_preferences[:clear_reminder],
|
|
)
|
|
|
|
user_preferences_interface_page.select_bookmark_after_notification_mode(
|
|
Bookmark.auto_delete_preferences[:when_reminder_sent],
|
|
).save_changes
|
|
|
|
expect(
|
|
UserOption.exists?(
|
|
user_id: user.id,
|
|
bookmark_auto_delete_preference: Bookmark.auto_delete_preferences[:when_reminder_sent],
|
|
),
|
|
).to eq(true)
|
|
end
|
|
end
|
|
end
|