mirror of
https://github.com/discourse/discourse.git
synced 2025-02-21 01:02:38 +08:00

Why this change? Instead of dealing with a generic object for `Theme#settings`, we want to always be dealing with `ThemeSettings` objects.` Previously, we converted the generic objects to `ThemeSettings` objects in the theme's adapter `afterFindAll` function. This is not correct because updating or saving the theme individual reverted the `Theme#settings` back to an array of generic object. To fix this problem, the proper way with our REST models is to overwrite the static `munge` method and create `ThemeSettings` instances there.