discourse/spec
jbrw 70050a8ba3
FIX: should_alter_quality should respect png_to_jpg_quality (#12055)
`convert_to_jpeg!` is only called if `convert_png_to_jpeg?` and/or `should_alter_quality?` is true.

`convert_png_to_jpeg?` can be disabled by setting `SiteSetting.png_to_jpg_quality` to 100.

However, `should_alter_quality?` could be true if `SiteSetting.recompress_original_jpg_quality` was lower than the quality of the uploaded file, regardless of file type.

This commits changes `should_alter_quality?` so that uploaded png files will use the `SiteSetting.png_to_jpg_quality` value, rather than ``SiteSetting.recompress_original_jpg_quality` value.
2021-02-12 13:37:35 -05:00
..
components FIX: Don't add a slug to constructed quote urls (#12052) 2021-02-11 12:21:13 -06:00
fabricators FEATURE: New way to dismiss new topics (#11927) 2021-02-04 11:27:34 +11:00
fixtures FIX: should_alter_quality should respect png_to_jpg_quality (#12055) 2021-02-12 13:37:35 -05:00
helpers A11Y: sets the html lang to user's locale when possible (#12007) 2021-02-10 16:12:09 +01:00
import_export FEATURE: Rake task to export groups (#9450) 2020-04-17 14:59:54 -07:00
initializers FIX: We need to skip users with associated reviewables when auto-approving (#9080) 2020-03-02 14:33:52 -05:00
integration DEV: Change Topic Timer from enqueue_at scheduled jobs to incrementally executed jobs (#11698) 2021-01-19 13:30:58 +10:00
integrity DEV: Add i18n fallback specs (#11669) 2021-01-08 17:47:28 +01:00
jobs Revert "FEATURE: Ability to dismiss all new topics (#12018)" (#12058) 2021-02-12 08:50:25 +11:00
lib FIX: should_alter_quality should respect png_to_jpg_quality (#12055) 2021-02-12 13:37:35 -05:00
mailers FEATURE: Add English (UK) as locale (#11768) 2021-01-20 21:32:22 +01:00
models FIX: Validate duration minutes values for topic timer (#12040) 2021-02-12 09:05:14 +10:00
multisite DEV: Prevents rate limits for new feature checks on multisite (#12053) 2021-02-12 08:52:59 -05:00
requests Revert "FEATURE: Ability to dismiss all new topics (#12018)" (#12058) 2021-02-12 08:50:25 +11:00
script/import_scripts DEV: add specs for Vanilla import script improvements (#11712) 2021-01-16 19:35:19 +05:30
serializers FEATURE: Rename 'Discourse SSO' to DiscourseConnect (#11978) 2021-02-08 10:04:33 +00:00
services Revert "FEATURE: Ability to dismiss all new topics (#12018)" (#12058) 2021-02-12 08:50:25 +11:00
support DEV: prevents heisentest in processor spec (#12066) 2021-02-12 14:53:36 +01:00
tasks FIX: remove migrate_from_s3 task that silently corrupts data (#11703) 2021-01-17 22:33:29 +01:00
views/omniauth_callbacks FEATURE: Use full page redirection for all external auth methods (#8092) 2019-10-08 12:10:43 +01:00
rails_helper.rb DEV: Update DB.after_commit to be compatible with 'real' transactions (#11294) 2020-12-08 11:03:31 +11:00
swagger_helper.rb api docs example (#11997) 2021-02-08 10:09:44 -07:00