mirror of
https://github.com/discourse/discourse.git
synced 2024-11-27 22:36:18 +08:00
e0703dbbc7
Don't break the optimized image workflow when there was an issue downloading a copy of the original image
139 lines
3.7 KiB
Ruby
139 lines
3.7 KiB
Ruby
require "digest/sha1"
|
|
|
|
class OptimizedImage < ActiveRecord::Base
|
|
belongs_to :upload
|
|
|
|
def self.create_for(upload, width, height, opts={})
|
|
return unless width > 0 && height > 0
|
|
|
|
# do we already have that thumbnail?
|
|
thumbnail = find_by(upload_id: upload.id, width: width, height: height)
|
|
|
|
# make sure the previous thumbnail has not failed
|
|
if thumbnail && thumbnail.url.blank?
|
|
thumbnail.destroy
|
|
thumbnail = nil
|
|
end
|
|
|
|
# return the previous thumbnail if any
|
|
return thumbnail unless thumbnail.nil?
|
|
|
|
# create the thumbnail otherwise
|
|
external_copy = Discourse.store.download(upload) if Discourse.store.external?
|
|
original_path = if Discourse.store.external?
|
|
external_copy.try(:path)
|
|
else
|
|
Discourse.store.path_for(upload)
|
|
end
|
|
|
|
if original_path.blank?
|
|
Rails.logger.error("Could not find file in the store located at url: #{upload.url}")
|
|
else
|
|
# create a temp file with the same extension as the original
|
|
extension = File.extname(original_path)
|
|
temp_file = Tempfile.new(["discourse-thumbnail", extension])
|
|
temp_path = temp_file.path
|
|
|
|
if extension =~ /\.svg$/i
|
|
FileUtils.cp(original_path, temp_path)
|
|
resized = true
|
|
else
|
|
resized = resize(original_path, temp_path, width, height, opts[:allow_animation])
|
|
end
|
|
|
|
if resized
|
|
thumbnail = OptimizedImage.create!(
|
|
upload_id: upload.id,
|
|
sha1: Digest::SHA1.file(temp_path).hexdigest,
|
|
extension: extension,
|
|
width: width,
|
|
height: height,
|
|
url: "",
|
|
)
|
|
# store the optimized image and update its url
|
|
url = Discourse.store.store_optimized_image(temp_file, thumbnail)
|
|
if url.present?
|
|
thumbnail.url = url
|
|
thumbnail.save
|
|
else
|
|
Rails.logger.error("Failed to store avatar #{size} for #{upload.url} from #{source}")
|
|
end
|
|
else
|
|
Rails.logger.error("Failed to create optimized image #{width}x#{height} for #{upload.url}")
|
|
end
|
|
|
|
# close && remove temp file
|
|
temp_file.close!
|
|
end
|
|
|
|
# make sure we remove the cached copy from external stores
|
|
if Discourse.store.external?
|
|
external_copy.try(:close!) rescue nil
|
|
end
|
|
|
|
thumbnail
|
|
end
|
|
|
|
def destroy
|
|
OptimizedImage.transaction do
|
|
Discourse.store.remove_optimized_image(self)
|
|
super
|
|
end
|
|
end
|
|
|
|
def self.resize(from, to, width, height, allow_animation=false)
|
|
# NOTE: ORDER is important!
|
|
instructions = if allow_animation && from =~ /\.GIF$/i
|
|
%W{
|
|
#{from}
|
|
-coalesce
|
|
-gravity center
|
|
-thumbnail #{width}x#{height}^
|
|
-extent #{width}x#{height}
|
|
-layers optimize
|
|
#{to}
|
|
}.join(" ")
|
|
else
|
|
%W{
|
|
#{from}[0]
|
|
-background transparent
|
|
-gravity center
|
|
-thumbnail #{width}x#{height}^
|
|
-extent #{width}x#{height}
|
|
-interpolate bicubic
|
|
-unsharp 2x0.5+0.7+0
|
|
-quality 98
|
|
#{to}
|
|
}.join(" ")
|
|
end
|
|
|
|
`convert #{instructions}`
|
|
|
|
if $?.exitstatus == 0
|
|
ImageOptim.new.optimize_image(to) rescue nil
|
|
true
|
|
else
|
|
false
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
# == Schema Information
|
|
#
|
|
# Table name: optimized_images
|
|
#
|
|
# id :integer not null, primary key
|
|
# sha1 :string(40) not null
|
|
# extension :string(10) not null
|
|
# width :integer not null
|
|
# height :integer not null
|
|
# upload_id :integer not null
|
|
# url :string(255) not null
|
|
#
|
|
# Indexes
|
|
#
|
|
# index_optimized_images_on_upload_id (upload_id)
|
|
# index_optimized_images_on_upload_id_and_width_and_height (upload_id,width,height) UNIQUE
|
|
#
|