mirror of
https://github.com/discourse/discourse.git
synced 2024-12-12 03:23:43 +08:00
8958b4f76a
Our custom implementation of `getOwner` includes a fallback which returns an owner, even if the passed object does not have one set. This is confusing and creates a false sense of security. Generally if the fallback is used, it means there is a problem with the patterns being used.
This commit renames our custom implementation to `getOwnerWithFallback`, while maintaining the old `getOwner` export with a deprecation notice. Core code is updated to use the official `@ember/application` implementation, or the new `getOwnerWithFallback` function.
This commit updates all core uses of `{ getOwner } from discourse-common/lib/get-owner` to use `getOwnerWithFallback`. Future commits will work through and convert many of these to use the official `@ember/application` implementation
105 lines
2.7 KiB
JavaScript
105 lines
2.7 KiB
JavaScript
import Component from "@glimmer/component";
|
|
import { modifier } from "ember-modifier";
|
|
import { tracked } from "@glimmer/tracking";
|
|
import { inject as service } from "@ember/service";
|
|
import DButton from "discourse/components/d-button";
|
|
import DFloatBody from "float-kit/components/d-float-body";
|
|
import concatClass from "discourse/helpers/concat-class";
|
|
import { getOwner } from "@ember/application";
|
|
import DMenuInstance from "float-kit/lib/d-menu-instance";
|
|
|
|
export default class DMenu extends Component {
|
|
<template>
|
|
{{! template-lint-disable modifier-name-case }}
|
|
<DButton
|
|
class={{concatClass
|
|
"fk-d-menu__trigger"
|
|
(if this.menuInstance.expanded "-expanded")
|
|
}}
|
|
id={{this.menuInstance.id}}
|
|
data-identifier={{this.options.identifier}}
|
|
data-trigger
|
|
@icon={{@icon}}
|
|
@translatedAriaLabel={{@ariaLabel}}
|
|
@translatedLabel={{@label}}
|
|
@translatedTitle={{@title}}
|
|
@disabled={{@disabled}}
|
|
aria-expanded={{if this.menuInstance.expanded "true" "false"}}
|
|
{{this.registerTrigger}}
|
|
...attributes
|
|
>
|
|
{{#if (has-block "trigger")}}
|
|
{{yield this.componentArgs to="trigger"}}
|
|
{{/if}}
|
|
</DButton>
|
|
|
|
{{#if this.menuInstance.expanded}}
|
|
<DFloatBody
|
|
@instance={{this.menuInstance}}
|
|
@trapTab={{this.options.trapTab}}
|
|
@mainClass="fk-d-menu"
|
|
@innerClass="fk-d-menu__inner-content"
|
|
@role="dialog"
|
|
@inline={{this.options.inline}}
|
|
@portalOutletElement={{this.menu.portalOutletElement}}
|
|
>
|
|
{{#if (has-block)}}
|
|
{{yield this.componentArgs}}
|
|
{{else if (has-block "content")}}
|
|
{{yield this.componentArgs to="content"}}
|
|
{{else if this.options.component}}
|
|
<this.options.component
|
|
@data={{this.options.data}}
|
|
@close={{this.menuInstance.close}}
|
|
/>
|
|
{{else if this.options.content}}
|
|
{{this.options.content}}
|
|
{{/if}}
|
|
</DFloatBody>
|
|
{{/if}}
|
|
</template>
|
|
|
|
@service menu;
|
|
|
|
@tracked menuInstance = null;
|
|
|
|
registerTrigger = modifier((element) => {
|
|
const options = {
|
|
...this.args,
|
|
...{
|
|
autoUpdate: true,
|
|
listeners: true,
|
|
beforeTrigger: () => {
|
|
this.menu.close();
|
|
},
|
|
},
|
|
};
|
|
const instance = new DMenuInstance(getOwner(this), element, options);
|
|
|
|
this.menuInstance = instance;
|
|
|
|
return () => {
|
|
instance.destroy();
|
|
|
|
if (this.isDestroying) {
|
|
this.menuInstance = null;
|
|
}
|
|
};
|
|
});
|
|
|
|
get menuId() {
|
|
return `d-menu-${this.menuInstance.id}`;
|
|
}
|
|
|
|
get options() {
|
|
return this.menuInstance?.options ?? {};
|
|
}
|
|
|
|
get componentArgs() {
|
|
return {
|
|
close: this.menu.close,
|
|
data: this.options.data,
|
|
};
|
|
}
|
|
}
|