mirror of
https://github.com/discourse/discourse.git
synced 2024-12-13 14:33:55 +08:00
8edd2b38cb
A simplified version of the logic used in the function before my fix is as follow: ```ruby result = [] things = [0,1,2,3] max_values = 2 every = (things.size.to_f / max_values).ceil things.each_with_index do |t, index| next unless (t % every) === 0 result << t end p result # [0, 2] # 3 doesn’t get included ``` The problem is that if you get unlucky two times you won't get last tuple(s) and might get a very erroneous date. Double unlucky: - last tuple index % computed every !== 0 and you don't get the last tuple - the last tuple is related to a post with a very different date than the previous tuples (on year difference in our case)
33 lines
704 B
Ruby
33 lines
704 B
Ruby
# frozen_string_literal: true
|
|
|
|
module TimelineLookup
|
|
|
|
# Given an array of tuples containing (id, days_ago), return at most `max_values` worth of a
|
|
# lookup table to help the front end timeline display dates associated with posts
|
|
def self.build(tuples, max_values = 300)
|
|
result = []
|
|
|
|
every = (tuples.size.to_f / max_values).ceil
|
|
|
|
last_days_ago = -1
|
|
tuples.each_with_index do |t, idx|
|
|
return result unless t.is_a?(Array)
|
|
|
|
if idx != tuples.size - 1
|
|
next unless (idx % every) === 0
|
|
end
|
|
|
|
days_ago = t[1]
|
|
|
|
if (days_ago != last_days_ago)
|
|
result << [idx + 1, days_ago]
|
|
last_days_ago = days_ago
|
|
end
|
|
|
|
end
|
|
|
|
result
|
|
end
|
|
|
|
end
|