mirror of
https://github.com/discourse/discourse.git
synced 2025-03-27 01:45:41 +08:00
821bb1e8cb
The 'Discourse SSO' protocol is being rebranded to DiscourseConnect. This should help to reduce confusion when 'SSO' is used in the generic sense. This commit aims to: - Rename `sso_` site settings. DiscourseConnect specific ones are prefixed `discourse_connect_`. Generic settings are prefixed `auth_` - Add (server-side-only) backwards compatibility for the old setting names, with deprecation notices - Copy `site_settings` database records to the new names - Rename relevant translation keys - Update relevant translations This commit does **not** aim to: - Rename any Ruby classes or methods. This might be done in a future commit - Change any URLs. This would break existing integrations - Make any changes to the protocol. This would break existing integrations - Change any functionality. Further normalization across DiscourseConnect and other auth methods will be done separately The risks are: - There is no backwards compatibility for site settings on the client-side. Accessing auth-related site settings in Javascript is fairly rare, and an error on the client side would not be security-critical. - If a plugin is monkey-patching parts of the auth process, changes to locale keys could cause broken error messages. This should also be unlikely. The old site setting names remain functional, so security-related overrides will remain working. A follow-up commit will be made with a post-deploy migration to delete the old `site_settings` rows.
51 lines
1.4 KiB
Ruby
51 lines
1.4 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'benchmark/ips'
|
|
require File.expand_path('../../../../config/environment', __FILE__)
|
|
|
|
# Put pre conditions here
|
|
# Used db but it's OK in the most cases
|
|
|
|
# build the cache
|
|
SiteSetting.title = SecureRandom.hex
|
|
SiteSetting.default_locale = SiteSetting.default_locale == 'en' ? 'zh_CN' : 'en'
|
|
SiteSetting.refresh!
|
|
|
|
tests = [
|
|
["current cache", lambda do
|
|
SiteSetting.title
|
|
SiteSetting.enable_discourse_connect
|
|
end
|
|
],
|
|
["change default locale with current cache refreshed", lambda do
|
|
SiteSetting.default_locale = SiteSetting.default_locale == 'en' ? 'zh_CN' : 'en'
|
|
end
|
|
],
|
|
["change site setting", lambda do
|
|
SiteSetting.title = SecureRandom.hex
|
|
end
|
|
],
|
|
]
|
|
|
|
Benchmark.ips do |x|
|
|
tests.each do |test, proc|
|
|
x.report(test, proc)
|
|
end
|
|
end
|
|
|
|
# 2017-08-02 - Erick's Site Setting change
|
|
|
|
# Before
|
|
# Calculating -------------------------------------
|
|
# current cache 167.518k (±12.1%) i/s - 822.983k in 5.000478s
|
|
# change default locale with current cache refreshed
|
|
# 174.173 (±16.7%) i/s - 845.000 in 5.015281s
|
|
# change site setting 132.956 (±16.5%) i/s - 663.000 in 5.124766s
|
|
|
|
# After
|
|
# Calculating -------------------------------------
|
|
# current cache 167.170k (±12.2%) i/s - 824.688k in 5.022784s
|
|
# change default locale with current cache refreshed
|
|
# 79.876 (±16.3%) i/s - 392.000 in 5.067448s
|
|
# change site setting 129.085 (±13.2%) i/s - 636.000 in 5.032536s
|