mirror of
https://github.com/discourse/discourse.git
synced 2024-12-01 01:43:40 +08:00
1f94ac154b
The spec contained an order dependency which would cause the default bool test to fail. You can confirm this by running the spec with the option "--order rand" a couple times. This dependency was caused by surprising behavior in SiteSetting::setting as shown below: SiteSetting.setting(:bool_setting?, false) SiteSetting.refresh! SiteSetting.bool_setting? #=> false SiteSetting.random_setting = true SiteSetting.bool_setting? #=> true SiteSetting.setting(:bool_setting?, false) SiteSetting.refresh! SiteSetting.bool_setting? #=> true! The spec is merely desriptive, and I have labeled what I think could be possible bugs.
165 lines
4.6 KiB
Ruby
165 lines
4.6 KiB
Ruby
require 'spec_helper'
|
|
|
|
describe SiteSetting do
|
|
|
|
describe "int setting" do
|
|
before :all do
|
|
SiteSetting.setting(:test_setting, 77)
|
|
SiteSetting.refresh!
|
|
end
|
|
|
|
it "should have a key in all_settings" do
|
|
SiteSetting.all_settings.detect {|s| s[:setting] == :test_setting }.should be_present
|
|
end
|
|
|
|
it "should have the correct desc" do
|
|
I18n.expects(:t).with("site_settings.test_setting").returns("test description")
|
|
SiteSetting.description(:test_setting).should == "test description"
|
|
end
|
|
|
|
it "should have the correct default" do
|
|
SiteSetting.test_setting.should == 77
|
|
end
|
|
|
|
context "when overidden" do
|
|
after :each do
|
|
SiteSetting.remove_override!(:test_setting)
|
|
end
|
|
|
|
it "should have the correct override" do
|
|
SiteSetting.test_setting = 100
|
|
SiteSetting.test_setting.should == 100
|
|
end
|
|
|
|
it "should coerce correct string to int" do
|
|
SiteSetting.test_setting = "101"
|
|
SiteSetting.test_setting.should.eql? 101
|
|
end
|
|
|
|
#POSSIBLE BUG
|
|
it "should coerce incorrect string to 0" do
|
|
SiteSetting.test_setting = "pie"
|
|
SiteSetting.test_setting.should.eql? 0
|
|
end
|
|
|
|
#POSSIBLE BUG
|
|
it "should not set default when reset" do
|
|
SiteSetting.test_setting = 100
|
|
SiteSetting.setting(:test_setting, 77)
|
|
SiteSetting.refresh!
|
|
SiteSetting.test_setting.should_not == 77
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "string setting" do
|
|
before :all do
|
|
SiteSetting.setting(:test_str, "str")
|
|
SiteSetting.refresh!
|
|
end
|
|
|
|
it "should have the correct default" do
|
|
SiteSetting.test_str.should == "str"
|
|
end
|
|
|
|
context "when overridden" do
|
|
after :each do
|
|
SiteSetting.remove_override!(:test_str)
|
|
end
|
|
|
|
it "should coerce int to string" do
|
|
SiteSetting.test_str = 100
|
|
SiteSetting.test_str.should.eql? "100"
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "bool setting" do
|
|
before :all do
|
|
SiteSetting.setting(:test_hello?, false)
|
|
SiteSetting.refresh!
|
|
end
|
|
|
|
it "should have the correct default" do
|
|
SiteSetting.test_hello?.should == false
|
|
end
|
|
|
|
context "when overridden" do
|
|
after :each do
|
|
SiteSetting.remove_override!(:test_hello?)
|
|
end
|
|
|
|
it "should have the correct override" do
|
|
SiteSetting.test_hello = true
|
|
SiteSetting.test_hello?.should == true
|
|
end
|
|
|
|
it "should coerce true strings to true" do
|
|
SiteSetting.test_hello = "true"
|
|
SiteSetting.test_hello?.should.eql? true
|
|
end
|
|
|
|
it "should coerce all other strings to false" do
|
|
SiteSetting.test_hello = "f"
|
|
SiteSetting.test_hello?.should.eql? false
|
|
end
|
|
|
|
#POSSIBLE BUG
|
|
it "should not set default when reset" do
|
|
SiteSetting.test_hello = true
|
|
SiteSetting.setting(:test_hello?, false)
|
|
SiteSetting.refresh!
|
|
SiteSetting.test_hello?.should_not == false
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'call_discourse_hub?' do
|
|
it 'should be true when enforce_global_nicknames is true and discourse_org_access_key is set' do
|
|
SiteSetting.enforce_global_nicknames = true
|
|
SiteSetting.discourse_org_access_key = 'asdfasfsafd'
|
|
SiteSetting.refresh!
|
|
SiteSetting.call_discourse_hub?.should == true
|
|
end
|
|
|
|
it 'should be false when enforce_global_nicknames is false and discourse_org_access_key is set' do
|
|
SiteSetting.enforce_global_nicknames = false
|
|
SiteSetting.discourse_org_access_key = 'asdfasfsafd'
|
|
SiteSetting.refresh!
|
|
SiteSetting.call_discourse_hub?.should == false
|
|
end
|
|
|
|
it 'should be false when enforce_global_nicknames is true and discourse_org_access_key is not set' do
|
|
SiteSetting.enforce_global_nicknames = true
|
|
SiteSetting.discourse_org_access_key = ''
|
|
SiteSetting.refresh!
|
|
SiteSetting.call_discourse_hub?.should == false
|
|
end
|
|
|
|
it 'should be false when enforce_global_nicknames is false and discourse_org_access_key is not set' do
|
|
SiteSetting.enforce_global_nicknames = false
|
|
SiteSetting.discourse_org_access_key = ''
|
|
SiteSetting.refresh!
|
|
SiteSetting.call_discourse_hub?.should == false
|
|
end
|
|
end
|
|
|
|
describe 'topic_title_length' do
|
|
it 'returns a range of min/max topic title length' do
|
|
SiteSetting.min_topic_title_length = 1
|
|
SiteSetting.max_topic_title_length = 2
|
|
|
|
SiteSetting.topic_title_length.should == (1..2)
|
|
end
|
|
end
|
|
|
|
describe 'post_length' do
|
|
it 'returns a range of min/max post length' do
|
|
SiteSetting.min_post_length = 1
|
|
SiteSetting.max_post_length = 2
|
|
|
|
SiteSetting.post_length.should == (1..2)
|
|
end
|
|
end
|
|
end
|