mirror of
https://github.com/discourse/discourse.git
synced 2025-02-28 09:34:27 +08:00
ac7bf98ad1
Our method of loading a subset of client settings into tests via
tests/helpers/site-settings.js can be improved upon. Currently we have a
hardcoded subset of the client settings, which may get out of date and not have
the correct defaults. As well as this plugins do not get their settings into the
tests, so whenever you need a setting from a plugin, even if it has a default,
you have to do needs.setting({ ... }) which is inconvenient.
This commit introduces an ember CLI build step to take the site_settings.yml and
all the plugin settings.yml files, pull out the client settings, and dump them
into a variable in a single JS file we can load in our tests, so we have the
correct selection of settings and default values in our JS tests. It also fixes
many, many tests that were operating under incorrect assumptions or old
settings.
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
100 lines
3.0 KiB
JavaScript
100 lines
3.0 KiB
JavaScript
import {
|
|
acceptance,
|
|
loggedInUser,
|
|
} from "discourse/tests/helpers/qunit-helpers";
|
|
import { click, triggerEvent, visit } from "@ember/test-helpers";
|
|
import { test } from "qunit";
|
|
import {
|
|
chatChannels,
|
|
generateChatView,
|
|
} from "discourse/plugins/chat/chat-fixtures";
|
|
|
|
function setupPretenders(server, helper) {
|
|
server.get("/chat/chat_channels.json", () => helper.response(chatChannels));
|
|
server.get("/chat/:chat_channel_id/messages.json", () =>
|
|
helper.response(generateChatView(loggedInUser()))
|
|
);
|
|
server.get("/chat/emojis.json", () =>
|
|
helper.response({ favorites: [{ name: "grinning" }] })
|
|
);
|
|
server.put("/chat/:id/react/:message_id.json", helper.response);
|
|
}
|
|
|
|
acceptance("Discourse Chat - Chat Message", function (needs) {
|
|
needs.user({ has_chat_enabled: true });
|
|
needs.settings({ chat_enabled: true });
|
|
needs.pretender((server, helper) => setupPretenders(server, helper));
|
|
|
|
test("when reacting to a message using inline reaction", async function (assert) {
|
|
const emojiReactionStore = this.container.lookup(
|
|
"service:chat-emoji-reaction-store"
|
|
);
|
|
|
|
assert.deepEqual(
|
|
emojiReactionStore.favorites,
|
|
this.siteSettings.default_emoji_reactions.split("|")
|
|
);
|
|
|
|
await visit("/chat/channel/4/public-category");
|
|
await click(
|
|
`.chat-message-container[data-id="176"] .chat-message-reaction[data-emoji-name="heart"]`
|
|
);
|
|
|
|
assert.deepEqual(
|
|
emojiReactionStore.favorites,
|
|
["heart"].concat(
|
|
this.siteSettings.default_emoji_reactions
|
|
.split("|")
|
|
.filter((r) => r !== "heart")
|
|
),
|
|
"it tracks the emoji"
|
|
);
|
|
|
|
await click(
|
|
`.chat-message-container[data-id="176"] .chat-message-reaction[data-emoji-name="heart"]`
|
|
);
|
|
|
|
assert.deepEqual(
|
|
emojiReactionStore.favorites,
|
|
["heart"].concat(
|
|
this.siteSettings.default_emoji_reactions
|
|
.split("|")
|
|
.filter((r) => r !== "heart")
|
|
),
|
|
"it doesn’t untrack when removing the reaction"
|
|
);
|
|
});
|
|
|
|
test("when reacting to a message using emoji picker reaction", async function (assert) {
|
|
const emojiReactionStore = this.container.lookup(
|
|
"service:chat-emoji-reaction-store"
|
|
);
|
|
|
|
assert.deepEqual(
|
|
emojiReactionStore.favorites,
|
|
this.siteSettings.default_emoji_reactions.split("|")
|
|
);
|
|
|
|
await visit("/chat/channel/4/public-category");
|
|
await triggerEvent(".chat-message-container[data-id='176']", "mouseenter");
|
|
await click(".chat-msgactions-hover .react-btn");
|
|
await click(`[data-emoji="grinning"]`);
|
|
|
|
assert.deepEqual(
|
|
emojiReactionStore.favorites,
|
|
["grinning"].concat(this.siteSettings.default_emoji_reactions.split("|")),
|
|
"it tracks the emoji"
|
|
);
|
|
|
|
await click(
|
|
`.chat-message-container[data-id="176"] .chat-message-reaction[data-emoji-name="grinning"]`
|
|
);
|
|
|
|
assert.deepEqual(
|
|
emojiReactionStore.favorites,
|
|
["grinning"].concat(this.siteSettings.default_emoji_reactions.split("|")),
|
|
"it doesn’t untrack when removing the reaction"
|
|
);
|
|
});
|
|
});
|