mirror of
https://github.com/discourse/discourse.git
synced 2024-11-24 06:46:11 +08:00
3e50313fdc
Since rspec-rails 3, the default installation creates two helper files: * `spec_helper.rb` * `rails_helper.rb` `spec_helper.rb` is intended as a way of running specs that do not require Rails, whereas `rails_helper.rb` loads Rails (as Discourse's current `spec_helper.rb` does). For more information: https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files In this commit, I've simply replaced all instances of `spec_helper` with `rails_helper`, and renamed the original `spec_helper.rb`. This brings the Discourse project closer to the standard usage of RSpec in a Rails app. At present, every spec relies on loading Rails, but there are likely many that don't need to. In a future pull request, I hope to introduce a separate, minimal `spec_helper.rb` which can be used in tests which don't rely on Rails.
59 lines
1.6 KiB
Ruby
59 lines
1.6 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe Admin::SiteSettingsController do
|
|
|
|
it "is a subclass of AdminController" do
|
|
expect(Admin::SiteSettingsController < Admin::AdminController).to eq(true)
|
|
end
|
|
|
|
context 'while logged in as an admin' do
|
|
before do
|
|
@user = log_in(:admin)
|
|
end
|
|
|
|
context 'index' do
|
|
it 'returns success' do
|
|
xhr :get, :index
|
|
expect(response).to be_success
|
|
end
|
|
|
|
it 'returns JSON' do
|
|
xhr :get, :index
|
|
expect(::JSON.parse(response.body)).to be_present
|
|
end
|
|
end
|
|
|
|
context 'update' do
|
|
|
|
before do
|
|
SiteSetting.setting(:test_setting, "default")
|
|
end
|
|
|
|
it 'sets the value when the param is present' do
|
|
SiteSetting.expects(:'test_setting=').with('hello').once
|
|
xhr :put, :update, id: 'test_setting', test_setting: 'hello'
|
|
end
|
|
|
|
it 'allows value to be a blank string' do
|
|
SiteSetting.expects(:'test_setting=').with('').once
|
|
xhr :put, :update, id: 'test_setting', test_setting: ''
|
|
end
|
|
|
|
it 'logs the change' do
|
|
SiteSetting.stubs(:test_setting).returns('previous')
|
|
SiteSetting.expects(:'test_setting=').with('hello').once
|
|
StaffActionLogger.any_instance.expects(:log_site_setting_change).with('test_setting', 'previous', 'hello')
|
|
xhr :put, :update, id: 'test_setting', test_setting: 'hello'
|
|
end
|
|
|
|
it 'fails when a setting does not exist' do
|
|
expect {
|
|
xhr :put, :update, id: 'provider', provider: 'gotcha'
|
|
}.to raise_error(ArgumentError)
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
end
|