mirror of
https://github.com/discourse/discourse.git
synced 2024-11-27 14:43:38 +08:00
b18c01e3c6
Not reseting the registry could lead to assets still being registered for example.
This flakky spec was reprdocible with this call: `bundle exec rspec --seed 9472 spec/components/discourse_plugin_registry_spec.rb spec/components/svg_sprite/svg_sprite_spec.rb`
Which would trigger the following error:
```
Failures:
1) DiscoursePluginRegistry#register_asset registers vendored_core_pretty_text properly
Failure/Error: expect(registry.javascripts.count).to eq(0)
expected: 0
got: 1
(compared using ==)
# ./spec/components/discourse_plugin_registry_spec.rb:248:in `block (3 levels) in <top (required)>'
# ./spec/rails_helper.rb:280:in `block (2 levels) in <top (required)>'
# /Users/joffreyjaffeux/.gem/ruby/2.7.3/gems/webmock-3.14.0/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'
```
|
||
|---|---|---|
| .. | ||
| backup_restore | ||
| compression | ||
| content_security_policy | ||
| i18n | ||
| imap/providers | ||
| onebox | ||
| seed_data | ||
| site_settings | ||
| topic_query | ||
| validators | ||
| webauthn | ||
| bookmark_manager_spec.rb | ||
| bookmark_query_spec.rb | ||
| bookmark_reminder_notification_handler_spec.rb | ||
| browser_detection_spec.rb | ||
| content_security_policy_spec.rb | ||
| db_helper_spec.rb | ||
| discourse_js_processor_spec.rb | ||
| encodings_spec.rb | ||
| introduction_updater_spec.rb | ||
| mini_sql_multisite_connection_spec.rb | ||
| onebox_spec.rb | ||
| post_jobs_enqueuer_spec.rb | ||
| search_spec.rb | ||
| shrink_uploaded_image_spec.rb | ||
| theme_flag_modifier_spec.rb | ||
| theme_javascript_compiler_spec.rb | ||
| topic_upload_security_manager_spec.rb | ||
| upload_creator_spec.rb | ||
| upload_recovery_spec.rb | ||
| upload_security_spec.rb | ||