mirror of
https://github.com/discourse/discourse.git
synced 2025-01-06 13:13:53 +08:00
ab7f3ee599
`last_message_sent_at` has a `NOT_NULL` constraint in the DB so it should be safe to use for sorting.
This was causing two flakeys:
```
1) UserNotifications.chat_summary with public channel email subject with regular mentions includes both channel titles when there are exactly two with unread mentions
Failure/Error: example.run
expected: "[Discourse] New message in Random 62 and Test channel"
got: "[Discourse] New message in Test channel and Random 62"
(compared using ==)
# ./plugins/chat/spec/mailers/user_notifications_spec.rb:203:in `block (6 levels) in <main>'
# ./spec/rails_helper.rb:356:in `block (2 levels) in <top (required)>'
# ./vendor/bundle/ruby/3.1.0/gems/webmock-3.18.1/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'
2) UserNotifications.chat_summary with public channel email subject with regular mentions displays a count when there are more than two channels with unread mentions
Failure/Error: example.run
expected: "[Discourse] New message in Random 62 and 2 others"
got: "[Discourse] New message in Test channel 0 and 2 others"
(compared using ==)
# ./plugins/chat/spec/mailers/user_notifications_spec.rb:236:in `block (6 levels) in <main>'
# ./spec/rails_helper.rb:356:in `block (2 levels) in <top (required)>'
# ./vendor/bundle/ruby/3.1.0/gems/webmock-3.18.1/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'
```
|
||
|---|---|---|
| .. | ||
| discourse_dev | ||
| email_controller_helper | ||
| extensions | ||
| onebox/templates | ||
| tasks | ||
| validators | ||
| chat_channel_archive_service.rb | ||
| chat_channel_fetcher.rb | ||
| chat_channel_hashtag_data_source.rb | ||
| chat_channel_membership_manager.rb | ||
| chat_mailer.rb | ||
| chat_message_bookmarkable.rb | ||
| chat_message_creator.rb | ||
| chat_message_processor.rb | ||
| chat_message_rate_limiter.rb | ||
| chat_message_reactor.rb | ||
| chat_message_updater.rb | ||
| chat_notifier.rb | ||
| chat_review_queue.rb | ||
| chat_seeder.rb | ||
| chat_statistics.rb | ||
| chat_transcript_service.rb | ||
| direct_message_channel_creator.rb | ||
| duplicate_message_validator.rb | ||
| guardian_extensions.rb | ||
| message_mover.rb | ||
| post_notification_handler.rb | ||
| secure_uploads_compatibility.rb | ||
| slack_compatibility.rb | ||