discourse/lib
Martin Brennan 0568d36133
FIX: Use dualstack S3 endpoint for direct uploads (#29611)
When we added direct S3 uploads to Discourse, which use
presigned URLs, we never took into account the dualstack
endpoints for IPv6 on S3.

This commit fixes the issue by using the dualstack endpoints
for presigned URLs and requests, which are used in the
get-presigned-put and batch-presign-urls endpoints used when
directly uploading to S3.

It also makes regular S3 requests for `put` and so on use
dualstack URLs. It doesn't seem like there is a downside to
doing this, but a bunch of specs needed to be updated to reflect this.
2024-11-07 11:06:39 +10:00
..
action_dispatch/session
active_support_type_extensions DEV: Improve array type in service contracts 2024-10-17 17:02:02 +02:00
auth DEV: Remove logical OR assignment of constants (#29201) 2024-10-16 10:09:07 +08:00
autospec DEV: Update to lastest rubocop-discourse 2024-05-27 18:06:14 +02:00
backup_restore FIX: Restoring backup could fail due to missing discourse_functions (#29332) 2024-10-22 16:13:01 +02:00
common_passwords
compression DEV: Fix Lint/ShadowedArgument (#24733) 2023-12-06 13:16:10 +01:00
content_security_policy DEV: Remove unsafe_eval from test/theme-test CSP (#28774) 2024-09-06 13:28:33 +02:00
demon DEV: Remove logical OR assignment of constants (#29201) 2024-10-16 10:09:07 +08:00
discourse_dev DEV: Fix various rubocop lints (#24749) 2023-12-06 23:25:00 +01:00
discourse_webauthn DEV: Add routes and controller actions for passkeys (2/3) (#23587) 2023-10-11 14:36:54 -04:00
email DEV: Remove logical OR assignment of constants (#29201) 2024-10-16 10:09:07 +08:00
email_controller_helper DEV: Update to lastest rubocop-discourse 2024-05-27 18:06:14 +02:00
emoji
faker DEV: Don't run dev-only code in specs (#23427) 2023-09-06 02:14:57 +02:00
file_store DEV: Bump rubocop_discourse (#29608) 2024-11-06 06:27:49 +08:00
final_destination SECURITY: Add FastImage SSRF safe freedom patch 2024-07-03 20:49:15 +08:00
freedom_patches PERF: Don't do initialization for every DB if RAILS_DB is set (#28668) 2024-09-03 15:56:46 +10:00
generators FEATURE: Create rake for db migration in plugins (#29163) 2024-10-18 11:43:45 -03:00
guardian FEATURE: improve the suppression for admins when required (#29041) 2024-10-02 10:52:02 +10:00
i18n DEV: Enable Rails 7.1 defaults 2024-08-12 10:41:13 +02:00
imap DEV: Fix various rubocop lints (#24749) 2023-12-06 23:25:00 +01:00
import DEV: lint against Layout/EmptyLineBetweenDefs (#24914) 2023-12-15 23:46:04 +08:00
import_export DEV: Update to lastest rubocop-discourse 2024-05-27 18:06:14 +02:00
middleware SECURITY: Use different anon cache keys for XHR requests 2024-10-07 11:48:45 +08:00
migration DEV: Remove logical OR assignment of constants (#29201) 2024-10-16 10:09:07 +08:00
onebox DEV: Bump rubocop_discourse (#29608) 2024-11-06 06:27:49 +08:00
plugin FEATURE: Enable the new /about page for everyone (#29390) 2024-10-29 18:40:11 +03:00
pretty_text FIX: BBCode tag parser 2024-06-18 10:47:18 +02:00
rate_limiter
reviewable DEV: remap all core icons for fontawesome 6 upgrade (#28715) 2024-09-13 16:50:52 +01:00
scheduler DEV: Remove logical OR assignment of constants (#29201) 2024-10-16 10:09:07 +08:00
search FIX: Handle nil post_search_data for search result (#26179) 2024-03-14 14:40:46 -03:00
second_factor DEV: Update confirm-email flows to use central 2fa and ember rendering (#25404) 2024-01-30 10:32:42 +00:00
seed_data FIX: Requested changes from dev (#28784) 2024-09-09 08:55:42 -05:00
service DEV: Remove hash-like access from service contracts 2024-10-29 16:02:51 +01:00
sidekiq DEV: Fix various rubocop lints (#24749) 2023-12-06 23:25:00 +01:00
site_settings FEATURE: Introduce site settings which require confirmation (#27315) 2024-06-19 16:01:24 +10:00
stylesheet DEV: Remove logical OR assignment of constants (#29201) 2024-10-16 10:09:07 +08:00
summarization DEV: Remove summarization code (#27373) 2024-07-02 08:51:47 -07:00
tasks DEV: Bump rubocop_discourse (#29608) 2024-11-06 06:27:49 +08:00
theme_settings_manager FIX: Pass values of objects typed settings to theme migrations (#26751) 2024-04-25 16:39:22 +03:00
theme_store DEV: Replace silent theme-install fails with exceptions (#28485) 2024-08-22 12:09:56 +01:00
topic_query FEATURE: option to sort user and group private messages. (#25146) 2024-01-10 13:33:30 +05:30
turbo_tests DEV: check_pending -> check_all_pending! (#27724) 2024-07-05 09:29:32 +08:00
validators DEV: Migrate user passwords data to UserPassword table (#28746) 2024-10-10 09:23:06 +08:00
wizard DEV: Update member access wizard step to use toggle group (#28013) 2024-07-29 14:07:06 +08:00
admin_confirmation.rb
admin_constraint.rb
admin_user_index_query.rb DEV: Remove deprecated ascending param from AdminUserIndexQuery (#22741) 2023-07-24 09:37:18 +08:00
age_words.rb DEV: Move distance_of_time_in_words/time_ago_in_words (#21745) 2023-05-25 14:53:59 +02:00
archetype.rb DEV: Update to lastest rubocop-discourse 2024-05-27 18:06:14 +02:00
auth.rb FIX: Do not capture OAuth user on 2FA page (#27617) 2024-06-27 10:27:49 +10:00
backup_restore.rb Revert "FIX: backup_restore.rb wants db user from user, not username (#28229)" (#28245) 2024-08-06 14:11:48 +01:00
badge_posts_view_manager.rb
badge_queries.rb FEATURE: custom flag can require additional message (#27908) 2024-07-18 10:10:22 +10:00
base62.rb DEV: Bump rubocop_discourse (#29608) 2024-11-06 06:27:49 +08:00
bookmark_manager.rb
bookmark_query.rb FIX: Show deleted bookmark reminders in user bookmarks menu (#25905) 2024-02-29 09:03:49 +10:00
bookmark_reminder_notification_handler.rb FIX: Bookmark reminder was clearing incorrectly (#28506) 2024-08-26 09:17:39 +10:00
bookmarks_bulk_action.rb FIX: Bookmark reminder was clearing incorrectly (#28506) 2024-08-26 09:17:39 +10:00
browser_detection.rb
cache.rb FIX: race condition in Discourse.cache.fetch (#28124) 2024-07-30 09:08:12 +02:00
canonical_url.rb
category_badge.rb FIX: email category badges shouldn't use category text color (#25655) 2024-02-13 10:18:36 -05:00
chrome_installed_checker.rb DEV: lint against Layout/EmptyLineBetweenDefs (#24914) 2023-12-15 23:46:04 +08:00
color_math.rb
comment_migration.rb
common_passwords.rb DEV: Update to lastest rubocop-discourse 2024-05-27 18:06:14 +02:00
composer_messages_finder.rb DEV: Update to lastest rubocop-discourse 2024-05-27 18:06:14 +02:00
configurable_urls.rb PERF: Cache ToS and Privacy Policy paths (#21860) 2023-06-07 21:31:20 +03:00
content_buffer.rb
content_security_policy.rb DEV: Remove unsafe_eval from test/theme-test CSP (#28774) 2024-09-06 13:28:33 +02:00
cooked_post_processor.rb FIX: show lightbox for small images (#29140) 2024-10-18 09:45:08 +04:00
cooked_processor_mixin.rb UX: replace broken link SVG with new Font Awesome 6 name (#29623) 2024-11-06 13:35:07 -05:00
crawler_detection.rb
csrf_token_verifier.rb
current_user.rb
custom_renderer.rb
db_helper.rb DEV: Remove logical OR assignment of constants (#29201) 2024-10-16 10:09:07 +08:00
directory_helper.rb DEV: Update to lastest rubocop-discourse 2024-05-27 18:06:14 +02:00
discourse_connect_base.rb FEATURE: Increase default DiscourseConnect session length (#26261) 2024-03-20 14:02:12 +00:00
discourse_connect_provider.rb DEV: lint against Layout/EmptyLineBetweenDefs (#24914) 2023-12-15 23:46:04 +08:00
discourse_dev.rb
discourse_diff.rb
discourse_event.rb DEV: Add :push_notification event and deprecate :post_notification_alert (#22917) 2023-08-02 18:44:19 -03:00
discourse_hub.rb DEV: include more data in Discourse Discover enrollment payload. (#25846) 2024-02-25 10:42:50 +05:30
discourse_ip_info.rb FIX: Rescue and warn when error is encountered in DiscourseIpInfo.mmdb_download (#28134) 2024-07-30 11:33:20 +08:00
discourse_js_processor.rb DEV: Switch to pnpm for JS dependencies (#28671) 2024-09-03 10:51:07 +01:00
discourse_logstash_logger.rb DEV: Log sidekiq job opts as string instead of hash (#28012) 2024-07-23 06:27:43 +08:00
discourse_plugin_registry.rb DEV: allow the plugin to register valid site setting areas (#29432) 2024-10-29 09:40:31 +11:00
discourse_redis.rb DEV: Remove Discourse.redis.delete_prefixed (#22103) 2023-06-16 12:44:35 +10:00
discourse_sourcemapping_url_processor.rb
discourse_tagging.rb DEV: Remove logical OR assignment of constants (#29201) 2024-10-16 10:09:07 +08:00
discourse_updates.rb FIX: visual regression for new features (#29359) 2024-10-23 16:16:19 +11:00
discourse_webauthn.rb FIX: Webauthn origin was incorrect for subfolder setups (#25651) 2024-02-12 16:27:24 -05:00
discourse.rb DEV: Bump rubocop_discourse (#29608) 2024-11-06 06:27:49 +08:00
disk_space.rb PERF: Faster disk space calculation on upload heavy instances (#28307) 2024-10-24 12:11:40 +02:00
distributed_cache.rb DEV: Reduce duplication with DistributedMutex#clear_regex (#25795) 2024-02-21 14:19:04 -06:00
distributed_memoizer.rb
distributed_mutex.rb
edit_rate_limiter.rb
email_backup_token.rb
email_cook.rb
email_templates_finder.rb FIX: Add new/missing email templates to the email templates editor (#28075) 2024-07-30 00:27:41 +03:00
email_updater.rb
email.rb
ember_cli.rb DEV: Switch to pnpm for JS dependencies (#28671) 2024-09-03 10:51:07 +01:00
encodings.rb DEV: Update to lastest rubocop-discourse 2024-05-27 18:06:14 +02:00
enum_site_setting.rb
enum.rb
excerpt_parser.rb DEV: Update code comment wording (#22861) 2023-07-28 11:47:22 -06:00
external_upload_helpers.rb DEV: Improve external upload debugging (#28627) 2024-08-30 10:25:04 +10:00
feed_element_installer.rb
feed_item_accessor.rb
file_helper.rb FIX: Use MaxMind supplied permalinks to download MaxMind databases (#26847) 2024-05-09 15:11:56 +08:00
filter_best_posts.rb
final_destination.rb FEATURE: use new site setting for onebox custom user agent. (#28045) 2024-07-24 04:45:30 +05:30
flag_query.rb
flag_settings.rb FEATURE: custom flag can require additional message (#27908) 2024-07-18 10:10:22 +10:00
gaps.rb
gc_stat_instrumenter.rb DEV: Seperate concerns of tracking GC stat from MethodProfiler (#22921) 2023-08-02 10:46:37 +08:00
git_repo.rb FEATURE: display commit hash for each plugin on /admin/plugins page. (#22176) 2023-06-26 10:09:57 +05:30
git_url.rb
git_utils.rb DEV: Fix unicorn not booting due to 8e10878 (#27727) 2024-07-05 10:36:13 +08:00
global_path.rb
group_lookup.rb FEATURE: display PM participant group names in the topics list. (#21677) 2023-05-31 19:32:06 +05:30
guardian.rb FEATURE: Support designating multiple groups as mods on category (#28655) 2024-09-04 04:38:46 +03:00
has_errors.rb FIX: prevents PM to large groups (#28681) 2024-09-03 12:08:14 +02:00
highlight_js.rb DEV: Bump rubocop_discourse (#29608) 2024-11-06 06:27:49 +08:00
hijack.rb DEV: Upgrade Rails to version 7.1 2024-07-04 10:58:21 +02:00
homepage_constraint.rb FIX: Regression in custom homepage modifier used in theme components (#27569) 2024-06-21 11:24:11 -04:00
homepage_helper.rb DEV: implements register_modifier(:custom_homepage_enabled) (#28657) 2024-08-30 11:06:07 +02:00
html_prettify.rb
html_to_markdown.rb DEV: Bump rubocop_discourse (#29608) 2024-11-06 06:27:49 +08:00
http_language_parser.rb
http_user_agent_encoder.rb DEV: Apply suggested changes 2024-06-11 14:02:46 +02:00
image_sizer.rb
import_export.rb
inline_oneboxer.rb
job_time_spacer.rb FEATURE: Auto-remove users without permission from channel (#20344) 2023-03-22 10:19:59 +10:00
js_locale_helper.rb DEV: Bump rubocop_discourse (#29608) 2024-11-06 06:27:49 +08:00
json_error.rb
letter_avatar.rb DEV: replace imagemagick convert commands with magick (#27767) 2024-07-08 16:55:59 +08:00
markdown_linker.rb
mem_info.rb DEV: Move non scheduled problem checks to classes (#26122) 2024-03-14 10:55:01 +08:00
message_bus_diags.rb
method_profiler.rb DEV: Seperate concerns of tracking GC stat from MethodProfiler (#22921) 2023-08-02 10:46:37 +08:00
mini_scheduler_long_running_job_logger.rb DEV: Log a warning message when a MiniScheduler scheduled job is stuck (#28258) 2024-08-08 12:20:16 +08:00
mini_sql_multisite_connection.rb DEV: Track SQL queries from MiniSql (#28824) 2024-09-11 10:14:53 +03:00
mobile_detection.rb
new_post_manager.rb DEV: Update to lastest rubocop-discourse 2024-05-27 18:06:14 +02:00
new_post_result.rb DEV: Update to lastest rubocop-discourse 2024-05-27 18:06:14 +02:00
notification_levels.rb
onebox.rb SECURITY: Prevent Onebox cache overflow by limiting downloads and URL lengths 2023-11-09 13:39:18 +11:00
oneboxer.rb DEV: Bump rubocop_discourse (#29608) 2024-11-06 06:27:49 +08:00
onpdiff.rb
password_hasher.rb FEATURE: Persist password hashing algorithm/params in database (#20980) 2023-04-11 10:16:28 +01:00
pbkdf2.rb PERF: Use OpenSSL::KDF for Pbkdf2 implementation (#20982) 2023-04-05 17:00:05 +01:00
permalink_constraint.rb
pinned_check.rb
plain_text_to_markdown.rb DEV: Bump rubocop_discourse (#29608) 2024-11-06 06:27:49 +08:00
plugin_gem.rb DEV: Search for -gnu gem variants (#27347) 2024-06-05 14:58:02 +02:00
plugin.rb DEV: Fixup plugin initialization guard (#24628) 2023-11-29 11:44:09 +00:00
post_action_creator.rb FEATURE: Support designating multiple groups as mods on category (#28655) 2024-09-04 04:38:46 +03:00
post_action_destroyer.rb FIX: serialize Flags instead of PostActionType (#28362) 2024-08-14 12:13:46 +10:00
post_action_result.rb
post_action_type_view.rb FIX: serialize Flags instead of PostActionType (#28362) 2024-08-14 12:13:46 +10:00
post_creator.rb FIX: double reviewable items bug (#28161) 2024-07-31 12:45:00 +10:00
post_destroyer.rb FIX: serialize Flags instead of PostActionType (#28362) 2024-08-14 12:13:46 +10:00
post_jobs_enqueuer.rb DEV: Add import_embed_unlisted site setting (#26222) 2024-03-27 08:57:43 -04:00
post_locker.rb
post_merger.rb
post_revisor.rb FIX: Change create_post_for_category_and_tag_changes setting to use whispers instead of small actions (#29602) 2024-11-06 09:28:28 -03:00
presence_channel.rb DEV: Remove logical OR assignment of constants (#29201) 2024-10-16 10:09:07 +08:00
pretty_text.rb DEV: Bump rubocop_discourse (#29608) 2024-11-06 06:27:49 +08:00
promotion.rb DEV: Add PluginRegistry modifiers to #review and #recalculate (#29128) 2024-10-16 10:26:10 -05:00
quote_comparer.rb DEV: Correct Style/RedundantReturn rubocop issues (#23052) 2023-08-10 02:03:38 +02:00
quote_rewriter.rb SECURITY: escape display names 2023-11-09 13:39:06 +11:00
rake_helpers.rb
rate_limiter.rb DEV: Remove Discourse.redis.delete_prefixed (#22103) 2023-06-16 12:44:35 +10:00
read_only_mixin.rb FIX: Change request method for categories/search (#26976) 2024-05-13 14:37:17 +03:00
require_dependency_backward_compatibility.rb
retrieve_title.rb FIX: Request html when fetching inline onebox data (#24674) 2023-12-04 11:36:42 +10:00
route_format.rb
route_matcher.rb DEV: Remove logical OR assignment of constants (#29201) 2024-10-16 10:09:07 +08:00
rtl.rb DEV: Remove duplicate definition of RTL locales and add Uyghur to the list (#27387) 2024-06-08 21:24:39 +02:00
s3_cors_rulesets.rb FIX: Update DIRECT_UPLOAD CORS ruleset to include new Amazon signing headers (#23379) 2023-09-04 16:09:52 +10:00
s3_helper.rb FIX: Use dualstack S3 endpoint for direct uploads (#29611) 2024-11-07 11:06:39 +10:00
s3_inventory.rb DEV: Restore missing_s3_uploads stats count if site was restored (#27984) 2024-07-19 14:22:58 +08:00
score_calculator.rb
screening_model.rb
search.rb DEV: Remove logical OR assignment of constants (#29201) 2024-10-16 10:09:07 +08:00
secure_session.rb DEV: Fix various rubocop lints (#24749) 2023-12-06 23:25:00 +01:00
secure_upload_endpoint_helpers.rb DEV: Add SecureUploadEndpointHelpers for controllers (#25758) 2024-02-20 11:19:22 +10:00
service.rb DEV: Replace params by the contract object in services 2024-10-25 14:48:34 +02:00
shrink_uploaded_image.rb FIX: Ignore invalid images when shrinking uploads (#25346) 2024-01-22 12:10:29 +01:00
sidekiq_logster_reporter.rb DEV: Improve logging of Sidekiq errors when logstash logger is enabled (#27855) 2024-07-11 14:17:18 +08:00
sidekiq_long_running_job_logger.rb DEV: Add ability to log a warning when Sidekiq job runs for too long (#27446) 2024-06-13 14:24:44 +08:00
signal_trap_logger.rb DEV: Log Unicorn worker timeout backtraces to Rails.logger (#27257) 2024-06-03 12:51:12 +08:00
site_icon_manager.rb DEV: Move Bookmark modal/component to use d-modal (#22532) 2023-07-17 10:14:17 +10:00
site_setting_extension.rb DEV: use Sets for setting lists. (#29584) 2024-11-05 16:04:24 +11:00
slug.rb
smtp_provider_overrides.rb UX: Use a dropdown for SSL mode for group SMTP (#27932) 2024-07-18 10:33:14 +10:00
socket_server.rb
spam_handler.rb
staff_constraint.rb
staff_message_format.rb
statistics.rb FIX: participating users statistics... (#29293) 2024-10-21 18:18:42 +02:00
suggested_topics_builder.rb DEV: Add modifier to SuggestedTopicsBuilder#add_results (#29164) 2024-10-10 10:03:26 -05:00
svg_sprite.rb UX: New experimental features should be marked clearly (#29622) 2024-11-06 15:26:30 -08:00
system_message.rb FIX: Send TL2 promotion message to correct user (#21978) 2023-06-07 22:51:24 +03:00
temporary_db.rb
temporary_redis.rb
text_cleaner.rb
text_sentinel.rb DEV: Remove logical OR assignment of constants (#29201) 2024-10-16 10:09:07 +08:00
theme_javascript_compiler.rb DEV: Compile theme migrations javascript files when running theme qunit (#25219) 2024-01-16 09:50:44 +08:00
theme_metadata.rb DEV: Run system tests for official themes (#24378) 2023-11-16 07:11:35 +08:00
theme_modifier_helper.rb
theme_resolver.rb DEV: Extract theme resolution to a helper (#27426) 2024-06-20 11:33:46 -04:00
theme_settings_manager.rb FIX: Pass values of objects typed settings to theme migrations (#26751) 2024-04-25 16:39:22 +03:00
theme_settings_object_validator.rb DEV: Add isValidUrl helper function to theme migrations (#26817) 2024-04-30 16:45:07 +08:00
theme_settings_parser.rb DEV: Update to lastest rubocop-discourse 2024-05-27 18:06:14 +02:00
theme_settings_validator.rb DEV: Update to lastest rubocop-discourse 2024-05-27 18:06:14 +02:00
theme_translation_manager.rb
theme_translation_parser.rb
timeline_lookup.rb
tiny_japanese_segmenter.rb
topic_creator.rb FIX: prevents PM to large groups (#28681) 2024-09-03 12:08:14 +02:00
topic_list_responder.rb
topic_publisher.rb
topic_query_params.rb FIX: Return 400 response codes when topic list query params are invalid (#27930) 2024-07-16 10:30:04 +08:00
topic_query.rb SECURITY: prevent topic list filtering by hidden tags for unathorized users 2024-10-07 11:48:55 +08:00
topic_retriever.rb
topic_subtype.rb DEV: Update to lastest rubocop-discourse 2024-05-27 18:06:14 +02:00
topic_upload_security_manager.rb DEV: Introduce post_should_secure_uploads? plugin modifier (#26508) 2024-04-10 12:02:44 +10:00
topic_view.rb FEATURE: theme_modifiers can depend on theme settings (plus serialize_post_user_badges) (#29227) 2024-10-17 15:16:16 +01:00
topics_bulk_action.rb FIX: Message for bulk closing topics silently (#27400) 2024-06-11 09:36:54 +10:00
topics_filter.rb DEV: Extend /filter's ability to order (#28242) 2024-08-07 16:37:00 +08:00
truncate_logs_formatter.rb SECURITY: Add a default limit as to when logs should be truncated 2023-10-16 10:34:38 -04:00
trust_level.rb
turbo_tests.rb DEV: Repair RSpec full_cause_backtrace under bin/turbo_rspec (#26087) 2024-03-07 18:35:46 +00:00
twitter_api.rb FIX: Minor Twitter onebox improvements (#22387) 2023-07-03 19:53:12 -03:00
unicorn_logstash_patch.rb
unread.rb
upload_creator.rb DEV: Remove logical OR assignment of constants (#29201) 2024-10-16 10:09:07 +08:00
upload_fixer.rb
upload_markdown.rb DEV: Uploads import script can download files (#26816) 2024-05-04 22:48:16 +02:00
upload_recovery.rb FEATURE: allow S3 ACLs to be disabled (#21769) 2023-06-06 15:47:40 +10:00
upload_security.rb DEV: Rename with_secure_uploads? to should_secure_uploads? on Post (#26549) 2024-04-09 13:23:11 +10:00
url_helper.rb DEV: Add isValidUrl helper function to theme migrations (#26817) 2024-04-30 16:45:07 +08:00
user_comm_screener.rb DEV: Refactor DM channel creation into new service pattern (#22144) 2023-07-03 10:18:37 +10:00
user_lookup.rb
user_name_suggester.rb DEV: Fix various spec linting issues (#24672) 2023-12-04 13:45:19 +01:00
vary_header.rb
version.rb DEV: Remove logical OR assignment of constants (#29201) 2024-10-16 10:09:07 +08:00
wizard.rb DEV: Update to lastest rubocop-discourse 2024-05-27 18:06:14 +02:00
work_queue.rb PERF: Don't allow a single user to monopolize the defer queue (#25593) 2024-02-07 13:47:50 -06:00
xml_cleaner.rb FIX: Remove invalid chars from feed XMLs (#24001) 2023-10-19 14:37:37 -03:00