discourse/lib/freedom_patches
Ted Johansson 25a226279a
DEV: Replace #pluck_first freedom patch with AR #pick in core (#19893)
The #pluck_first freedom patch, first introduced by @danielwaterworth has served us well, and is used widely throughout both core and plugins. It seems to have been a common enough use case that Rails 6 introduced it's own method #pick with the exact same implementation. This allows us to retire the freedom patch and switch over to the built-in ActiveRecord method.

There is no replacement for #pluck_first!, but a quick search shows we are using this in a very limited capacity, and in some cases incorrectly (by assuming a nil return rather than an exception), which can quite easily be replaced with #pick plus some extra handling.
2023-02-13 12:39:45 +08:00
..
active_record_attribute_methods.rb DEV: Clean up freedom patches 2022-04-06 10:07:14 +02:00
ams_include_without_root.rb DEV: enable frozen string literal on all files 2019-05-13 09:31:32 +08:00
better_handlebars_errors.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
copy_file.rb DEV: Work around a Docker issue (#13368) 2021-06-14 17:38:36 +02:00
cose_rsapkcs1.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
fast_pluck.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
inflector_backport.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
ip_addr.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
mail_disable_starttls.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
pluck_first.rb DEV: Replace #pluck_first freedom patch with AR #pick in core (#19893) 2023-02-13 12:39:45 +08:00
rails_multisite.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
rails4.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
safe_buffer.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
safe_migrations.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
schema_migration_details.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
sprockets_patches.rb DEV: Apply syntax_tree formatting to lib/* 2023-01-09 12:10:19 +00:00
translate_accelerator.rb DEV: Prefer \A and \z over ^ and $ in regexes (#19936) 2023-01-20 12:52:49 -06:00