discourse/app
Martin Brennan 3c5fb871c0 SECURITY: Filter unread bookmark reminders the user cannot see
There is an edge case where the following occurs:

1. The user sets a bookmark reminder on a post/topic
2. The post/topic is changed to a PM before or after the reminder
   fires, and the notification remains unread by the user
3. The user opens their bookmark reminder notification list
   and they can still see the notification even though they cannot
   access the topic anymore

There is a very low chance for information leaking here, since
the only thing that could be exposed is the topic title if it
changes to something sensitive.

This commit filters the bookmark unread notifications by using
the bookmarkable can_see? methods and also prevents sending
reminder notifications for bookmarks the user can no longer see.
2023-11-09 13:39:16 +11:00
..
assets SECURITY: Limit height of pre/svg elements 2023-11-09 13:39:13 +11:00
controllers SECURITY: Filter unread bookmark reminders the user cannot see 2023-11-09 13:39:16 +11:00
helpers DEV: remove markdown-it-bundle and custom build code (#23859) 2023-11-06 16:59:49 +00:00
jobs FIX: Deleting/recovering a post in topics caused bookmark side effects (#24226) 2023-11-07 12:54:05 +10:00
mailers FIX: Order tags shown in email subject by topics count and name (#22586) 2023-07-13 15:39:58 +08:00
models SECURITY: Filter unread bookmark reminders the user cannot see 2023-11-09 13:39:16 +11:00
serializers FEATURE: Add custom fields to members on group index (#24232) 2023-11-07 10:06:47 -04:00
services SECURITY: Filter unread bookmark reminders the user cannot see 2023-11-09 13:39:16 +11:00
views DEV: Use WebPack stats plugin to map entrypoints to chunks (#24239) 2023-11-07 10:24:49 +00:00