mirror of
https://github.com/discourse/discourse.git
synced 2024-11-26 04:43:37 +08:00
c124c69833
- Remove the wildcard crawler. This was already excluding almost all file types, but the exclude list was missing '.gjs' which meant those files were unnecessarily being hoisted into the `public/` directory during precompile - Automatically include all ember-cli-generated assets without needing them to be listed. The main motivation for this change is to allow us to start using async imports via Embroider/Webpack. The filenames for those new async bundles will not be known in advance. - Skips sprockets fingerprinting on Embroider/Webpack chunk JS files. Their filenames already include a fingerprint, and having sprockets change the filenames will cause problems for the async import feature (where filenames are included deep inside js bundles) This commit also updates our ember-cli build so that it skips building plugin tests in the production environment. This should provide a slight build speed improvement.
65 lines
2.3 KiB
Ruby
65 lines
2.3 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
# This contains two patches to make sprockets more tolerable in dev
|
|
#
|
|
# 1. Stop computing asset paths which triggers sprockets to do mountains of work
|
|
# All our assets in dev are in the /assets folder anyway
|
|
#
|
|
# 2. Stop using a concatenator that does tons of work checking for semicolons when
|
|
# when rebuilding an asset
|
|
|
|
module FreedomPatches
|
|
module SprocketsPatches
|
|
def self.concat_javascript_sources(buf, source)
|
|
if buf.bytesize > 0
|
|
# CODE REMOVED HERE
|
|
buf << ";" # unless string_end_with_semicolon?(buf)
|
|
buf << "\n" # unless buf.end_with?("\n")
|
|
end
|
|
buf << source
|
|
end
|
|
|
|
if Rails.env.development? || Rails.env.test?
|
|
Sprockets.register_bundle_metadata_reducer "application/javascript",
|
|
:data,
|
|
proc { +"" },
|
|
method(:concat_javascript_sources)
|
|
end
|
|
end
|
|
end
|
|
|
|
if Rails.env.development? || Rails.env.test?
|
|
ActiveSupport.on_load(:action_view) do
|
|
def compute_asset_path(source, _options = {})
|
|
"/assets/#{source}"
|
|
end
|
|
alias_method :public_compute_asset_path, :compute_asset_path
|
|
end
|
|
end
|
|
|
|
# By default, the Sprockets DirectiveProcessor introduces a newline between possible 'header' comments
|
|
# and the rest of the JS file. (https://github.com/rails/sprockets/blob/f4d3dae71e/lib/sprockets/directive_processor.rb#L121)
|
|
# This causes sourcemaps to be offset by 1 line, and therefore breaks browser tooling.
|
|
# We know that Ember-Cli assets do not use Sprockets directives, so we can totally bypass the DirectiveProcessor for those files.
|
|
Sprockets::DirectiveProcessor.prepend(
|
|
Module.new do
|
|
def process_source(source)
|
|
return source, [] if EmberCli.is_ember_cli_asset?(File.basename(@filename))
|
|
super
|
|
end
|
|
end,
|
|
)
|
|
|
|
# Skip sprockets fingerprinting for some assets
|
|
Sprockets::Asset.prepend(
|
|
Module.new do
|
|
def digest_path
|
|
# Workbox assets are already in a folder with a digest in the name
|
|
return logical_path if logical_path.start_with?("workbox-")
|
|
# Webpack chunks are already named based on their contents
|
|
return logical_path if logical_path.start_with?("chunk.")
|
|
super
|
|
end
|
|
end,
|
|
)
|