discourse/spec/lib/promotion_spec.rb
Juan David Martínez Cubillos 789aa2d9de
DEV: Add PluginRegistry modifiers to #review and #recalculate (#29128)
* DEV: Add PluginRegistry modifiers to #review and #recalculate

* added tests

* changed added registry logic
2024-10-16 10:26:10 -05:00

323 lines
11 KiB
Ruby

# frozen_string_literal: true
require "promotion"
RSpec.describe Promotion do
describe "review" do
it "skips regular users" do
# Reviewing users at higher trust levels is expensive, so trigger those reviews in a background job.
regular = Fabricate.build(:user, trust_level: TrustLevel[2])
promotion = described_class.new(regular)
promotion.expects(:review_tl2).never
promotion.review
end
end
describe "newuser" do
fab!(:user) { Fabricate(:user, trust_level: TrustLevel[0], created_at: 2.days.ago) }
let(:promotion) { Promotion.new(user) }
let!(:plugin) { Plugin::Instance.new }
let!(:review_modifier) { :review_trust_level }
let!(:recalculate_modifier) { :recalculate_trust_level }
let!(:deny_block) { Proc.new { false } }
let!(:allow_block) { Proc.new { true } }
it "doesn't raise an error with a nil user" do
expect { Promotion.new(nil).review }.not_to raise_error
end
context "when user has done nothing" do
let!(:result) { promotion.review }
it "returns false" do
expect(result).to eq(false)
end
it "has not changed the user's trust level" do
expect(user.trust_level).to eq(TrustLevel[0])
end
end
context "when user has done the requisite things" do
before do
stat = user.user_stat
stat.topics_entered = SiteSetting.tl1_requires_topics_entered
stat.posts_read_count = SiteSetting.tl1_requires_read_posts
stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
@result = promotion.review
end
it "returns true" do
expect(@result).to eq(true)
end
it "has upgraded the user to basic" do
expect(user.trust_level).to eq(TrustLevel[1])
end
it "allows plugins to control promotion #review" do
DiscoursePluginRegistry.register_modifier(plugin, :review_trust_level, &deny_block)
action = Promotion.new(user).review
expect(action).to eq(false)
DiscoursePluginRegistry.register_modifier(plugin, review_modifier, &allow_block)
action = Promotion.new(user).review
expect(action).to eq(true)
ensure
DiscoursePluginRegistry.unregister_modifier(plugin, review_modifier, &deny_block)
DiscoursePluginRegistry.unregister_modifier(plugin, review_modifier, &allow_block)
end
it "allows plugins to control promotion #recalculate" do
DiscoursePluginRegistry.register_modifier(plugin, recalculate_modifier, &deny_block)
action = Promotion.recalculate(user)
expect(action).to eq(nil)
DiscoursePluginRegistry.register_modifier(plugin, recalculate_modifier, &allow_block)
action = Promotion.recalculate(user)
expect(action).to eq(true)
ensure
DiscoursePluginRegistry.unregister_modifier(plugin, recalculate_modifier, &deny_block)
DiscoursePluginRegistry.unregister_modifier(plugin, recalculate_modifier, &allow_block)
end
end
context "when user has not done the requisite things" do
it "does not promote the user" do
user.created_at = 1.minute.ago
stat = user.user_stat
stat.topics_entered = SiteSetting.tl1_requires_topics_entered
stat.posts_read_count = SiteSetting.tl1_requires_read_posts
stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
@result = promotion.review
expect(@result).to eq(false)
expect(user.trust_level).to eq(TrustLevel[0])
end
end
context "when may send tl1 promotion messages" do
before do
stat = user.user_stat
stat.topics_entered = SiteSetting.tl1_requires_topics_entered
stat.posts_read_count = SiteSetting.tl1_requires_read_posts
stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
end
it "sends promotion message by default" do
SiteSetting.send_tl1_welcome_message = true
@result = promotion.review
expect(Jobs::SendSystemMessage.jobs.length).to eq(1)
job = Jobs::SendSystemMessage.jobs[0]
expect(job["args"][0]["user_id"]).to eq(user.id)
expect(job["args"][0]["message_type"]).to eq("welcome_tl1_user")
end
it "does not not send when the user already has the tl1 badge when recalculating" do
SiteSetting.send_tl1_welcome_message = true
BadgeGranter.grant(Badge.find(1), user)
stat = user.user_stat
stat.topics_entered = SiteSetting.tl1_requires_topics_entered
stat.posts_read_count = SiteSetting.tl1_requires_read_posts
stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
Promotion.recalculate(user)
expect(Jobs::SendSystemMessage.jobs.length).to eq(0)
end
it "does not not send when the tl1 badge is disabled" do
SiteSetting.send_tl1_welcome_message = true
Badge.find(1).update!(enabled: false)
stat = user.user_stat
stat.topics_entered = SiteSetting.tl1_requires_topics_entered
stat.posts_read_count = SiteSetting.tl1_requires_read_posts
stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
Promotion.recalculate(user)
expect(user.trust_level).to eq(1)
expect(Jobs::SendSystemMessage.jobs.length).to eq(0)
end
it "respects default trust level" do
SiteSetting.default_trust_level = 2
Promotion.recalculate(user)
expect(user.trust_level).to eq(2)
end
it "can be turned off" do
SiteSetting.send_tl1_welcome_message = false
@result = promotion.review
expect(Jobs::SendSystemMessage.jobs.length).to eq(0)
end
end
context "when may send tl2 promotion messages" do
fab!(:user) do
Fabricate(
:user,
trust_level: TrustLevel[1],
created_at: (SiteSetting.tl2_requires_time_spent_mins * 60).minutes.ago,
)
end
before do
stat = user.user_stat
stat.topics_entered = SiteSetting.tl2_requires_topics_entered
stat.posts_read_count = SiteSetting.tl2_requires_read_posts
stat.time_read = SiteSetting.tl2_requires_time_spent_mins * 60
stat.days_visited = SiteSetting.tl2_requires_days_visited
stat.likes_received = SiteSetting.tl2_requires_likes_received
stat.likes_given = SiteSetting.tl2_requires_likes_given
SiteSetting.tl2_requires_topic_reply_count = 0
SiteSetting.send_tl2_promotion_message = true
end
it "sends promotion message by default" do
expect_enqueued_with(
job: :send_system_message,
args: {
user_id: user.id,
message_type: "tl2_promotion_message",
},
) { @result = promotion.review }
end
it "can be turned off" do
SiteSetting.send_tl2_promotion_message = false
expect_not_enqueued_with(job: :send_system_message) { @result = promotion.review }
end
end
end
describe "basic" do
fab!(:user) { Fabricate(:user, trust_level: TrustLevel[1], created_at: 2.days.ago) }
let(:promotion) { Promotion.new(user) }
context "when has done nothing" do
let!(:result) { promotion.review }
it "returns false" do
expect(result).to eq(false)
end
it "has not changed the user's trust level" do
expect(user.trust_level).to eq(TrustLevel[1])
end
end
context "when has done the requisite things" do
before do
SiteSetting.tl2_requires_topic_reply_count = 3
stat = user.user_stat
stat.topics_entered = SiteSetting.tl2_requires_topics_entered
stat.posts_read_count = SiteSetting.tl2_requires_read_posts
stat.time_read = SiteSetting.tl2_requires_time_spent_mins * 60
stat.days_visited = SiteSetting.tl2_requires_days_visited * 60
stat.likes_received = SiteSetting.tl2_requires_likes_received
stat.likes_given = SiteSetting.tl2_requires_likes_given
SiteSetting.tl2_requires_topic_reply_count.times do |_|
topic = Fabricate(:topic)
reply = Fabricate(:post, topic: topic, user: user, post_number: 2)
end
@result = promotion.review
end
it "returns true" do
expect(@result).to eq(true)
end
it "has upgraded the user to regular" do
expect(user.trust_level).to eq(TrustLevel[2])
end
end
context "when the account hasn't existed long enough" do
it "does not promote the user" do
user.created_at = 1.minute.ago
SiteSetting.tl2_requires_topic_reply_count = 3
stat = user.user_stat
stat.topics_entered = SiteSetting.tl2_requires_topics_entered
stat.posts_read_count = SiteSetting.tl2_requires_read_posts
stat.time_read = SiteSetting.tl2_requires_time_spent_mins * 60
stat.days_visited = SiteSetting.tl2_requires_days_visited * 60
stat.likes_received = SiteSetting.tl2_requires_likes_received
stat.likes_given = SiteSetting.tl2_requires_likes_given
SiteSetting.tl2_requires_topic_reply_count.times do |_|
topic = Fabricate(:topic)
reply = Fabricate(:post, topic: topic, user: user, post_number: 2)
end
result = promotion.review
expect(result).to eq(false)
expect(user.trust_level).to eq(TrustLevel[1])
end
end
end
describe "regular" do
fab!(:user) { Fabricate(:user, trust_level: TrustLevel[2]) }
let(:promotion) { Promotion.new(user) }
context "when doesn't qualify for promotion" do
before do
TrustLevel3Requirements
.any_instance
.expects(:requirements_met?)
.at_least_once
.returns(false)
end
it "review_tl2 returns false" do
expect { expect(promotion.review_tl2).to eq(false) }.to_not change {
user.reload.trust_level
}
end
it "doesn't promote" do
expect { promotion.review_tl2 }.to_not change { user.reload.trust_level }
end
it "doesn't log a trust level change" do
expect { promotion.review_tl2 }.to_not change { UserHistory.count }
end
end
context "when qualifies for promotion" do
before do
TrustLevel3Requirements.any_instance.expects(:requirements_met?).at_least_once.returns(true)
end
it "review_tl2 returns true" do
expect(promotion.review_tl2).to eq(true)
end
it "promotes to tl3" do
expect(promotion.review_tl2).to eq(true)
expect(user.reload.trust_level).to eq(TrustLevel[3])
end
it "logs a trust level change" do
expect { promotion.review_tl2 }.to change {
UserHistory.where(action: UserHistory.actions[:auto_trust_level_change]).count
}.by(1)
end
end
end
describe "#change_trust_level!" do
fab!(:user) { Fabricate(:user, trust_level: TrustLevel[0]) }
let(:promotion) { Promotion.new(user) }
context "when the user has no emails" do
before { user.user_emails.delete_all }
it "does not error" do
expect { promotion.change_trust_level!(TrustLevel[1]) }.not_to raise_error
expect(user.reload.trust_level).to eq(TrustLevel[1])
end
end
end
end