mirror of
https://github.com/discourse/discourse.git
synced 2024-12-01 09:44:22 +08:00
fd39753e58
We recently tried to default the normalize_emails site setting to true to avoid spam. What this does is it considers e-mails the same regardless of plus addressing, e.g. bob+1@mail.com == bob+2@mail.com. This caused some problems for SSO users. This PR makes it so that DiscourseConnect never normalizes e-mails.
109 lines
2.8 KiB
Ruby
109 lines
2.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
class UserEmail < ActiveRecord::Base
|
|
belongs_to :user
|
|
|
|
attr_accessor :skip_validate_email
|
|
attr_accessor :skip_validate_unique_email
|
|
attr_accessor :skip_normalize_email
|
|
|
|
before_validation :strip_downcase_email
|
|
before_validation :normalize_email
|
|
|
|
validates :email, presence: true
|
|
validates :email, email: true, if: :validate_email?
|
|
|
|
validates :primary, uniqueness: { scope: [:user_id] }, if: %i[user_id primary]
|
|
validate :user_id_not_changed, if: :primary
|
|
validate :unique_email, if: :validate_unique_email?
|
|
|
|
scope :secondary, -> { where(primary: false) }
|
|
|
|
before_save -> { destroy_email_tokens(self.email_was) }, if: :will_save_change_to_email?
|
|
|
|
after_destroy { destroy_email_tokens(self.email) }
|
|
|
|
def normalize_email
|
|
self.normalized_email =
|
|
if self.email.present?
|
|
username, domain = self.email.split("@", 2)
|
|
username = username.gsub(".", "").gsub(/\+.*/, "")
|
|
"#{username}@#{domain}"
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def strip_downcase_email
|
|
if self.email
|
|
self.email = self.email.strip
|
|
self.email = self.email.downcase
|
|
end
|
|
end
|
|
|
|
def validate_email?
|
|
return false if self.skip_validate_email
|
|
email_changed?
|
|
end
|
|
|
|
def validate_unique_email?
|
|
return false if self.skip_validate_unique_email
|
|
will_save_change_to_email?
|
|
end
|
|
|
|
def normalize_emails?
|
|
return false if self.skip_normalize_email
|
|
|
|
SiteSetting.normalize_emails?
|
|
end
|
|
|
|
def unique_email
|
|
email_exists =
|
|
if self.normalize_emails?
|
|
self
|
|
.class
|
|
.where("lower(email) = ? OR lower(normalized_email) = ?", email, normalized_email)
|
|
.exists?
|
|
else
|
|
self.class.where("lower(email) = ?", email).exists?
|
|
end
|
|
|
|
self.errors.add(:email, :taken) if email_exists
|
|
end
|
|
|
|
def user_id_not_changed
|
|
if self.will_save_change_to_user_id? && self.persisted?
|
|
self.errors.add(
|
|
:user_id,
|
|
I18n.t(
|
|
"activerecord.errors.models.user_email.attributes.user_id.reassigning_primary_email",
|
|
),
|
|
)
|
|
end
|
|
end
|
|
|
|
def destroy_email_tokens(email)
|
|
EmailToken.where(email: email).destroy_all
|
|
end
|
|
end
|
|
|
|
# == Schema Information
|
|
#
|
|
# Table name: user_emails
|
|
#
|
|
# id :integer not null, primary key
|
|
# user_id :integer not null
|
|
# email :string(513) not null
|
|
# primary :boolean default(FALSE), not null
|
|
# created_at :datetime not null
|
|
# updated_at :datetime not null
|
|
# normalized_email :string
|
|
#
|
|
# Indexes
|
|
#
|
|
# index_user_emails_on_email (lower((email)::text)) UNIQUE
|
|
# index_user_emails_on_normalized_email (lower((normalized_email)::text))
|
|
# index_user_emails_on_user_id (user_id)
|
|
# index_user_emails_on_user_id_and_primary (user_id,primary) UNIQUE WHERE "primary"
|
|
#
|