mirror of
https://github.com/discourse/discourse.git
synced 2024-11-28 02:15:08 +08:00
b27d5626d2
* SECURITY: Prevent arbitrary file write when decompressing files * FIX: Allow decompressing files into symlinked directories Co-authored-by: OsamaSayegh <asooomaasoooma90@gmail.com> Co-authored-by: Gerhard Schlager <gerhard.schlager@discourse.org>
71 lines
1.7 KiB
Ruby
71 lines
1.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'compression/engine'
|
|
|
|
module ThemeStore; end
|
|
|
|
class ThemeStore::ZipImporter
|
|
|
|
attr_reader :url
|
|
|
|
def initialize(filename, original_filename)
|
|
@temp_folder = "#{Pathname.new(Dir.tmpdir).realpath}/discourse_theme_#{SecureRandom.hex}"
|
|
@filename = filename
|
|
@original_filename = original_filename
|
|
end
|
|
|
|
def import!
|
|
FileUtils.mkdir(@temp_folder)
|
|
|
|
available_size = SiteSetting.decompressed_theme_max_file_size_mb
|
|
Compression::Engine.engine_for(@original_filename).tap do |engine|
|
|
engine.decompress(@temp_folder, @filename, available_size)
|
|
strip_root_directory
|
|
end
|
|
rescue RuntimeError
|
|
raise RemoteTheme::ImportError, I18n.t("themes.import_error.unpack_failed")
|
|
rescue Compression::Zip::ExtractFailed
|
|
raise RemoteTheme::ImportError, I18n.t("themes.import_error.file_too_big")
|
|
end
|
|
|
|
def cleanup!
|
|
FileUtils.rm_rf(@temp_folder)
|
|
end
|
|
|
|
def version
|
|
""
|
|
end
|
|
|
|
def strip_root_directory
|
|
root_files = Dir.glob("#{@temp_folder}/*")
|
|
if root_files.size == 1 && File.directory?(root_files[0])
|
|
FileUtils.mv(Dir.glob("#{@temp_folder}/*/*"), @temp_folder)
|
|
end
|
|
end
|
|
|
|
def real_path(relative)
|
|
fullpath = "#{@temp_folder}/#{relative}"
|
|
return nil unless File.exist?(fullpath)
|
|
|
|
# careful to handle symlinks here, don't want to expose random data
|
|
fullpath = Pathname.new(fullpath).realpath.to_s
|
|
|
|
if fullpath && fullpath.start_with?(@temp_folder)
|
|
fullpath
|
|
else
|
|
nil
|
|
end
|
|
end
|
|
|
|
def all_files
|
|
Dir.glob("**/**", base: @temp_folder).reject { |f| File.directory?(File.join(@temp_folder, f)) }
|
|
end
|
|
|
|
def [](value)
|
|
fullpath = real_path(value)
|
|
return nil unless fullpath
|
|
File.read(fullpath)
|
|
end
|
|
|
|
end
|