mirror of
https://github.com/discourse/discourse.git
synced 2024-12-21 17:56:28 +08:00
acc87202b9
This commit is going to try using the `have_read_post` page object from `topic_view` instead of the page object for `topic` because it's implementation has a longer wait time as it uses the ENV variable for wait time: `Capybara.default_max_wait_time * 2`. If this works out we should probably remove the duplicated `have_read_post` page object so that we have a single implementation.
375 lines
13 KiB
Ruby
375 lines
13 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe "Topic bulk select", type: :system do
|
|
fab!(:topics) { Fabricate.times(10, :post).map(&:topic) }
|
|
fab!(:admin)
|
|
fab!(:user)
|
|
|
|
let(:topic_list_header) { PageObjects::Components::TopicListHeader.new }
|
|
let(:topic_list) { PageObjects::Components::TopicList.new }
|
|
let(:topic_page) { PageObjects::Pages::Topic.new }
|
|
let(:topic_bulk_actions_modal) { PageObjects::Modals::TopicBulkActions.new }
|
|
let(:topic_view) { PageObjects::Components::TopicView.new }
|
|
|
|
def open_bulk_actions_modal(topics_to_select = nil, action)
|
|
topic_list_header.click_bulk_select_button
|
|
|
|
if !topics_to_select
|
|
topic_list.click_topic_checkbox(topics.last)
|
|
else
|
|
topics_to_select.each { |topic| topic_list.click_topic_checkbox(topic) }
|
|
end
|
|
|
|
topic_list_header.click_bulk_select_topics_dropdown
|
|
topic_list_header.click_bulk_button(action)
|
|
expect(topic_bulk_actions_modal).to be_open
|
|
end
|
|
|
|
context "when dismissing unread topics" do
|
|
fab!(:topic) { Fabricate(:topic, user: admin) }
|
|
fab!(:post1) { create_post(user: admin, topic: topic) }
|
|
fab!(:post2) { create_post(topic: topic) }
|
|
|
|
it "removes the topics from the list" do
|
|
sign_in(admin)
|
|
visit("/unread")
|
|
|
|
topic_list_header.click_bulk_select_button
|
|
expect(topic_list).to have_topic_checkbox(topic)
|
|
|
|
topic_list.click_topic_checkbox(topic)
|
|
|
|
topic_list_header.click_bulk_select_topics_dropdown
|
|
topic_list_header.click_bulk_button("dismiss-unread")
|
|
|
|
topic_bulk_actions_modal.click_dismiss_confirm
|
|
|
|
expect(page).to have_text(I18n.t("js.topics.none.unread"))
|
|
end
|
|
end
|
|
|
|
context "when dismissing new topics" do
|
|
fab!(:topic) { Fabricate(:topic, user: user) }
|
|
fab!(:post1) { create_post(user: user, topic: topic) }
|
|
|
|
it "removes the topics from the list" do
|
|
sign_in(admin)
|
|
visit("/new")
|
|
|
|
topic_list_header.click_bulk_select_button
|
|
expect(topic_list).to have_topic_checkbox(topic)
|
|
|
|
topic_list.click_topic_checkbox(topic)
|
|
|
|
topic_list_header.click_bulk_select_topics_dropdown
|
|
topic_list_header.click_bulk_button("dismiss-new")
|
|
|
|
topic_bulk_actions_modal.click_dismiss_confirm
|
|
|
|
expect(page).to have_text(I18n.t("js.topics.none.new"))
|
|
end
|
|
end
|
|
|
|
context "when appending tags" do
|
|
fab!(:tag1) { Fabricate(:tag) }
|
|
fab!(:tag2) { Fabricate(:tag) }
|
|
fab!(:tag3) { Fabricate(:tag) }
|
|
|
|
before { SiteSetting.tagging_enabled = true }
|
|
|
|
def open_append_modal(topics_to_select = nil)
|
|
sign_in(admin)
|
|
visit("/latest")
|
|
|
|
open_bulk_actions_modal(topics_to_select, "append-tags")
|
|
end
|
|
|
|
context "when in mobile", mobile: true do
|
|
it "is working" do
|
|
# behavior is already tested on desktop, we simply ensure
|
|
# the general workflow is working on mobile
|
|
open_append_modal
|
|
end
|
|
end
|
|
|
|
it "appends tags to selected topics" do
|
|
open_append_modal
|
|
|
|
topic_bulk_actions_modal.tag_selector.expand
|
|
topic_bulk_actions_modal.tag_selector.search(tag1.name)
|
|
topic_bulk_actions_modal.tag_selector.select_row_by_value(tag1.name)
|
|
topic_bulk_actions_modal.tag_selector.search(tag2.name)
|
|
topic_bulk_actions_modal.tag_selector.select_row_by_value(tag2.name)
|
|
|
|
topic_bulk_actions_modal.click_bulk_topics_confirm
|
|
|
|
expect(
|
|
find(topic_list.topic_list_item_class(topics.last)).find(".discourse-tags"),
|
|
).to have_content(tag1.name)
|
|
expect(
|
|
find(topic_list.topic_list_item_class(topics.last)).find(".discourse-tags"),
|
|
).to have_content(tag2.name)
|
|
end
|
|
|
|
context "when selecting topics in different categories" do
|
|
before do
|
|
topics
|
|
.last(2)
|
|
.each do |topic|
|
|
topic.update!(category: Fabricate(:category))
|
|
topic.update!(category: Fabricate(:category))
|
|
end
|
|
end
|
|
|
|
it "does not show an additional note about the category in the modal" do
|
|
open_append_modal(topics.last(2))
|
|
|
|
expect(topic_bulk_actions_modal).to have_no_category_badge(topics.last.reload.category)
|
|
end
|
|
end
|
|
|
|
context "when selecting topics that are all in the same category" do
|
|
fab!(:category)
|
|
|
|
before { topics.last.update!(category_id: category.id) }
|
|
|
|
it "shows an additional note about the category in the modal" do
|
|
open_append_modal
|
|
expect(topic_bulk_actions_modal).to have_category_badge(category)
|
|
end
|
|
|
|
it "allows for searching restricted tags for that category and other tags too if the category allows it" do
|
|
restricted_tag_group = Fabricate(:tag_group)
|
|
restricted_tag = Fabricate(:tag)
|
|
TagGroupMembership.create!(tag: restricted_tag, tag_group: restricted_tag_group)
|
|
CategoryTagGroup.create!(category: category, tag_group: restricted_tag_group)
|
|
category.update!(allow_global_tags: true)
|
|
|
|
open_append_modal
|
|
|
|
topic_bulk_actions_modal.tag_selector.expand
|
|
topic_bulk_actions_modal.tag_selector.search(restricted_tag.name)
|
|
topic_bulk_actions_modal.tag_selector.select_row_by_value(restricted_tag.name)
|
|
topic_bulk_actions_modal.tag_selector.search(tag1.name)
|
|
topic_bulk_actions_modal.tag_selector.select_row_by_value(tag1.name)
|
|
|
|
topic_bulk_actions_modal.click_bulk_topics_confirm
|
|
|
|
expect(
|
|
find(topic_list.topic_list_item_class(topics.last)).find(".discourse-tags"),
|
|
).to have_content(restricted_tag.name)
|
|
expect(
|
|
find(topic_list.topic_list_item_class(topics.last)).find(".discourse-tags"),
|
|
).to have_content(tag1.name)
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when closing" do
|
|
it "closes multiple topics" do
|
|
sign_in(admin)
|
|
visit("/latest")
|
|
|
|
# Click bulk select button
|
|
topic_list_header.click_bulk_select_button
|
|
expect(topic_list).to have_topic_checkbox(topics.first)
|
|
|
|
# Select Topics
|
|
topic_list.click_topic_checkbox(topics.first)
|
|
topic_list.click_topic_checkbox(topics.second)
|
|
|
|
# Has Dropdown
|
|
expect(topic_list_header).to have_bulk_select_topics_dropdown
|
|
topic_list_header.click_bulk_select_topics_dropdown
|
|
|
|
# Clicking the close button opens up the modal
|
|
topic_list_header.click_bulk_button("close-topics")
|
|
expect(topic_bulk_actions_modal).to be_open
|
|
|
|
# Closes the selected topics
|
|
topic_bulk_actions_modal.click_bulk_topics_confirm
|
|
expect(topic_list).to have_closed_status(topics.first)
|
|
end
|
|
|
|
it "closes single topic" do
|
|
# Watch the topic as a user
|
|
sign_in(user)
|
|
visit("/latest")
|
|
topic = topics.third
|
|
visit("/t/#{topic.slug}/#{topic.id}")
|
|
topic_page.watch_topic
|
|
expect(topic_page).to have_read_post(1)
|
|
|
|
# Bulk close the topic as an admin
|
|
sign_in(admin)
|
|
visit("/latest")
|
|
topic_list_header.click_bulk_select_button
|
|
topic_list.click_topic_checkbox(topics.third)
|
|
topic_list_header.click_bulk_select_topics_dropdown
|
|
topic_list_header.click_bulk_button("close-topics")
|
|
topic_bulk_actions_modal.click_bulk_topics_confirm
|
|
|
|
# Check that the user did receive a new post notification badge
|
|
sign_in(user)
|
|
visit("/latest")
|
|
expect(topic_list).to have_unread_badge(topics.third)
|
|
end
|
|
|
|
it "closes topics silently" do
|
|
# Watch the topic as a user
|
|
sign_in(user)
|
|
topic = topics.first
|
|
visit("/t/#{topic.slug}/#{topic.id}")
|
|
expect(topic_view).to have_read_post(topic.posts.first)
|
|
topic_page.watch_topic
|
|
|
|
# Bulk close the topic as an admin
|
|
sign_in(admin)
|
|
visit("/latest")
|
|
topic_list_header.click_bulk_select_button
|
|
topic_list.click_topic_checkbox(topics.first)
|
|
topic_list_header.click_bulk_select_topics_dropdown
|
|
topic_list_header.click_bulk_button("close-topics")
|
|
topic_bulk_actions_modal.click_silent # Check Silent
|
|
topic_bulk_actions_modal.click_bulk_topics_confirm
|
|
|
|
# Check that the user didn't receive a new post notification badge
|
|
sign_in(user)
|
|
visit("/latest")
|
|
expect(topic_list).to have_no_unread_badge(topics.first)
|
|
end
|
|
|
|
it "closes topics with message" do
|
|
# Bulk close the topic with a message
|
|
sign_in(admin)
|
|
visit("/latest")
|
|
topic = topics.first
|
|
topic_list_header.click_bulk_select_button
|
|
topic_list.click_topic_checkbox(topics.first)
|
|
topic_list_header.click_bulk_select_topics_dropdown
|
|
topic_list_header.click_bulk_button("close-topics")
|
|
|
|
# Fill in message
|
|
topic_bulk_actions_modal.fill_in_close_note("None of these are useful")
|
|
topic_bulk_actions_modal.click_bulk_topics_confirm
|
|
|
|
# Check that the topic now has the message
|
|
visit("/t/#{topic.slug}/#{topic.id}")
|
|
expect(topic_page).to have_content("None of these are useful")
|
|
end
|
|
|
|
it "works with keyboard shortcuts" do
|
|
sign_in(admin)
|
|
visit("/latest")
|
|
|
|
send_keys([:shift, "b"])
|
|
send_keys("j")
|
|
send_keys("x") # toggle select
|
|
expect(topic_list).to have_checkbox_selected_on_row(1)
|
|
|
|
send_keys("x") # toggle deselect
|
|
expect(topic_list).to have_no_checkbox_selected_on_row(1)
|
|
|
|
# watch topic and add a reply so we have something in /unread
|
|
topic = topics.first
|
|
visit("/t/#{topic.slug}/#{topic.id}")
|
|
topic_page.watch_topic
|
|
expect(topic_page).to have_read_post(1)
|
|
Fabricate(:post, topic: topic)
|
|
|
|
visit("/unread")
|
|
expect(topic_list).to have_topics
|
|
|
|
send_keys([:shift, "b"])
|
|
send_keys("j")
|
|
send_keys("x")
|
|
send_keys([:shift, "d"])
|
|
|
|
click_button("dismiss-read-confirm")
|
|
|
|
expect(topic_list).to have_no_topics
|
|
end
|
|
end
|
|
|
|
context "when working with private messages" do
|
|
fab!(:private_message_1) do
|
|
Fabricate(:private_message_topic, user: admin, recipient: user, participant_count: 2)
|
|
end
|
|
fab!(:private_message_post_1) { Fabricate(:post, topic: private_message_1, user: admin) }
|
|
fab!(:private_message_post_2) { Fabricate(:post, topic: private_message_1, user: user) }
|
|
fab!(:group)
|
|
fab!(:group_private_message) do
|
|
Fabricate(:group_private_message_topic, user: admin, recipient_group: group)
|
|
end
|
|
|
|
before do
|
|
TopicUser.change(
|
|
admin.id,
|
|
private_message_1,
|
|
notification_level: TopicUser.notification_levels[:tracking],
|
|
)
|
|
TopicUser.update_last_read(admin, private_message_1.id, 1, 1, 1)
|
|
GroupUser.create!(user: admin, group: group)
|
|
end
|
|
|
|
it "allows moving private messages to the Archive" do
|
|
sign_in(admin)
|
|
visit("/u/#{admin.username}/messages")
|
|
expect(page).to have_content(private_message_1.title)
|
|
open_bulk_actions_modal([private_message_1], "archive-messages")
|
|
topic_bulk_actions_modal.click_bulk_topics_confirm
|
|
expect(page).to have_content(I18n.t("js.topics.bulk.completed"))
|
|
visit("/u/#{admin.username}/messages/archive")
|
|
expect(page).to have_content(private_message_1.title)
|
|
expect(UserArchivedMessage.exists?(user_id: admin.id, topic_id: private_message_1.id)).to eq(
|
|
true,
|
|
)
|
|
end
|
|
|
|
it "allows moving private messages to the Inbox" do
|
|
UserArchivedMessage.create!(user: admin, topic: private_message_1)
|
|
sign_in(admin)
|
|
visit("/u/#{admin.username}/messages/archive")
|
|
expect(page).to have_content(private_message_1.title)
|
|
open_bulk_actions_modal([private_message_1], "move-messages-to-inbox")
|
|
topic_bulk_actions_modal.click_bulk_topics_confirm
|
|
expect(page).to have_content(I18n.t("js.topics.bulk.completed"))
|
|
visit("/u/#{admin.username}/messages")
|
|
expect(page).to have_content(private_message_1.title)
|
|
end
|
|
|
|
it "allows moving group private messages to the scoped group Archive" do
|
|
sign_in(admin)
|
|
visit("/u/#{admin.username}/messages/group/#{group.name}")
|
|
expect(page).to have_content(group_private_message.title)
|
|
open_bulk_actions_modal([group_private_message], "archive-messages")
|
|
topic_bulk_actions_modal.click_bulk_topics_confirm
|
|
expect(page).to have_content(I18n.t("js.topics.bulk.completed"))
|
|
visit("/u/#{admin.username}/messages/group/#{group.name}/archive")
|
|
expect(page).to have_content(group_private_message.title)
|
|
end
|
|
|
|
it "allows moving group private messages to the scoped group Inbox" do
|
|
GroupArchivedMessage.create!(group: group, topic: group_private_message)
|
|
sign_in(admin)
|
|
visit("/u/#{admin.username}/messages/group/#{group.name}/archive")
|
|
expect(page).to have_content(group_private_message.title)
|
|
open_bulk_actions_modal([group_private_message], "move-messages-to-inbox")
|
|
topic_bulk_actions_modal.click_bulk_topics_confirm
|
|
expect(page).to have_content(I18n.t("js.topics.bulk.completed"))
|
|
visit("/u/#{admin.username}/messages/group/#{group.name}")
|
|
expect(page).to have_content(group_private_message.title)
|
|
end
|
|
|
|
context "when in mobile" do
|
|
it "is working", mobile: true do
|
|
# behavior is already tested on desktop, we simply ensure
|
|
# the general workflow is working on mobile
|
|
sign_in(admin)
|
|
visit("/u/#{admin.username}/messages")
|
|
open_bulk_actions_modal([private_message_1], "archive-messages")
|
|
end
|
|
end
|
|
end
|
|
end
|