mirror of
https://github.com/discourse/discourse.git
synced 2024-11-23 06:49:14 +08:00
0d1d707213
What is the problem? When an admin changes the default_sidebar_categories or default_sidebar_tags site settings and opts to backfill the setting, we currently enqueue a sidekiq job to run the backfilling operation. When an admin changes those settings multiple times within a short time frame, multiple sidekiq jobs with different backfilling parameters will be enqueued. This is problematic if multiple jobs are executed concurrently as it may lead to situations where a job with “outdated” site setting values is completed after a job with the “latest” site setting values. What is the fix? By setting `cluster_concurrency` to `1`, we ensure that only one of such backfilling job will execute across all the sidekiq processes that are deployed at any point in time. Since Sidekiq pops off job in the order in which they are pushed, limiting the cluster concurrency here will allow us to execute the enqueued `Jobs::BackfillSidebarSiteSettings` jobs serially.
8 lines
221 B
Ruby
8 lines
221 B
Ruby
# frozen_string_literal: true
|
|
|
|
RSpec.describe Jobs::BackfillSidebarSiteSettings do
|
|
it "should have a cluster concurrency of 1" do
|
|
expect(Jobs::BackfillSidebarSiteSettings.get_cluster_concurrency).to eq(1)
|
|
end
|
|
end
|