discourse/spec/components/discourse_updates_spec.rb

require 'rails_helper'
require_dependency 'discourse_updates'

describe DiscourseUpdates do

  def stub_data(latest, missing, critical, updated_at)
    DiscourseUpdates.stubs(:latest_version).returns(latest)
    DiscourseUpdates.stubs(:missing_versions_count).returns(missing)
    DiscourseUpdates.stubs(:critical_updates_available?).returns(critical)
    DiscourseUpdates.stubs(:updated_at).returns(updated_at)
  end

  before do
    Jobs::VersionCheck.any_instance.stubs(:execute).returns(true)
  end

  subject { DiscourseUpdates.check_version.instance_values }

  context 'version check was done at the current installed version' do
    before do
      DiscourseUpdates.stubs(:last_installed_version).returns(Discourse::VERSION::STRING)
    end

    context 'a good version check request happened recently' do
      context 'and server is up-to-date' do
        before { stub_data(Discourse::VERSION::STRING, 0, false, 12.hours.ago) }

        it 'returns all the version fields' do
          expect(subject['latest_version']).to eq(Discourse::VERSION::STRING)
          expect(subject['missing_versions_count']).to eq(0)
          expect(subject['critical_updates']).to eq(false)
          expect(subject['installed_version']).to eq(Discourse::VERSION::STRING)
        end

        it 'returns the timestamp of the last version check' do
          expect(subject['updated_at']).to be_within_one_second_of(12.hours.ago)
        end
      end

      context 'and server is not up-to-date' do
        before { stub_data('0.9.0', 2, false, 12.hours.ago) }

        it 'returns all the version fields' do
          expect(subject['latest_version']).to eq('0.9.0')
          expect(subject['missing_versions_count']).to eq(2)
          expect(subject['critical_updates']).to eq(false)
          expect(subject['installed_version']).to eq(Discourse::VERSION::STRING)
        end

        it 'returns the timestamp of the last version check' do
          expect(subject['updated_at']).to be_within_one_second_of(12.hours.ago)
        end
      end
    end

    context 'a version check has never been performed' do
      before { stub_data(nil, nil, false, nil) }

      it 'returns the installed version' do
        expect(subject['installed_version']).to eq(Discourse::VERSION::STRING)
      end

      it 'indicates that version check has not been performed' do
        expect(subject).to have_key('updated_at')
        expect(subject['updated_at']).to eq(nil)
      end

      it 'does not return latest version info' do
        expect(subject).not_to have_key('latest_version')
        expect(subject).not_to have_key('missing_versions_count')
        expect(subject).not_to have_key('critical_updates')
      end

      it 'queues a version check' do
        Jobs.expects(:enqueue).with(:version_check, anything)
        subject
      end
    end

    # These cases should never happen anymore, but keep the specs to be sure
    # they're handled in a sane way.
    context 'old version check data' do
      shared_examples "queue version check and report that version is ok" do
        it 'queues a version check' do
          Jobs.expects(:enqueue).with(:version_check, anything)
          subject
        end

        it 'reports 0 missing versions' do
          expect(subject['missing_versions_count']).to eq(0)
        end

        it 'reports that a version check will be run soon' do
          expect(subject['version_check_pending']).to eq(true)
        end
      end

      context 'installed is latest' do
        before { stub_data(Discourse::VERSION::STRING, 1, false, 8.hours.ago) }
        include_examples "queue version check and report that version is ok"
      end

      context 'installed does not match latest version, but missing_versions_count is 0' do
        before { stub_data('0.10.10.123', 0, false, 8.hours.ago) }
        include_examples "queue version check and report that version is ok"
      end
    end
  end

  context 'version check was done at a different installed version' do
    before do
      DiscourseUpdates.stubs(:last_installed_version).returns('0.9.1')
    end

    shared_examples "when last_installed_version is old" do
      it 'queues a version check' do
        Jobs.expects(:enqueue).with(:version_check, anything)
        subject
      end

      it 'reports 0 missing versions' do
        expect(subject['missing_versions_count']).to eq(0)
      end

      it 'reports that a version check will be run soon' do
        expect(subject['version_check_pending']).to eq(true)
      end
    end

    context 'missing_versions_count is 0' do
      before { stub_data('0.9.7', 0, false, 8.hours.ago) }
      include_examples "when last_installed_version is old"
    end

    context 'missing_versions_count is not 0' do
      before { stub_data('0.9.7', 1, false, 8.hours.ago) }
      include_examples "when last_installed_version is old"
    end
  end
end