mirror of
https://github.com/discourse/discourse.git
synced 2024-12-21 15:53:45 +08:00
619f132f57
Fixes a flaky test. `afterUpdate` from chart.js is not integrated with the runloop and component lifecycle, as a result we have no guarantee on when it will happen. The easiest change we can do for now is ensuring we actually have the DOM we expect to have, and if not, we exit early. Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com> Co-authored-by: merefield <merefield@gmail.com>
164 lines
5.0 KiB
JavaScript
164 lines
5.0 KiB
JavaScript
import { render } from "@ember/test-helpers";
|
|
import hbs from "htmlbars-inline-precompile";
|
|
import { module, test } from "qunit";
|
|
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
|
|
import { exists, queryAll } from "discourse/tests/helpers/qunit-helpers";
|
|
|
|
const TWO_OPTIONS = [
|
|
{ id: "1ddc47be0d2315b9711ee8526ca9d83f", html: "This", votes: 5, rank: 0 },
|
|
{ id: "70e743697dac09483d7b824eaadb91e1", html: "That", votes: 4, rank: 0 },
|
|
];
|
|
|
|
const TWO_OPTIONS_REVERSED = [
|
|
{ id: "1ddc47be0d2315b9711ee8526ca9d83f", html: "This", votes: 4, rank: 0 },
|
|
{ id: "70e743697dac09483d7b824eaadb91e1", html: "That", votes: 5, rank: 0 },
|
|
];
|
|
|
|
const FIVE_OPTIONS = [
|
|
{ id: "1ddc47be0d2315b9711ee8526ca9d83f", html: "a", votes: 5, rank: 0 },
|
|
{ id: "70e743697dac09483d7b824eaadb91e1", html: "b", votes: 2, rank: 0 },
|
|
{ id: "6c986ebcde3d5822a6e91a695c388094", html: "c", votes: 4, rank: 0 },
|
|
{ id: "3e4a8f7e5f9d02f2bd7aebdb345c6ec2", html: "b", votes: 1, rank: 0 },
|
|
{ id: "a5e3e8c77ac2b1f43dd98ee6ff9d34e3", html: "a", votes: 1, rank: 0 },
|
|
];
|
|
|
|
const PRELOADEDVOTERS = {
|
|
db753fe0bc4e72869ac1ad8765341764: [
|
|
{
|
|
id: 1,
|
|
username: "bianca",
|
|
name: null,
|
|
avatar_template: "/letter_avatar_proxy/v4/letter/b/3be4f8/{size}.png",
|
|
},
|
|
],
|
|
};
|
|
|
|
module("Poll | Component | poll-results-standard", function (hooks) {
|
|
setupRenderingTest(hooks);
|
|
|
|
test("Renders the standard results Component correctly", async function (assert) {
|
|
this.setProperties({
|
|
options: TWO_OPTIONS,
|
|
pollName: "Two Choice Poll",
|
|
pollType: "single",
|
|
isPublic: true,
|
|
postId: 123,
|
|
vote: ["1ddc47be0d2315b9711ee8526ca9d83f"],
|
|
voters: PRELOADEDVOTERS,
|
|
votersCount: 9,
|
|
fetchVoters: () => {},
|
|
});
|
|
|
|
await render(hbs`<PollResultsStandard
|
|
@options={{this.options}}
|
|
@pollName={{this.pollName}}
|
|
@pollType={{this.pollType}}
|
|
@isPublic={{this.isPublic}}
|
|
@postId={{this.postId}}
|
|
@vote={{this.vote}}
|
|
@voters={{this.voters}}
|
|
@votersCount={{this.votersCount}}
|
|
@fetchVoters={{this.fetchVoters}}
|
|
/>`);
|
|
|
|
assert.strictEqual(queryAll(".option .percentage")[0].innerText, "56%");
|
|
assert.strictEqual(queryAll(".option .percentage")[1].innerText, "44%");
|
|
assert.ok(exists("ul.poll-voters-list"));
|
|
});
|
|
|
|
test("Omits voters for private polls", async function (assert) {
|
|
this.setProperties({
|
|
options: TWO_OPTIONS,
|
|
pollName: "Two Choice Poll",
|
|
pollType: "single",
|
|
isPublic: false,
|
|
postId: 123,
|
|
vote: ["1ddc47be0d2315b9711ee8526ca9d83f"],
|
|
voters: PRELOADEDVOTERS,
|
|
votersCount: 9,
|
|
fetchVoters: () => {},
|
|
});
|
|
|
|
await render(hbs`<PollResultsStandard
|
|
@options={{this.options}}
|
|
@pollName={{this.pollName}}
|
|
@pollType={{this.pollType}}
|
|
@isPublic={{this.isPublic}}
|
|
@postId={{this.postId}}
|
|
@vote={{this.vote}}
|
|
@voters={{this.voters}}
|
|
@votersCount={{this.votersCount}}
|
|
@fetchVoters={{this.fetchVoters}}
|
|
/>`);
|
|
|
|
assert.ok(!exists("ul.poll-voters-list"));
|
|
});
|
|
|
|
test("options in ascending order", async function (assert) {
|
|
this.setProperties({
|
|
options: TWO_OPTIONS_REVERSED,
|
|
pollName: "Two Choice Poll",
|
|
pollType: "single",
|
|
postId: 123,
|
|
vote: ["1ddc47be0d2315b9711ee8526ca9d83f"],
|
|
voters: PRELOADEDVOTERS,
|
|
votersCount: 9,
|
|
fetchVoters: () => {},
|
|
});
|
|
|
|
await render(hbs`<PollResultsStandard
|
|
@options={{this.options}}
|
|
@pollName={{this.pollName}}
|
|
@pollType={{this.pollType}}
|
|
@postId={{this.postId}}
|
|
@vote={{this.vote}}
|
|
@voters={{this.voters}}
|
|
@votersCount={{this.votersCount}}
|
|
@fetchVoters={{this.fetchVoters}}
|
|
/>`);
|
|
|
|
assert.strictEqual(queryAll(".option .percentage")[0].innerText, "56%");
|
|
assert.strictEqual(queryAll(".option .percentage")[1].innerText, "44%");
|
|
});
|
|
|
|
test("options in ascending order", async function (assert) {
|
|
this.setProperties({
|
|
options: FIVE_OPTIONS,
|
|
pollName: "Five Multi Option Poll",
|
|
pollType: "multiple",
|
|
postId: 123,
|
|
vote: ["1ddc47be0d2315b9711ee8526ca9d83f"],
|
|
voters: PRELOADEDVOTERS,
|
|
votersCount: 12,
|
|
fetchVoters: () => {},
|
|
});
|
|
|
|
await render(hbs`<PollResultsStandard
|
|
@options={{this.options}}
|
|
@pollName={{this.pollName}}
|
|
@pollType={{this.pollType}}
|
|
@postId={{this.postId}}
|
|
@vote={{this.vote}}
|
|
@voters={{this.voters}}
|
|
@votersCount={{this.votersCount}}
|
|
@fetchVoters={{this.fetchVoters}}
|
|
/>`);
|
|
|
|
let percentages = queryAll(".option .percentage");
|
|
assert.strictEqual(percentages[0].innerText, "41%");
|
|
assert.strictEqual(percentages[1].innerText, "33%");
|
|
assert.strictEqual(percentages[2].innerText, "16%");
|
|
assert.strictEqual(percentages[3].innerText, "8%");
|
|
|
|
assert.strictEqual(
|
|
queryAll(".option")[3].querySelectorAll("span")[1].innerText,
|
|
"a"
|
|
);
|
|
assert.strictEqual(percentages[4].innerText, "8%");
|
|
assert.strictEqual(
|
|
queryAll(".option")[4].querySelectorAll("span")[1].innerText,
|
|
"b"
|
|
);
|
|
});
|
|
});
|