mirror of
https://github.com/discourse/discourse.git
synced 2024-12-18 16:43:57 +08:00
ac7bf98ad1
Our method of loading a subset of client settings into tests via
tests/helpers/site-settings.js can be improved upon. Currently we have a
hardcoded subset of the client settings, which may get out of date and not have
the correct defaults. As well as this plugins do not get their settings into the
tests, so whenever you need a setting from a plugin, even if it has a default,
you have to do needs.setting({ ... }) which is inconvenient.
This commit introduces an ember CLI build step to take the site_settings.yml and
all the plugin settings.yml files, pull out the client settings, and dump them
into a variable in a single JS file we can load in our tests, so we have the
correct selection of settings and default values in our JS tests. It also fixes
many, many tests that were operating under incorrect assumptions or old
settings.
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
142 lines
4.2 KiB
JavaScript
142 lines
4.2 KiB
JavaScript
import { acceptance, query } from "discourse/tests/helpers/qunit-helpers";
|
|
import I18n from "I18n";
|
|
import { clearPopupMenuOptionsCallback } from "discourse/controllers/composer";
|
|
import selectKit from "discourse/tests/helpers/select-kit-helper";
|
|
import { test } from "qunit";
|
|
import { click, fillIn, visit } from "@ember/test-helpers";
|
|
|
|
acceptance("Details Button", function (needs) {
|
|
needs.user();
|
|
needs.hooks.beforeEach(() => clearPopupMenuOptionsCallback());
|
|
|
|
test("details button", async function (assert) {
|
|
const popupMenu = selectKit(".toolbar-popup-menu-options");
|
|
|
|
await visit("/");
|
|
await click("#create-topic");
|
|
const categoryChooser = selectKit(".category-chooser");
|
|
await categoryChooser.expand();
|
|
await categoryChooser.selectRowByValue(2);
|
|
|
|
await popupMenu.expand();
|
|
await popupMenu.selectRowByValue("insertDetails");
|
|
|
|
assert.strictEqual(
|
|
query(".d-editor-input").value,
|
|
`\n[details="${I18n.t("composer.details_title")}"]\n${I18n.t(
|
|
"composer.details_text"
|
|
)}\n[/details]\n`,
|
|
"it should contain the right output"
|
|
);
|
|
|
|
await fillIn(".d-editor-input", "This is my title");
|
|
|
|
const textarea = query(".d-editor-input");
|
|
textarea.selectionStart = 0;
|
|
textarea.selectionEnd = textarea.value.length;
|
|
|
|
await popupMenu.expand();
|
|
await popupMenu.selectRowByValue("insertDetails");
|
|
|
|
assert.strictEqual(
|
|
query(".d-editor-input").value,
|
|
`\n[details="${I18n.t(
|
|
"composer.details_title"
|
|
)}"]\nThis is my title\n[/details]\n`,
|
|
"it should contain the right selected output"
|
|
);
|
|
|
|
assert.strictEqual(
|
|
textarea.selectionStart,
|
|
21,
|
|
"it should start highlighting at the right position"
|
|
);
|
|
assert.strictEqual(
|
|
textarea.selectionEnd,
|
|
37,
|
|
"it should end highlighting at the right position"
|
|
);
|
|
|
|
await fillIn(".d-editor-input", "Before some text in between After");
|
|
|
|
textarea.selectionStart = 7;
|
|
textarea.selectionEnd = 28;
|
|
|
|
await popupMenu.expand();
|
|
await popupMenu.selectRowByValue("insertDetails");
|
|
|
|
assert.strictEqual(
|
|
query(".d-editor-input").value,
|
|
`Before \n[details="${I18n.t(
|
|
"composer.details_title"
|
|
)}"]\nsome text in between\n[/details]\n After`,
|
|
"it should contain the right output"
|
|
);
|
|
|
|
assert.strictEqual(
|
|
textarea.selectionStart,
|
|
28,
|
|
"it should start highlighting at the right position"
|
|
);
|
|
assert.strictEqual(
|
|
textarea.selectionEnd,
|
|
48,
|
|
"it should end highlighting at the right position"
|
|
);
|
|
|
|
await fillIn(".d-editor-input", "Before \nsome text in between\n After");
|
|
|
|
textarea.selectionStart = 8;
|
|
textarea.selectionEnd = 29;
|
|
|
|
await popupMenu.expand();
|
|
await popupMenu.selectRowByValue("insertDetails");
|
|
|
|
assert.strictEqual(
|
|
query(".d-editor-input").value,
|
|
`Before \n\n[details="${I18n.t(
|
|
"composer.details_title"
|
|
)}"]\nsome text in between\n[/details]\n\n After`,
|
|
"it should contain the right output"
|
|
);
|
|
|
|
assert.strictEqual(
|
|
textarea.selectionStart,
|
|
29,
|
|
"it should start highlighting at the right position"
|
|
);
|
|
assert.strictEqual(
|
|
textarea.selectionEnd,
|
|
49,
|
|
"it should end highlighting at the right position"
|
|
);
|
|
});
|
|
|
|
test("details button surrounds all selected text in a single details block", async function (assert) {
|
|
const multilineInput = "first line\n\nsecond line\n\nthird line";
|
|
const popupMenu = selectKit(".toolbar-popup-menu-options");
|
|
|
|
await visit("/");
|
|
await click("#create-topic");
|
|
const categoryChooser = selectKit(".category-chooser");
|
|
await categoryChooser.expand();
|
|
await categoryChooser.selectRowByValue(2);
|
|
await fillIn(".d-editor-input", multilineInput);
|
|
|
|
const textarea = query(".d-editor-input");
|
|
textarea.selectionStart = 0;
|
|
textarea.selectionEnd = textarea.value.length;
|
|
|
|
await popupMenu.expand();
|
|
await popupMenu.selectRowByValue("insertDetails");
|
|
|
|
assert.strictEqual(
|
|
query(".d-editor-input").value,
|
|
`\n[details="${I18n.t(
|
|
"composer.details_title"
|
|
)}"]\n${multilineInput}\n[/details]\n`,
|
|
"it should contain the right output"
|
|
);
|
|
});
|
|
});
|