mirror of
https://github.com/discourse/discourse.git
synced 2024-12-05 18:34:04 +08:00
dcaa719363
Subscriptions manager have been a pain since the beginning, one of the problem is that thread and channels behave mostly the same but with various small difference which I expect to increase over time. Trying to use subclasses for this case has proven to be a mistake, this commit now uses a class for each case (channel, thread) which for now contains a lot of duplication, which might be reduced in the future but has the merit to make reasoning about each case very simple. This refactor is fixing a bug introduced in90efdd7f9d
which was causing the wrong channel to be unsubscribed, this shouldn't be possible anymore. We had tests for this which were disabled due to flakeyness, I will consider re-enabling them in the future. Other notes: - notices had been added to the subscriptions manager service, they have been moved into their own dedicated service: `ChatChannelNoticesManager` - the `(each model)` trick used in `<ChatChannel />` since90efdd7f9d
to ensure atomicity has been applied to `<ChatThread />` too
110 lines
3.6 KiB
JavaScript
110 lines
3.6 KiB
JavaScript
import { click, render } from "@ember/test-helpers";
|
|
import hbs from "htmlbars-inline-precompile";
|
|
import { module, test } from "qunit";
|
|
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
|
|
import pretender from "discourse/tests/helpers/create-pretender";
|
|
import { query, queryAll } from "discourse/tests/helpers/qunit-helpers";
|
|
import I18n from "discourse-i18n";
|
|
import fabricators from "discourse/plugins/chat/discourse/lib/fabricators";
|
|
|
|
module("Discourse Chat | Component | chat-notice", function (hooks) {
|
|
setupRenderingTest(hooks);
|
|
|
|
test("displays all notices for a channel", async function (assert) {
|
|
this.channel = fabricators.channel();
|
|
this.manager = this.container.lookup("service:chatChannelNoticesManager");
|
|
this.manager.handleNotice({
|
|
channel_id: this.channel.id,
|
|
text_content: "hello",
|
|
});
|
|
this.manager.handleNotice({
|
|
channel_id: this.channel.id,
|
|
text_content: "goodbye",
|
|
});
|
|
this.manager.handleNotice({
|
|
channel_id: this.channel.id + 1,
|
|
text_content: "N/A",
|
|
});
|
|
|
|
await render(hbs`<ChatNotices @channel={{this.channel}} />`);
|
|
|
|
const notices = queryAll(".chat-notices .chat-notices__notice");
|
|
|
|
assert.strictEqual(notices.length, 2, "Two notices are rendered");
|
|
|
|
assert.true(notices[0].innerText.includes("hello"));
|
|
assert.true(notices[1].innerText.includes("goodbye"));
|
|
});
|
|
|
|
test("Notices can be cleared", async function (assert) {
|
|
this.channel = fabricators.channel();
|
|
this.manager = this.container.lookup("service:chatChannelNoticesManager");
|
|
this.manager.handleNotice({
|
|
channel_id: this.channel.id,
|
|
text_content: "hello",
|
|
});
|
|
|
|
await render(hbs`<ChatNotices @channel={{this.channel}} />`);
|
|
|
|
assert.strictEqual(
|
|
queryAll(".chat-notices .chat-notices__notice").length,
|
|
1,
|
|
"Notice is present"
|
|
);
|
|
|
|
await click(query(".chat-notices__notice__clear"), "Clear the notice");
|
|
|
|
assert.strictEqual(
|
|
queryAll(".chat-notices .chat-notices__notice").length,
|
|
0,
|
|
"Notice was cleared"
|
|
);
|
|
});
|
|
test("MentionWithoutMembership notice renders", async function (assert) {
|
|
this.channel = fabricators.channel();
|
|
this.manager = this.container.lookup("service:chatChannelNoticesManager");
|
|
const text = "Joffrey can't chat, hermano";
|
|
this.manager.handleNotice({
|
|
channel_id: this.channel.id,
|
|
notice_type: "mention_without_membership",
|
|
data: { user_ids: [1], message_id: 1, text },
|
|
});
|
|
|
|
await render(hbs`<ChatNotices @channel={{this.channel}} />`);
|
|
|
|
assert.strictEqual(
|
|
queryAll(
|
|
".chat-notices .chat-notices__notice .mention-without-membership-notice"
|
|
).length,
|
|
1,
|
|
"Notice is present"
|
|
);
|
|
|
|
assert.dom(".mention-without-membership-notice__body__text").hasText(text);
|
|
assert
|
|
.dom(".mention-without-membership-notice__body__link")
|
|
.hasText(I18n.t("chat.mention_warning.invite"));
|
|
|
|
pretender.post(`/chat/api/channels/${this.channel.id}/invites`, () => {
|
|
return [200, { "Content-Type": "application/json" }, {}];
|
|
});
|
|
|
|
await click(
|
|
query(".mention-without-membership-notice__body__link"),
|
|
"Invites the user"
|
|
);
|
|
|
|
// I would love to test that the invitation sent text is present here but
|
|
// dismiss is called right away instead of waiting 3 seconds.. Not much we can
|
|
// do about this - at least we are testing that nothing broke all the way through
|
|
// clearing the notice
|
|
assert.strictEqual(
|
|
queryAll(
|
|
".chat-notices .chat-notices__notice .mention-without-membership-notice"
|
|
).length,
|
|
0,
|
|
"Notice has been cleared"
|
|
);
|
|
});
|
|
});
|