github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-30 08:43:45 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
a92cf019db
discourse/app/assets/javascripts/admin/addon/components
History
Osama Sayegh a92cf019db
FIX: Make cancel and reset buttons work for file_size_restriction settings (#28347) 
This commit fixes a number of bugs in `file_size_restriction` settings and does a little of refactoring to reduce duplicated code in site setting types (the refactoring is necessary to fix one of the bugs).

The bugs in `file_size_restriction` settings that are fixed in this commit:

1. Save/cancel buttons next to a `file_size_restriction` setting are shown upon navigating to the settings page without changes being made to the setting
2. Cancel button that discards changes made to the setting doesn't work
3. Reset button that resets the setting to its default doesn't work
4. Validation error message isn't cleared when resetting/cancelling changes

To repro those bugs, navigate to `/admin/site_settings/category/files` and observe the top 2 settings in the page (`max image size kb` and `max attachment size kb`).

Internal topic: t/134726.
2024-08-15 19:38:47 +03:00
..
admin-config-area-cards/about FIX: Don't show blank space when there's no banner image (#28366) 2024-08-14 10:34:34 +03:00
admin-config-areas FIX: limit the number of custom flags to 50 (#28221) 2024-08-06 10:50:12 +10:00
form-template DEV: Use the "new" service import (#26059) 2024-03-06 18:05:11 +01:00
modal DEV: allows to alter category name/description (#28263) 2024-08-08 17:33:23 +02:00
report-filters FEATURE: Add WebHookEventsDailyAggregate report page (#27573) 2024-06-27 10:26:42 -03:00
schema-theme-setting DEV: Update htmlSafe imports (#26776) 2024-04-27 12:01:58 +02:00
site-settings FIX: Make cancel and reset buttons work for file_size_restriction settings (#28347) 2024-08-15 19:38:47 +03:00
admin-backups-logs.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
admin-backups-logs.js DEV: Rename I18n imports to discourse-i18n (#23915) 2023-10-18 11:07:09 +01:00
admin-config-area-card.gjs UX: group admin new features by month (#28106) 2024-07-29 14:20:12 +10:00
admin-config-header.gjs FIX: limit the number of custom flags to 50 (#28221) 2024-08-06 10:50:12 +10:00
admin-editable-field.hbs DEV: Update DButton uses (#23333) 2023-08-31 11:49:35 +02:00
admin-editable-field.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
admin-flag-item.gjs DEV: flaky toggle flag spec (#28292) 2024-08-09 09:56:10 +10:00
admin-flags-form.gjs UX: move admin flag form to form-kit (#28187) 2024-08-05 11:01:25 +10:00
admin-form-row.hbs FIX: Add checkbox-label to more checkbox label elements (#24174) 2023-10-31 08:57:50 +01:00
admin-form-row.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
admin-graph.js DEV: Fix ember/require-super-in-lifecycle-hooks (#24007) 2023-10-19 13:47:45 +02:00
admin-nav.gjs DEV: Sort imports 2023-10-10 21:46:54 +01:00
admin-penalty-history.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
admin-penalty-history.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
admin-penalty-post-action.hbs DEV: remove trivial {{action}} usages (#24278) 2023-11-08 10:53:06 +01:00
admin-penalty-post-action.js DEV: removes legacy modal code (#28047) 2024-07-24 18:07:17 +02:00
admin-penalty-reason.hbs DEV: Use class attribute instead of @class arg (#24804) 2023-12-12 13:09:05 +01:00
admin-penalty-reason.js DEV: Rename I18n imports to discourse-i18n (#23915) 2023-10-18 11:07:09 +01:00
admin-penalty-similar-users.hbs DEV: remove slightly less trivial {{action}} usages (#24289) 2023-11-13 13:29:20 +01:00
admin-penalty-similar-users.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
admin-plugin-config-area.gjs DEV: Clean up imports (#28060) 2024-07-25 15:09:06 +02:00
admin-plugin-config-metadata.gjs DEV: Add more structure for admin plugin config nav (#26707) 2024-05-02 11:36:46 +10:00
admin-plugin-config-page.gjs DEV: Simplify breadcrumbs by using path arg (#27744) 2024-07-08 17:55:03 +02:00
admin-plugin-config-top-nav.gjs DEV: Clean up imports (#28060) 2024-07-25 15:09:06 +02:00
admin-plugin-filtered-site-settings.gjs DEV: Clean up imports (#28060) 2024-07-25 15:09:06 +02:00
admin-plugins-list-item.gjs DEV: update the plugin outlet to be available just after name and badge (#28058) 2024-07-24 10:55:23 -04:00
admin-plugins-list.gjs DEV: Fix "ember/no-empty-glimmer-component-classes" lint (#24629) 2023-11-29 15:14:30 +01:00
admin-report-chart.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
admin-report-chart.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
admin-report-counters.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
admin-report-counters.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
admin-report-counts.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
admin-report-counts.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
admin-report-inline-table.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
admin-report-inline-table.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
admin-report-per-day-counts.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
admin-report-per-day-counts.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
admin-report-radar.hbs DEV: Add support for radar charts when displaying reports. (#24274) 2023-11-08 10:48:12 -03:00
admin-report-radar.js DEV: Add support for radar charts when displaying reports. (#24274) 2023-11-08 10:48:12 -03:00
admin-report-stacked-chart.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
admin-report-stacked-chart.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
admin-report-stacked-line-chart.hbs DEV: Add stacked line chart mode (#28203) 2024-08-02 09:40:27 -07:00
admin-report-stacked-line-chart.js DEV: Add stacked line chart mode (#28203) 2024-08-02 09:40:27 -07:00
admin-report-storage-stats.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
admin-report-storage-stats.js DEV: Rename I18n imports to discourse-i18n (#23915) 2023-10-18 11:07:09 +01:00
admin-report-table-cell.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
admin-report-table-cell.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
admin-report-table-header.hbs DEV: Update DButton uses (#23333) 2023-08-31 11:49:35 +02:00
admin-report-table-header.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
admin-report-table-row.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
admin-report-table-row.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
admin-report-table.hbs DEV: remove slightly less trivial {{action}} usages (#24289) 2023-11-13 13:29:20 +01:00
admin-report-table.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
admin-report-trust-level-counts.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
admin-report-trust-level-counts.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
admin-report.hbs DEV: remove trivial {{action}} usages (#24278) 2023-11-08 10:53:06 +01:00
admin-report.js DEV: Don't use attrs (#24323) 2023-11-27 12:16:31 +01:00
admin-reports.gjs FEATURE: separate admin page for whats new and reports (#26216) 2024-03-20 14:23:18 +11:00
admin-site-settings-filter-controls.gjs UX: Fix page content overflow when the setting category list is expanded on mobile (#27983) 2024-07-18 17:52:15 -06:00
admin-theme-editor.hbs DEV: remove slightly less trivial {{action}} usages (#24289) 2023-11-13 13:29:20 +01:00
admin-theme-editor.js UX: remove default use of quaternary color, update nav pill styles (#27502) 2024-06-24 09:54:34 -04:00
admin-user-field-item.hbs FEATURE: User fields required for existing users - Part 2 (#27172) 2024-06-25 19:32:18 +08:00
admin-user-field-item.js DEV: Convert components/admin-user-field-item to native class (#28174) 2024-07-31 19:06:59 +01:00
admin-watched-word.gjs DEV: Convert admin-watched-word to glimmer/gjs/dbutton (#28340) 2024-08-13 15:45:44 +02:00
color-input.hbs DEV: Use class attribute instead of @class arg (#24804) 2023-12-12 13:09:05 +01:00
color-input.js DEV: Don't use attrs (#24323) 2023-11-27 12:16:31 +01:00
dashboard-new-feature-item.gjs UX: group admin new features by month (#28106) 2024-07-29 14:20:12 +10:00
dashboard-new-features.gjs UX: group admin new features by month (#28106) 2024-07-29 14:20:12 +10:00
dashboard-period-selector.gjs DEV: Use the "new" service import (#26059) 2024-03-06 18:05:11 +01:00
dashboard-problems.hbs DEV: Update DButton uses (#23333) 2023-08-31 11:49:35 +02:00
dashboard-problems.js DEV: Convert admin component definitions to native class syntax (#20311) 2023-02-23 15:32:53 +00:00
email-styles-editor.hbs DEV: Update DButton uses (#23333) 2023-08-31 11:49:35 +02:00
email-styles-editor.js DEV: Use the "new" service import (#26059) 2024-03-06 18:05:11 +01:00
embeddable-host.hbs FEATURE: Extend embeddable hosts with Individual tags and author assignments (#26868) 2024-05-16 15:47:01 -04:00
embeddable-host.js FEATURE: Extend embeddable hosts with Individual tags and author assignments (#26868) 2024-05-16 15:47:01 -04:00
embedding-setting.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
embedding-setting.js DEV: Fix "no-setter-return" lint (#24585) 2023-11-28 10:49:49 +01:00
emoji-value-list.hbs FIX: Make cancel and reset buttons work for file_size_restriction settings (#28347) 2024-08-15 19:38:47 +03:00
emoji-value-list.js FIX: Make cancel and reset buttons work for file_size_restriction settings (#28347) 2024-08-15 19:38:47 +03:00
file-size-input.gjs FIX: Make cancel and reset buttons work for file_size_restriction settings (#28347) 2024-08-15 19:38:47 +03:00
flag-user-lists.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
flag-user-lists.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
flag-user.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
flag-user.js DEV: Convert admin component definitions to native class syntax (#20311) 2023-02-23 15:32:53 +00:00
highlighted-code.hbs DEV: Modernise highlightjs loading (#24197) 2023-11-10 20:39:48 +00:00
highlighted-code.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
inline-edit-checkbox.hbs DEV: Update DButton uses (#23333) 2023-08-31 11:49:35 +02:00
inline-edit-checkbox.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
install-theme-item.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
install-theme-item.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
ip-lookup.hbs DEV: revert missing license for maxmind changes (#24538) 2023-11-24 11:31:11 +11:00
ip-lookup.js DEV: Use the "new" service import (#26059) 2024-03-06 18:05:11 +01:00
moderation-history-item.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
permalink-form.hbs DEV: Use fn+mut instead of action+mut (#26057) 2024-03-06 18:05:03 +01:00
permalink-form.js DEV: Use the "new" service import (#26059) 2024-03-06 18:05:11 +01:00
plugin-commit-hash.gjs DEV: Convert various components to gjs (#26782) 2024-04-30 16:44:49 +02:00
screened-ip-address-form.hbs DEV: Use fn+mut instead of action+mut (#26057) 2024-03-06 18:05:03 +01:00
screened-ip-address-form.js DEV: Use the "new" service import (#26059) 2024-03-06 18:05:11 +01:00
secret-value-list.hbs FIX: Make cancel and reset buttons work for file_size_restriction settings (#28347) 2024-08-15 19:38:47 +03:00
secret-value-list.js FIX: Make cancel and reset buttons work for file_size_restriction settings (#28347) 2024-08-15 19:38:47 +03:00
setting-validation-message.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
setting-validation-message.js DEV: Convert admin component definitions to native class syntax (#20311) 2023-02-23 15:32:53 +00:00
silence-details.hbs DEV: Use class attribute instead of @class arg (#24804) 2023-12-12 13:09:05 +01:00
silence-details.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
simple-list.hbs DEV: Avoid using the old action helper (#26935) 2024-05-08 20:26:48 +02:00
simple-list.js DEV: Remove uses of @on from native classes (#27327) 2024-06-04 20:16:05 +02:00
site-customization-change-details.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
site-customization-change-details.js DEV: Convert admin component definitions to native class syntax (#20311) 2023-02-23 15:32:53 +00:00
site-customization-change-field.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
site-customization-change-field.js DEV: Convert admin component definitions to native class syntax (#20311) 2023-02-23 15:32:53 +00:00
site-setting.hbs FIX: Make cancel and reset buttons work for file_size_restriction settings (#28347) 2024-08-15 19:38:47 +03:00
site-setting.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
site-text-summary.hbs DEV: Update DButton uses (#23333) 2023-08-31 11:49:35 +02:00
site-text-summary.js DEV: Remove uses of @on from native classes (#27327) 2024-06-04 20:16:05 +02:00
staff-actions.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
staff-actions.js DEV: Sort imports 2023-10-10 21:46:54 +01:00
tags-uploader.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
tags-uploader.js DEV: Use the "new" service import (#26059) 2024-03-06 18:05:11 +01:00
theme-setting-editor.js DEV: Allow typed objects theme settings to be saved via settings editor (#26100) 2024-03-11 08:42:12 +08:00
theme-setting-relatives-selector.js DEV: Remove layoutName references to site-settings component template 2023-02-13 11:42:38 +00:00
theme-settings-editor.hbs FEATURE: JSON editor for theme settings (#21647) 2023-07-27 13:48:59 -04:00
theme-settings-editor.js DEV: Allow typed objects theme settings to be saved via settings editor (#26100) 2024-03-11 08:42:12 +08:00
theme-translation.js FEATURE: add language picker for theme translations in admin UI (#26150) 2024-03-18 12:00:28 -04:00
theme-upload-add.hbs UX: update appropriate btn-flat instances to btn-transparent (#25945) 2024-02-29 11:47:07 +01:00
theme-upload-add.js DEV: Rename I18n imports to discourse-i18n (#23915) 2023-10-18 11:07:09 +01:00
themes-list-item.gjs DEV: migrates themes-list-item to gjs (#27870) 2024-07-11 14:36:50 +02:00
themes-list.hbs DEV: migrates themes-list-item to gjs (#27870) 2024-07-11 14:36:50 +02:00
themes-list.js FEATURE: direct link to components for admin sidebar (#26644) 2024-04-17 11:45:59 +10:00
value-list.hbs DEV: remove trivial {{action}} usages (#24278) 2023-11-08 10:53:06 +01:00
value-list.js DEV: Remove uses of @on from native classes (#27327) 2024-06-04 20:16:05 +02:00
version-checks.hbs UX: rename the word "Upgrade" to "Update" in the UI. (#26396) 2024-04-02 20:04:37 +05:30
version-checks.js DEV: Convert admin component definitions to native class syntax (#20311) 2023-02-23 15:32:53 +00:00
watched-word-form.hbs UX: limit "outputs HTML" watched word option to replacements (#28063) 2024-07-25 16:25:56 -03:00
watched-word-form.js FEATURE: add HTML replacements 2024-05-14 10:41:27 +02:00
watched-word-uploader.hbs DEV: Colocate all admin component templates 2023-02-13 11:42:38 +00:00
watched-word-uploader.js DEV: Rename I18n imports to discourse-i18n (#23915) 2023-10-18 11:07:09 +01:00
webhook-event-chooser.hbs FEATURE: granular webhooks (#23070) 2023-10-09 03:35:31 +00:00
webhook-event-chooser.js DEV: Fix "no-setter-return" lint (#24585) 2023-11-28 10:49:49 +01:00
webhook-event.hbs FEATURE: Add Mechanism to redeliver all failed webhook events (#27609) 2024-07-08 15:43:16 -05:00
webhook-event.js DEV: Use the "new" service import (#26059) 2024-03-06 18:05:11 +01:00
webhook-events.hbs FEATURE: Add Mechanism to redeliver all failed webhook events (#27609) 2024-07-08 15:43:16 -05:00
webhook-events.js FEATURE: Add Mechanism to redeliver all failed webhook events (#27609) 2024-07-08 15:43:16 -05:00
webhook-status.hbs DEV: Apply prettier to hbs files 2022-12-28 13:11:12 +00:00
webhook-status.js DEV: Rename I18n imports to discourse-i18n (#23915) 2023-10-18 11:07:09 +01:00